Re: fts: Document this module

2023-01-19 Thread Jim Meyering
On Thu, Jan 19, 2023 at 7:05 PM Paul Eggert wrote: > > On 1/19/23 15:41, Bruno Haible wrote: > > Jim or Paul, what should we state > > — either in the 'fts' module description, or in the .texi documentation? > > The quick thing is to say in both that the description/documentation is > incomplete,

Re: Making _Noreturn a no-op in < Clang 16?

2023-01-19 Thread Sam James
> On 20 Jan 2023, at 03:40, Paul Eggert wrote: > > On 1/19/23 13:30, Sam James wrote: >> Right, I just meant that we don't tend to care about quieting warnings with >> older compilers, >> and it's not useful from a static analysis perspective here either given >> that older Clangs can't be tr

Re: Making _Noreturn a no-op in < Clang 16?

2023-01-19 Thread Paul Eggert
On 1/19/23 13:30, Sam James wrote: Right, I just meant that we don't tend to care about quieting warnings with older compilers, and it's not useful from a static analysis perspective here either given that older Clangs can't be trusted. It is of course useful as an attribute in general. I don'

Re: fts: Document this module

2023-01-19 Thread Paul Eggert
On 1/19/23 15:41, Bruno Haible wrote: Jim or Paul, what should we state — either in the 'fts' module description, or in the .texi documentation? The quick thing is to say in both that the description/documentation is incomplete, and that people need to read the source code. Jim may be able t

Re: fts: Document this module

2023-01-19 Thread Bruno Haible
> The gnulib fts is different from glibc API, and they can return > different results when called the same way. See end of earlier thread > here: > > https://lists.gnu.org/archive/html/bug-gnulib/2021-07/msg00070.html Thanks for the heads-up, Simon. > I'm not sure what could be done. Perhaps a

Re: fts: Document this module

2023-01-19 Thread Simon Josefsson via Gnulib discussion list
Bruno Haible writes: > The 'fts' module was not documented in the documentation, so far. The gnulib fts is different from glibc API, and they can return different results when called the same way. See end of earlier thread here: https://lists.gnu.org/archive/html/bug-gnulib/2021-07/msg00070.ht

Re: Making _Noreturn a no-op in < Clang 16?

2023-01-19 Thread Sam James
> On 19 Jan 2023, at 21:20, Paul Eggert wrote: > > On 1/19/23 12:44, Sam James wrote: >> _Noreturn is pretty much just an optimisation (and I'm not convinced that >> it's _needed_ in a lot of cases, rather just a useful hint). > > _Noreturn is not just an optimization: it's also useful for s

Re: Making _Noreturn a no-op in < Clang 16?

2023-01-19 Thread Paul Eggert
On 1/19/23 12:44, Sam James wrote: _Noreturn is pretty much just an optimisation (and I'm not convinced that it's _needed_ in a lot of cases, rather just a useful hint). _Noreturn is not just an optimization: it's also useful for static checking. For example: int f (int x) { if (

Re: More Android patches

2023-01-19 Thread Bruno Haible
I wrote: > In a second step, I looked for occurrences to AC_CHECK_FUNC[S] > or AC_CHECK_FUNCS_ONCE of these symbols. E.g. > for s in `cat in-8.txt`; do grep -rw "$s" m4 modules | grep CHECK_FUNC; > echo ; done > and replaced these with gl_CHECK_FUNCS_ANDROID invocations. Having finished and reg

Re: Making _Noreturn a no-op in < Clang 16?

2023-01-19 Thread Sam James
> On 19 Jan 2023, at 04:17, Paul Eggert wrote: > > The problem we found in Gawk was that this sort of function call: > >(b ? f : g) (x) > > is mishandled by Clang < 16 when one function is _Noreturn and the other > isn't, in that Clang mistakenly treats the call as if both functions are

fts: Document this module

2023-01-19 Thread Bruno Haible
The 'fts' module was not documented in the documentation, so far. 2023-01-19 Bruno Haible fts: Document this module. * doc/glibc-headers/fts.texi: Mention the 'fts' module. * doc/glibc-functions/fts_children.texi: Likewise. * doc/glibc-functions/fts_close.texi:

Re: API levels and functions on Android

2023-01-19 Thread Bruno Haible
Paul Eggert wrote: > > Defining REPLACE_GLOB=1 despite HAVE_GLOB=0 will be the way to make Gnulib > > define 'rpl_glob' instead of 'glob', so that there is no conflict with > > libc.so. > > > > I still need to work out the details how this would/will work. So as to > > do things correctly on Andr