Re: [PATCH] add new ronna and quetta SI prefixes

2022-11-29 Thread Pádraig Brady
On 29/11/2022 17:37, Bruno Haible wrote: The code looks good; thanks! As voted for in Nov 2022 but the BIPM: What does 'but' mean here? Did you mean "by the BIPM"? Right, had just fixed that locally :) thanks, Pádraig

Re: [PATCH] add new ronna and quetta SI prefixes

2022-11-29 Thread Bruno Haible
The code looks good; thanks! > As voted for in Nov 2022 but the BIPM: What does 'but' mean here? Did you mean "by the BIPM"? Bruno

[PATCH] add new ronna and quetta SI prefixes

2022-11-29 Thread Pádraig Brady
As voted for in Nov 2022 but the BIPM: https://www.bipm.org/en/cgpm-2022/resolution-3 * lib/human.c: Add Ronna (10^27), and Quetta (10^30) to the prefix list. * lib/xstrtol.c (__xstrtol): Likewise. --- ChangeLog | 9 + lib/human.c | 4 +++- lib/xstrtol.c | 10 +- 3 files c

Re: explicit_bzero and -std=c99

2022-11-29 Thread Bruno Haible
Simon Josefsson wrote: > > Perhaps Gnulib's other uses of asm should also be changed? > > Yes I think we should '__asm__' instead of 'asm' for the reason > explained by the gcc manual that Bruno linked to. The remaining uses of 'asm' (as opposed to '__asm__') are in lib/simple-atomic.c lib/as

Re: Numbered signals for shell trap cause z/OS grief

2022-11-29 Thread Eric Blake
On Sat, Nov 26, 2022 at 11:31:15AM -0800, Paul Eggert wrote: > As a style matter we should prefer "kill -INT ..." too, I suppose. I > installed the attached, which also fixes a couple of very minor pid_t > glitches. POSIX says XSI systems must support 'kill -INT' as a synonym for 'kill -s INT', bu

Update users.txt

2022-11-29 Thread Bruno Haible
Through a search for 'gnulib-tool' across all Debian source-code packages [1] I found 19 more packages that use Gnulib. [1] https://codesearch.debian.net/ 2022-11-29 Bruno Haible Update users.txt. * users.txt: Add 4ti2, ale, amanda, binfmt-support, cgminer, collectd,

Re: [PATCH] Basic support for checking NFSv4 ACLs in Linux

2022-11-29 Thread Andreas Grünbacher
Am Mo., 28. Nov. 2022 um 08:29 Uhr schrieb Ondrej Valousek : > Hi Andreas, > > - I do not quite understand. I did not bother copying the who value into > extra buffer hence I am using strncmp instead of strcmp and therefore can't > use strlen. The checks are sufficient there. Please ask yourself

Re: [PROPOSED 4/4] explicit_bzero: implement via memset_explicit

2022-11-29 Thread Bruno Haible
Paul Eggert wrote: > Thanks for the detailed review. I installed the patches with corrections > that I hope addressed all your comments. Thanks Paul. Very nice! > > I don't understand the purpose of this line: > > memset (checkbuf, i, SECRET_SIZE); > > Wouldn't it be better to have > >