Paul Eggert wrote:
> Thanks for the detailed review. I installed the patches with corrections 
> that I hope addressed all your comments.

Thanks Paul. Very nice!

> > I don't understand the purpose of this line:
> >          memset (checkbuf, i, SECRET_SIZE);
> > Wouldn't it be better to have
> >          memcpy (stbuf, SECRET, SECRET_SIZE);
> > instead?
> 
> I added the latter call but kept the former

Perfect. Indeed, I misread the proposed code. Sorry.

Bruno




Reply via email to