ffsl, ffsll: Work around AIX 7.2 problem

2021-01-03 Thread Bruno Haible
ffsl and ffsll are declared in on glibc (presumably because is considered outdated). Whereas in AIX 7.2 they are declared in (presumably because POSIX specifies that ffs is specified in ). So, code that expects to find ffsl and ffsll in fails to compile on AIX 7.2. This patch fixes it. 2021-

ssfmalloc: Fix includes

2021-01-03 Thread Bruno Haible
The #include statements were not exactly right here: 2021-01-04 Bruno Haible ssfmalloc: Fix includes. * lib/ssfmalloc.h: Include , for ffs(). * tests/test-ssfmalloc.c: Include , for memset(). diff --git a/lib/ssfmalloc.h b/lib/ssfmalloc.h index d5e0a1e..8fdb2b1 100644

Re: quotearg tests: Avoid test failures on Solaris 11

2021-01-03 Thread Bruno Haible
> 2021-01-01 Bruno Haible > > quotearg tests: Avoid test failures on Solaris 11. > * modules/quotearg-tests (Makefile.am): Set host_os in > TESTS_ENVIRONMENT. > * tests/test-quotearg.sh: On Solaris 11 systems, make a copy of the fr/ > directory that contains the .m

tests: Fix various link errors on Solaris

2021-01-03 Thread Bruno Haible
On Solaris, with libunistring installed, a testdir (that includes module 'libunistring-optional' in particular) exhibits a couple of link errors: gcc -m64 -O2 -g -O2 -L/home/haible/prefix-x86_64/lib -o test-exclude test-exclude.o libtests.a ../gllib/libgnu.a libtests.a ../gllib/libgnu.a libtes

c32ispunct tests: Avoid test failures on FreeBSD

2021-01-03 Thread Bruno Haible
On FreeBSD 12.1.1, I see a test failure: FAIL: test-c32ispunct.sh This patch fixes it. 2021-01-03 Bruno Haible c32ispunct tests: Avoid test failures on FreeBSD. * tests/test-c32ispunct.c (main): On FreeBSD, disable tests that fail on FreeBSD 12.1.1. diff --git a/t

Re: passfd test failure on FreeBSD 12.0

2021-01-03 Thread Bruno Haible
I wrote in : > On FreeBSD 12.0 — but not on FreeBSD 11.0 and 12.2 —, I'm seeing a test > failure of the Gnulib 'passfd' test: > > recvfd: Permission denied > FAIL test-passfd (exit status: 16) Likewise on FreeBSD 12.1.1 and

Re: iconv: document not-fixed bugs, using POSIX terminology

2021-01-03 Thread Bruno Haible
Noah Misch wrote: > If https://pubs.opengroup.org/onlinepubs/9699919799/functions/iconv.html used > "identical" to mean "same byte sequence", it would be requiring an ISO-8859-1 > => > UTF-8 conversion to increment the iconv() return value upon converting 0xA1 to > 0xC2 0xA1. Most implementations

Re: valgrind-tests

2021-01-03 Thread Bruno Haible
Simon Josefsson wrote: > Btw, I just realized the module is confusingly named, since > modules/*-tests is used in gnulib to designate gnulib module self-tests. > Nothing appears to break, and I can't think of a better name right now > ('valgrind' is a bit too general and non-descriptive of what the

Re: iconv: document not-fixed bugs, using POSIX terminology

2021-01-03 Thread Noah Misch
On Sun, Jan 03, 2021 at 08:48:20PM +0100, Bruno Haible wrote: > > iconv.m4 clears HAVE_ICONV if it detects iconv() bugs. Docs list those bugs > > under "Portability problems fixed by Gnulib:". If changing HAVE_ICONV were > > enough to qualify as a fix, then "This function is missing on some > >

Re: GNU SASL 1.9.2 and valgrind

2021-01-03 Thread Simon Josefsson via Gnulib discussion list
Bruno Haible writes: >> Right. It would be nice if gnulib's valgrind m4 test was a bit >> smarter, maybe it should try to build a small program printing >> something to stdout and see if valgrind is able to run it and that it >> prints the magic string to stdout. If that doesn't work, disable >

[PATCH] doc: Repeat warning that --with-tests cannot be used twice.

2021-01-03 Thread Simon Josefsson via Gnulib discussion list
Hi. I am experimenting with using bootstrap+gnulib in a project that has a library and a command-line tool, and thus needs two gnulib instances. The limitation that --with-tests cannot be used in this case is helpful to repeat in the relevant section, it caused hard to understand build errors. D

Re: Issue when testing with --as-needed enabled

2021-01-03 Thread Bruno Haible
Hi, Thomas Andrejak wrote: > On debian 9 /10 / testing > ... > > > But, event with this patch, I still have build failure and I need to do > > > some patches like that : > > > > > https://salsa.debian.org/totol-guest/libprelude/-/blob/master/debian/patches/013-fix-test_rwlock1.patch > > > > > > I

Re: iconv: document not-fixed bugs, using POSIX terminology

2021-01-03 Thread Bruno Haible
Hi Noah, Thanks for the patch and explanations from . > iconv.m4 clears HAVE_ICONV if it detects iconv() bugs. Docs list those bugs > under "Portability problems fixed by Gnulib:". If changing HAVE_ICONV were > enough to quali

Re: test-free: fails with -flto=auto

2021-01-03 Thread Bernhard Voelker
On 1/3/21 11:21 AM, Bruno Haible wrote: > It's not that slow. I like it :-) Installed as follows: Great, thanks! Have a nice day, Berny

stddef: Override wrong max_align_t on AIX 7 with xlc in 64-bit mode

2021-01-03 Thread Bruno Haible
On AIX 7.1, 7.2, with xlc in 64-bit mode, I see this test compilation failure: "../../gltests/test-stddef.c", line 57.1: 1506-044 (S) Expression must be a non-negative integer constant. "../../gltests/test-stddef.c", line 58.1: 1506-044 (S) Expression must be a non-negative integer constant. "..

Re: test-free: fails with -flto=auto

2021-01-03 Thread Bruno Haible
Hi Berny, > hmm, I tried a couple of things like declaring the variable err as static. > The only combination I found to work is: > > diff --git a/lib/free.c b/lib/free.c > index 135c3eb..e923ee5 100644 > --- a/lib/free.c > +++ b/lib/free.c > @@ -27,7 +27,10 @@ void > rpl_free (void *p) > #unde