Re: [PATCH] localename: Port to cygwin 2.6.

2017-05-18 Thread Bruno Haible
Eric Blake wrote on 2017-01-19: > > * lib/localename.c (gl_locale_name_thread_unsafe): Add clause for > > Cygwin. It relies on the NL_LOCALE_NAME macro, which is defined in . Better than to hope that it gets included by chance, include it explicitly. 2017-05-18 Bruno Haible localenam

Re: FLEXALIGNOF too pessimistic

2017-05-18 Thread Paul Eggert
On 05/18/2017 02:57 PM, Bruno Haible wrote: a) Cap this alignment at max_align_t. b) Use , as in the patch below (untested). (a) sounds reasonable. I don't think (b) will be portable enough, because on some pre-C11 compilers the Gnulib substitute for _Alignof does not work on structure

FLEXALIGNOF too pessimistic

2017-05-18 Thread Bruno Haible
Hi Paul, The FLEXALIGNOF macro, from flexmember.h, in the pre-C11 or C++ case, returns unreasonably large values. When we have a struct { int a[64]; char c[]; } and use FLEXALIGNOF, it will return 256. Which means that if one wants to allocate such a struct with 4 elements of c[], one will all

gettext: update macros from gettext

2017-05-18 Thread Bruno Haible
2017-05-18 Bruno Haible gettext: Update macros from gettext git. * m4/intldir.m4: Require Autoconf >= 2.60. * m4/progtest.m4: Fix typos in copyright notice. diff --git a/m4/intldir.m4 b/m4/intldir.m4 index c688f46..8d74bda 100644 --- a/m4/intldir.m4 +++ b/m4/intldir.m4

Re: test-copy-file build error on CentOS 6

2017-05-18 Thread Bruno Haible
Hello Tom, > I just noticed that I am unable to build a gnulib snapshot with tests on > CentOS 6: > > gcc -std=gnu99 -g -O2 -Wall -o test-copy-file test-copy-file.o > ../gllib/libgnu.a -lacl -lm -lm -lm -lm -lm -lm -lm -lm -lm -lm -lm > ../gllib/libgnu.a(gettime.o): In function `gettime': >

Re: make coverage

2017-05-18 Thread Bruno Haible
Hi Tim, > > What do you get if you change the value 500 in > > tests/test-fprintf-posix2.c to a larger or smaller value? > > Both succeed with 5000 (10x higher). Good, that's the way I'd like to see it fixed. But a malloc(50 MB) is extraordinary; some people are using embedded systems. C

test-copy-file build error on CentOS 6

2017-05-18 Thread Tom G. Christensen
Hello, I just noticed that I am unable to build a gnulib snapshot with tests on CentOS 6: gcc -std=gnu99 -g -O2 -Wall -o test-copy-file test-copy-file.o ../gllib/libgnu.a -lacl -lm -lm -lm -lm -lm -lm -lm -lm -lm -lm -lm ../gllib/libgnu.a(gettime.o): In function `gettime': /home/tgc/proj

Re: make coverage

2017-05-18 Thread Tim Rühsen
On Donnerstag, 18. Mai 2017 19:29:18 CEST Bruno Haible wrote: > Tim Rühsen wrote: > > $ ./gnulib-tool --create-testdir --dir=../testdir1 > > $ cd ../testdir > > $ ./configure CFLAGS="-g -coverage" > > $ make clean && make coverage > > I did > $ ./gnulib-tool --create-testdir --dir=../testdir-all >

Re: make coverage

2017-05-18 Thread Bruno Haible
Tim Rühsen wrote: > $ ./gnulib-tool --create-testdir --dir=../testdir1 > $ cd ../testdir > $ ./configure CFLAGS="-g -coverage" > $ make clean && make coverage I did $ ./gnulib-tool --create-testdir --dir=../testdir-all $ cd ../testdir-all $ ./configure CFLAGS="-ggdb --coverage" $ make coverage an

Re: select() issue in MinGW build

2017-05-18 Thread Bruno Haible
> Currently discussed here: > https://gitlab.com/gnuwget/wget2/issues/212 Note that 'wine' is *not* a supported platform for gnulib. It is already time consuming enough to try to support mingw and MSVC. Supporting 'wine' would mean to additionally deal with the bugs in 'wine' (i.e. analyze them,

Re: select() issue in MinGW build

2017-05-18 Thread Bruno Haible
Hi, > are there know issues with select() when build for MinGW ? Yes. 1) In https://lists.gnu.org/archive/html/bug-gnulib/2016-12/msg00112.html you can see that we have known test failures. 2) Gnulib's implementation of select() cannot look at the sockets at the non-sockets (files and pipes

select() issue in MinGW build

2017-05-18 Thread Tim Rühsen
Hi, are there know issues with select() when build for MinGW ? Code is basically: FD_ZERO(&fdset); FD_SET(fd, &fdset); rd = &fdset; wr = &fdset; select (fd + 1, rd, wr, NULL, NULL); Select() always immediately comes back with 0, WSAGetLastError() return 6 (WSA_INVALID_HANDLE). fd is a valid

Re: automated CI testing

2017-05-18 Thread Tim Rühsen
On 05/17/2017 09:43 PM, Assaf Gordon wrote: > Hello, > > On Wed, May 17, 2017 at 09:20:33PM +0200, Tim Rühsen wrote: >> On Mittwoch, 17. Mai 2017 19:09:52 CEST Bruno Haible wrote: >>> >>> > What about automated / CI testing ? > >>> [...] Therefore what is more valuable >>> for gnulib (IMO) is aut

Re: make coverage

2017-05-18 Thread Tim Rühsen
On 05/18/2017 01:00 PM, Bruno Haible wrote: > Hi Tim, > >> Processing file gllib/gllib/unicase/special-casing-table.gperf >> genhtml: ERROR: cannot read >> /usr/oms/src/testdir1/gllib/gllib/unicase/special-casing-table.gperf >> maint.mk:1500: recipe for target 'gen-coverage' failed >> >> (Maybe th

Re: make coverage

2017-05-18 Thread Tim Rühsen
binISaaHroFt0.bin Description: PGP/MIME version identification encrypted.asc Description: OpenPGP encrypted message

Re: make coverage

2017-05-18 Thread Tim Rühsen
On 05/17/2017 06:40 PM, Bruno Haible wrote: > Hi Tim, > >> 'make coverage' fails here due to two tests failing, thus no coverage >> report is created. >> I couldn't find a better solution. > > In the comment, you write "possible crash when compiled with -coverage". > Our tests should not crash, w

Re: make coverage

2017-05-18 Thread Bruno Haible
Hi Tim, > Processing file gllib/gllib/unicase/special-casing-table.gperf > genhtml: ERROR: cannot read > /usr/oms/src/testdir1/gllib/gllib/unicase/special-casing-table.gperf > maint.mk:1500: recipe for target 'gen-coverage' failed > > (Maybe this is because I still use gperf 3.0.4 !?) The gperf-

Re: gperf 3.1 breaks module unicase

2017-05-18 Thread Bruno Haible
On 2017-02-13 I wrote: > If you have some more time to play with it, how about mechanically copying > the declaration from the generated file into lib/unicase/special-casing.h ? > I mean, to modify the module description with a command such as > > grep '^gl_unicase_special_lookup' $(srcdir)/unic

Re: automated CI testing

2017-05-18 Thread Tim Rühsen
bineb3WvVyDgw.bin Description: PGP/MIME version identification encrypted.asc Description: OpenPGP encrypted message