On 05/17/2017 06:40 PM, Bruno Haible wrote: > Hi Tim, > >> 'make coverage' fails here due to two tests failing, thus no coverage >> report is created. >> I couldn't find a better solution. > > In the comment, you write "possible crash when compiled with -coverage". > Our tests should not crash, with or without --coverage, on glibc systems. > > IMO we should try to make these tests not crash. > > What is the list of steps for "How to reproduce"?
$ ./gnulib-tool --create-testdir --dir=../testdir1
$ cd ../testdir
$ ./configure CFLAGS="-g -coverage"
$ make clean && make coverage
In file included from unicase/special-casing.c:25:0:
./unicase/special-casing-table.h:63:1: error: conflicting types for
'gl_unicase_special_lookup'
gl_unicase_special_lookup (register const char *str, register unsigned
int len)
^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from unicase/special-casing.c:21:0:
unicase/special-casing.h:61:8: note: previous declaration of
'gl_unicase_special_lookup' was here
gl_unicase_special_lookup (const char *str, size_t len);
^~~~~~~~~~~~~~~~~~~~~~~~~
$ vi gllib/unicase/special-casing-table.h # change 'len' to size_t in L63
$ make coverage
...
# FAIL: 9
7 failures are due to using system libunistring (Version
0.9.6+really0.9.3-0.1) and can be avoided by ./configure
--with-included-libunistring.
The other 2 are
FAIL: test-printf-posix2.sh
FAIL: test-fprintf-posix2.sh
$ cat gltests/test-printf-posix2.sh.log
Segmentation fault
FAIL test-printf-posix2.sh (exit status: 1)
$ valgrind gltests/./test-printf-posix2 0
...
==2265== Cannot map memory to grow the stack for thread #1 to 0xffeffb000
==2265==
==2265== Process terminating with default action of signal 11 (SIGSEGV)
==2265== Access not within mapped region at address 0xFFEFFB43C
==2265== Cannot map memory to grow the stack for thread #1 to 0xffeffb000
==2265== at 0x10A296: gcov_do_dump (in
/usr/oms/src/testdir1/gltests/test-printf-posix2)
...
Segmentation fault
I can not reproduce this when starting with
$ ./gnulib-tool --create-testdir --dir=../testdir1 --single-configure
printf-posix printf-posix-tests maintainer-makefile
With Best Regards, Tim
signature.asc
Description: OpenPGP digital signature
