Re: test-stdalign.c fails to compile on i686

2015-10-18 Thread Paul Eggert
Jim Meyering wrote: Testing on i686 at all was mostly on a whim. This is not a release blocker, by a long shot. True. Still, it's annoying. I built GCC 4.7.2 and reproduced the bug. We had a workaround for this bug in m4/stdalign.m4 and lib/stdalign.in.h, but the workaround failed if -std=gn

test-stdalign.c fails to compile on i686

2015-10-18 Thread Jim Meyering
Hi Paul, Preparing for the release of grep-2.22, I ran its tests on an old i686 system with gcc-4.7.2 and other fedora-18-era tools, that triggered the failure of this static assertion in test-stdalign.c: CHECK_STATIC (int64_t); That arises because this "verify" expression is false: #define

Re: a ChangeLog typo and two sc_tight_scope fixes

2015-10-18 Thread Jim Meyering
On Sun, Oct 18, 2015 at 2:36 PM, Pádraig Brady wrote: > On 18/10/15 22:33, Pádraig Brady wrote: >> On 18/10/15 05:04, Jim Meyering wrote: >>> I've just pushed the following three patches: >> >> Nice. Note this improvement triggered new >> syntax check failures on coreutils >> >> $ make sc_tight_

Re: a ChangeLog typo and two sc_tight_scope fixes

2015-10-18 Thread Pádraig Brady
On 18/10/15 22:33, Pádraig Brady wrote: > On 18/10/15 05:04, Jim Meyering wrote: >> I've just pushed the following three patches: > > Nice. Note this improvement triggered new > syntax check failures on coreutils > > $ make sc_tight_scope > prog_fprintf > rm > defaultcon > restorecon >

Re: a ChangeLog typo and two sc_tight_scope fixes

2015-10-18 Thread Pádraig Brady
On 18/10/15 05:04, Jim Meyering wrote: > I've just pushed the following three patches: Nice. Note this improvement triggered new syntax check failures on coreutils $ make sc_tight_scope prog_fprintf rm defaultcon restorecon ... That's because the gnulib rule was working on an invalid

Re: [PATCH] time_rz: avoid warning from bleeding-edge gcc's -Wnonnul

2015-10-18 Thread Jim Meyering
On Sun, Oct 18, 2015 at 10:28 AM, Paul Eggert wrote: > Jim Meyering wrote: >> >> Building coreutils configured with --enable-gcc-warnings and using >> bleeding-edge gcc evoked a build failure due to the time_rz module. >> The attached patch removes the warning/error-evoking test. > > > This patch

Re: [PATCH] time_rz: avoid warning from bleeding-edge gcc's -Wnonnul

2015-10-18 Thread Paul Eggert
Jim Meyering wrote: Building coreutils configured with --enable-gcc-warnings and using bleeding-edge gcc evoked a build failure due to the time_rz module. The attached patch removes the warning/error-evoking test. This patch doesn't look right: if localtime_r fails, the original code returns N

Re: bug#21700: new snapshot available: grep-2.21.78-7da30

2015-10-18 Thread Paul Eggert
Aaron Davies wrote: I ran into this trying to build current coreutils on Solaris with sun studio 11 the workaround I found was to use sun studio 12 I'm also using Sun Studio 12. That being said, I now see that I was using Sun C 5.9 (Patch 124867-12 2009/11/22), which is the original Sun Studi

[PATCH] time_rz: avoid warning from bleeding-edge gcc's -Wnonnul

2015-10-18 Thread Jim Meyering
Building coreutils configured with --enable-gcc-warnings and using bleeding-edge gcc evoked a build failure due to the time_rz module. The attached patch removes the warning/error-evoking test. I also tested by running this: ./gnulib-tool --create-testdir --dir=/tmp/x --with-tests --test time_rz