Okay, I tested your latest changes (git 4d83e798). There is one
assertion that needs to be #ifdef'ed out for EBCDIC:
$ ./test-c-ctype
/path/to/gltests/test-c-ctype.c:62: assertion 'c_isascii (c) == (c >= 0 &&
c < 0x80)' failed
CEE5207E The signal SIGABRT was received.
ABORT instru
Code that
uses c-ctype wants only ASCII letters, and departing from this would
likely break things.
How would that match occur? c_isalpha() was/is using a "switch"
statement for EBCDIC.
Oh, sorry, I was assuming that the substitution was being proposed for all the
functions; but it's being pr
On Tue, 2015 Sep 22 15:03-0700, Paul Eggert wrote:
> Thanks for explaining. I still see a problem with the proposed patch,
> though, in that (if I'm understanding it correctly) it would cause
> c_isalpha (120) to succeed, even though EBCDIC 120 corresponds to
> U+00CC LATIN CAPITAL LETTER I WITH G
Thanks for explaining. I still see a problem with the proposed patch,
though, in that (if I'm understanding it correctly) it would cause
c_isalpha (120) to succeed, even though EBCDIC 120 corresponds to U+00CC
LATIN CAPITAL LETTER I WITH GRAVE, and that is not supposed to be an
alphabetic char
On Tue, 2015 Sep 22 14:08-0600, Eric Blake wrote:
> On 09/22/2015 02:00 PM, Paul Eggert wrote:
> >>
> >> wc: file "//dev/null": EDC5047I An invalid file name was specified
> >> as a function parameter
> >
> > How about if we add //dev/null to the configure-time test as to
> > whether / and // are t
On Tue, 2015 Sep 22 12:50-0700, Paul Eggert wrote:
> A few non-ctype-related comments:
>
> Omit parens around arguments of 'defined', e.g., say "defined __MVS__"
> not "defined (__MVS__)".
Understood.
> I agree with Eric that we should rename "__string" rather than fiddle
> with #undefing it. I
Hi Paul,
On Tue, 2015 Sep 22 12:32-0700, Paul Eggert wrote:
> Thanks for looking into this. I have some questions about the c-ctype
> changes. It appears that the proposed patch defers to the system
> functions (which use the current locale), but that's not the intent of
> c-ctype: it's supposed
On 09/22/2015 12:27 PM, Daniel Richard G. wrote:
Wouldn't it be easier to apply everything to a feature branch, and
integrate it bit by bit?
You can do that in your own repository if it makes things simpler, but
for something this small I'd rather just see patches via email.
wc: file "//dev/
On 09/22/2015 02:00 PM, Paul Eggert wrote:
>> wc: file "//dev/null": EDC5047I An invalid file name was specified as
>> a function parameter
>
> How about if we add //dev/null to the configure-time test as to whether
> / and // are the same? If //dev/null doesn't work, then / and // are
> not the
Ooops, I forgot to add a dependency. I installed the attached followup
patch.
>From 07ed58f3c5b54fe3935ce522dbc1c1a716185e67 Mon Sep 17 00:00:00 2001
From: Paul Eggert
Date: Tue, 22 Sep 2015 12:44:25 -0700
Subject: [PATCH] * modules/c-ctype (Depends-on): Add verify.
---
ChangeLog | 1 +
A few non-ctype-related comments:
Omit parens around arguments of 'defined', e.g., say "defined __MVS__"
not "defined (__MVS__)".
I agree with Eric that we should rename "__string" rather than fiddle
with #undefing it. It's just a placeholder name. I suggest renaming it
to "__str". We can
Thanks for looking into this. I have some questions about the c-ctype
changes. It appears that the proposed patch defers to the system
functions (which use the current locale), but that's not the intent of
c-ctype: it's supposed to correspond to a stripped down POSIX "C" locale
regardless of
Hi Eric,
On Tue, 2015 Sep 22 09:23-0600, Eric Blake wrote:
>
> Thanks for the work. Can you please split the patch into a series of
> multiple pieces, one patch per issue, so that we can apply the obviously-
> correct ones while still discussing the other pieces, rather than
> holding the entire l
On 09/21/2015 08:28 PM, Daniel Richard G. wrote:
> Hello list,
>
> The attached patch, against Git master, addresses numerous
> incompatibilities in Gnulib with IBM z/OS (a mainframe operating system)
> and the EBCDIC encoding.
>
> With my changes, Gnulib builds successfully, and most of the test
14 matches
Mail list logo
