On Tue, 2015 Sep 22 12:50-0700, Paul Eggert wrote: > A few non-ctype-related comments: > > Omit parens around arguments of 'defined', e.g., say "defined __MVS__" > not "defined (__MVS__)".
Understood. > I agree with Eric that we should rename "__string" rather than fiddle > with #undefing it. It's just a placeholder name. I suggest renaming > it to "__str". We can backport this to glibc eventually. Might it be better to forgo the double-underscore prefix? (Why not just use "s"?) > In strtod.c, don't bother with "if (errno == ERANGE) errno = 0;". Just > do "errno = 0;". Understood. I was after a narrow fix to this issue. > Also in strtod.c, don't assume isnand exists. That is, replace > "!isnand(num)" with "num == num". > > Update serial numbers in changed .m4 files. > > In m4/fclose.m4, gl_FUNC_FCLOSE should > AC_REQUIRE([AC_CANONICAL_HOST]). Also, it should test $host_os rather > than $host. > > In m4/strstr.m4, the __MVS__ failure should be at compile-time, with > #error, rather than at run-time. That's better if cross-compiling. > > In comments, prefer imperatives, e.g., "Instead, temporarily redefine > ..." rather than "Instead, we temporarily redefine ...". This is > standard GNU style and is shorter. Roger all that. > The get_rusage_as code has duplications. Simpler would be: Agreed, but that's in the "general clean-up" category :) --Daniel -- Daniel Richard G. || sk...@iskunk.org My ASCII-art .sig got a bad case of Times New Roman.
