On 14 April 2012 20:17, Reuben Thomas wrote:
> On 14 April 2012 19:44, Bruno Haible wrote:
>> Reuben Thomas wrote:
>>> I see that gnulib has its own cfg.mk which is used, for example, to
>>> skip some syntax-check checks on gnulib's own code.
>>> ...
>>> I can't see that gnulib's cfg.mk is mentio
Hi Paul,
> I'd omit the comment
These comments are necessary for maintenance. When I (or Eric or anyone
else in the future) modifies this code, we need to know which piece of code
applies to which platforms, so that
1. we don't waste time modifying code that has no influence on the
platfor
Just some very minor comments about comments ---
On 04/15/2012 09:57 AM, Bruno Haible wrote:
> +#if _GL_WINDOWS_64_BIT_OFF_T
> +# undef fseeko
> +# if HAVE__FSEEKI64 /* msvc, mingw64 */
I'd omit the comment, which was inserted in multiple places, as I find
it more distracting than helpful. It's
Bruno Haible wrote:
>> the new names, gl_LARGEFILE and USE_64_BIT_OFF_T
>> sound like things that one would use and expect to be set (resp.)
>> even on non-Windows systems. What do you think about changing
>> the names to make it clear that they are useful only when building
>> on mingw?
>
> gl_LA
Hi Jim,
> the new names, gl_LARGEFILE and USE_64_BIT_OFF_T
> sound like things that one would use and expect to be set (resp.)
> even on non-Windows systems. What do you think about changing
> the names to make it clear that they are useful only when building
> on mingw?
gl_LARGEFILE is the macr
> the mingw64 headers provide a partial "Large File Support".
> Namely, for
> off_t
>(lseek, ftruncate)
>(fseeko, ftello)
And even this partial support is only partially working.
They define a function ftruncate64, and "#define ftruncate ftruncate64".
This function
1) violates POSIX:
For me, the configure test "checking whether lseek detects pipes..." reports
- "no" on mingw2009 and MSVC9,
- "yes" on mingw2011 and mingw64
for no immediately apparent reason: The function 'lseek' comes from MSVCRT
in all cases.
The reason is that I run the mingw2009 and MSVC9 environments fr
> These bright guys (the mingw64 developers) meant to fix one stat() bug,
> but
> 1) in the process, opened another bug,
> 2) did not apply their fix to the other variants (_stat, _stat64, etc.)
Observation confirmed by looking at the mingw64 source code:
http://mingw-w64.sourcearchive.com/doc
> My advice would be first to ask the currently active mingw development
> group, namely the mingw64 project [5], whether they plan to add
> "Large File Support" to their header files.
It turns out, the mingw64 headers provide a *partial* "Large File Support".
Namely, for
off_t
(lseek, ftrunc
