Just some very minor comments about comments --- On 04/15/2012 09:57 AM, Bruno Haible wrote:
> +#if _GL_WINDOWS_64_BIT_OFF_T > +# undef fseeko > +# if HAVE__FSEEKI64 /* msvc, mingw64 */ I'd omit the comment, which was inserted in multiple places, as I find it more distracting than helpful. It's better to base code on behavior than on names of implementations, and though sometimes the latter info needs to leak through this does not appear to be one of those places. > +/* Needed before <sys/stat.h>. > + May also define off_t to a 64-bit type on native Windows. */ > #include <sys/types.h> Likewise I'd omit this kind of distracting comment. The comment is incomplete: it's not just native Windows where <sys/types.h> has that effect. And completing it is more trouble than it's worth. Details like this can be put into the documentation for POSIX headers.
