Re: [PATCH 1/4] ptsname_r: new module

2011-11-09 Thread Jim Meyering
Bruno Haible wrote: > Hi Jim, all, > >> >> I suggest using @tie{} between os (or program or ...) names and >> >> versions. That way the line breaks come out ok in both the source and >> >> the output. >> > >> > Indeed, the result looks better (at least in HTML). I tested >> ... >> I find that the

Re: [PATCH 1/4] ptsname_r: new module

2011-11-09 Thread Gary V. Vaughan
Hi Bruno, As I said, an *extremely* minor pedantic nit, so please take with a large grain of salt (or three). I'm raising two technical points here: 1. There is a space between Mac and OS (and another space between OS and X). 2. The X in "Mac OS X" already says 10, so it's redundant when you

Re: [PATCH 2/2] gitlog-to-changelog: support 'tiny change' commits.

2011-11-09 Thread Gary V. Vaughan
Hi Karl, On 10 Nov 2011, at 06:45, Karl Berry wrote: > Sorry, I didn't know I was in the loop here. Didn't see my name at the > bottom of a 200-line msg with lots of quotes. No worries, that's what I figured :) > Having now read it, I am not sure what the question is. Maybe it's > this: Change

Re: gl_FUNC_FSTATAT doesn’t support cross-compilation

2011-11-09 Thread Paul Eggert
On 11/09/11 17:55, Bruno Haible wrote: > Paul Eggert wrote: >> > One possibility is to assume that AIX 7.1 is the only >> > target platform with that bug -- that would be easier >> > to maintain > Yes, this appears to be the case. OK, let's go with that then. Or perhaps, a bit more conservatively

Re: gl_FUNC_FSTATAT doesn’t support cross-compilation

2011-11-09 Thread Bruno Haible
Paul Eggert wrote: > One possibility is to assume that AIX 7.1 is the only > target platform with that bug -- that would be easier > to maintain Yes, this appears to be the case. Grepping through log files of many platforms: $ fgrep 'checking whether fstatat (..., 0) works' multibuild-1*/*.log |

Re: [PATCH 2/4] ptsname_r-tests: new test module

2011-11-09 Thread Bruno Haible
Eric Blake wrote: > +static int > +test_errors (int fd, const char *slave) On Cygwin and mingw I'm seeing this warning: test-ptsname_r.c: In function `test_errors': test-ptsname_r.c:89: warning: control reaches end of non-void function On MacOS X 10.5 I'm seeing this failure: test-ptsname_r.c:7

Re: [PATCH 1/4] ptsname_r: new module

2011-11-09 Thread Paul Eggert
Just today, before I read this exchange, I was running 'info' in an ASCII environment (LC_ALL='C' on Fedora 15). And just before *that*, I was reading documentation under Emacs info mode (my normal way of reading documentation). As a developer, I rarely read Emacs manuals using HTML, or using PDF,

Re: openpty on mingw

2011-11-09 Thread Bruno Haible
Eric Blake wrote: > --- a/lib/pty.in.h > +++ b/lib/pty.in.h > @@ -45,6 +45,11 @@ > #if defined _AIX > # include > #endif > +/* Mingw lacks 'struct termios' and 'struct winsize', but a forward > + declaration of an opaque type is sufficient to allow compilation of > + a stub openpty(). *

Re: gl_FUNC_FSTATAT doesn’t support cross-compilation

2011-11-09 Thread Paul Eggert
On 11/09/11 16:42, Eric Blake wrote: > we also ought to guess yes on cygwin 1.7 and on Solaris 10 and newer, which > we also know work. ... which is why I was trying to avoid this issue. :-) I'm not a fan of hardwiring this stuff in, as I figure that people doing embedded cross-compilation shoul

Re: gl_FUNC_FSTATAT doesn’t support cross-compilation

2011-11-09 Thread Eric Blake
On 11/09/2011 05:39 PM, Bruno Haible wrote: Also, a minor nit: When I see configure output like checking whether fstatat (..., 0) works... cross-compiling I wonder: does that count as a "yes" or as a "no"? Here's a proposed followup patch: @@ -36,16 +37,23 @@ ]])],

Re: gl_FUNC_FSTATAT doesn’t support cross-compilation

2011-11-09 Thread Bruno Haible
Hi Paul, > I'd rather not hardwire assumptions about AIX into > the 'configure' code, so instead I installed the > following more-conservative patch The problem with this conservative approach is that it penalizes all the people who do cross-compiles to embedded Linux (eglibc or uClibc) platforms

Re: info readers

2011-11-09 Thread Bruno Haible
Hi Karl, > Well, can you please give me a hint how to use it? > > C-u M-x info RET > /full/path/to/gnulib.info RET Thanks. That works. And the magenta underline is apparently there on purpose. It's customizable through the "face" 'nobreak-space'. > interoperability with other programs

Re: gl_FUNC_FSTATAT doesn’t support cross-compilation

2011-11-09 Thread Paul Eggert
On 11/09/11 13:36, Ludovic Courtès wrote: > What about a patch along these lines? I'd rather not hardwire assumptions about AIX into the 'configure' code, so instead I installed the following more-conservative patch, which I hope fixes your problem. fstatat: work with cross-compilation Problem r

Re: [PATCH 2/4] ptsname_r-tests: new test module

2011-11-09 Thread Bruno Haible
Eric Blake wrote: > I wonder if we should refactor the code to share common features > between test-ptsname{,_r}.c into test-ptsname.h. Is it possible to do this refactoring in a way that the line number printed by the ASSERT macro is informative enough? I mean, on some platforms I don't have a d

Re: info readers

2011-11-09 Thread Karl Berry
Well, can you please give me a hint how to use it? C-u M-x info RET /full/path/to/gnulib.info RET gnulib.info buffer from fundamental-mode to info-mode. It might work to say M-x Info-mode RET after visiting gnulib.info, but I don't know for sure. I've been working on changing that

Re: info readers

2011-11-09 Thread Bruno Haible
Karl Berry wrote: > - .info output when viewed by the 'info' program in a UTF-8 locale. > > Just for the record, Emacs Info is a much more important/widespread > reader than standalone Info. Well, can you please give me a hint how to use it? I tried to view the generated doc/gnulib.info fil

[PATCH 5/4] ptsname_r: use instead of ptsname

2011-11-09 Thread Eric Blake
We might as well be ready for thread-safety, if ptsname_r is improved to add appropriate locking. * lib/openpty.c (openpty): Convert for thread-safety. * lib/unlockpt.c (unlockpt): Likewise. * modules/openpty (Depends-on): Add ptsname_r. * modules/unlockpt (Depends-on): Likewise. * lib/pt_chown.c

Re: [PATCH 2/2] gitlog-to-changelog: support 'tiny change' commits.

2011-11-09 Thread Karl Berry
Ping Karl... Sorry, I didn't know I was in the loop here. Didn't see my name at the bottom of a 200-line msg with lots of quotes. Having now read it, I am not sure what the question is. Maybe it's this: ChangeLog's of FSF-copyrighted packages must keep the "(tiny change)" convention as far

[RFC PATCH 2.5/4] ptsname_r: work with POSIX isatty, for Solaris

2011-11-09 Thread Eric Blake
POSIX does not require isatty to set a sane errno; and Solaris 10 leaves errno unchanged. Fix this with a helper function, so that the body of __ptsname_r from glibc still syncs up. * lib/ptsname_r.c (isatty_errno): New helper function. * modules/ptsname_r (Depends-on): Add fcntl-h. Signed-off-b

improve MODULES.html output

2011-11-09 Thread Bruno Haible
This fixes a couple of red-colored warnings in http://www.gnu.org/software/gnulib/MODULES.html 2011-11-09 Bruno Haible Improve MODULES.html output. * modules/mkfifoat (Description): Use the word "function". * modules/readlinkat (Description): Likewise. * module

Re: [PATCH 1/4] ptsname_r: new module

2011-11-09 Thread Karl Berry
- .info output when viewed by the 'info' program in a UTF-8 locale. Just for the record, Emacs Info is a much more important/widespread reader than standalone Info. Personally, I find using any non-7-bit ASCII character when not absolutely necessary is simply a pain agent. But I don't expe

Re: [PATCH 2/4] ptsname_r-tests: new test module

2011-11-09 Thread Eric Blake
On 11/08/2011 04:14 AM, Bruno Haible wrote: Eric Blake wrote: +static int +test_errors (int fd, char *slave) The parameter should be a 'const char *slave'. Thanks for the feedback. I think I incorporated it all, with this being what I pushed. Now we get to work on addressing the platform

Re: [PATCH 1/4] ptsname_r: new module

2011-11-09 Thread Bruno Haible
Hi Jim, all, > >> I suggest using @tie{} between os (or program or ...) names and > >> versions. That way the line breaks come out ok in both the source and > >> the output. > > > > Indeed, the result looks better (at least in HTML). I tested > ... > I find that the mark-up renders the texi less

Re: [PATCH 1/4] ptsname_r: new module

2011-11-09 Thread Karl Berry
As for things like AIX@notie{}5.1 I don't understand the "no". just to prevent paragraph fill from breaking things It's not primarily about paragraph fill; that's a side benefit. The primary purpose is to get good line breaks in the output (and the source), without having to think

Re: [PATCH 1/4] ptsname_r: new module

2011-11-09 Thread Eric Blake
On 11/08/2011 04:01 AM, Bruno Haible wrote: Hi Eric, This patch looks fine. +@item +This function is missing on some platforms: +MacOS X 10.5, FreeBSD 6.0, NetBSD 5.0, OpenBSD 3.8, Minix 3.1.8, AIX +5.1, HP-UX 11, IRIX 6.5, Solaris 11 2010-11, Cygwin 1.7.9, mingw, MSVC 9, BeOS. @end itemize

Re: [PATCH 1/4] ptsname_r: new module

2011-11-09 Thread Bruno Haible
Gary V. Vaughan wrote: > Although it is common to see, e.g. Mac OS X 10.5 in writing, it's > redundant and technically incorrect. Possibly. But when discussing gnulib, I want to never evoke the impression that gnulib could support MacOS 9 or earlier. > or use the cat name > >Mac OS X Leopard

gl_FUNC_FSTATAT doesn’t support cross-compilation

2011-11-09 Thread Ludovic Courtès
Hi, (Adding bug-gnulib + Paul.) ludo-mXXj517/z...@public.gmane.org (Ludovic Courtès) skribis: > Rob Vermaas skribis: > >>> On x86_64-linux, the new build doesn't look healthy: >>> (http://hydra.nixos.org/build/1302194) >>> >>> checking whether fstatat fills in st_size etc configure: error:

[PATCH] announce-gen: be more concise when there's only one URL+tarball

2011-11-09 Thread Jim Meyering
The generated announcement for coreutils-8.14 was adjusted manually to make it more concise, now that there is only one (.xz) tarball. This change to announce-gen makes it generated what I did manually, and in addition (when you set in cfg.mk, url_dir_list = http://ftp.gnu.org/gnu/$(PACKAGE)) it li

Re: problem with latest texinfo.tex

2011-11-09 Thread Jim Meyering
Paul Eggert wrote: > On 11/09/11 11:47, Jim Meyering wrote: >> I'm sure Karl will >> do something about this pretty quickly: >> >> http://thread.gmane.org/gmane.comp.tex.texinfo.bugs/544 > > That URL is missing a digit; it should be: > > http://article.gmane.org/gmane.comp.tex.texinfo.bugs/544

Re: problem with latest texinfo.tex

2011-11-09 Thread Paul Eggert
On 11/09/11 11:47, Jim Meyering wrote: > I'm sure Karl will > do something about this pretty quickly: > > http://thread.gmane.org/gmane.comp.tex.texinfo.bugs/544 That URL is missing a digit; it should be: http://article.gmane.org/gmane.comp.tex.texinfo.bugs/5444

problem with latest texinfo.tex

2011-11-09 Thread Jim Meyering
FYI, texi2dvi was failing with no diagnostic for me, when using the latest texinfo.tex. I'm sure Karl will do something about this pretty quickly: http://thread.gmane.org/gmane.comp.tex.texinfo.bugs/544

Re: [libvirt] [PATCHv2] build: fix build on platforms without ptsname_r

2011-11-09 Thread Eric Blake
[moving to bug-gnulib; this started on libvir-list] On 11/08/2011 02:29 AM, Daniel P. Berrange wrote: Unfortunately it does not build on Mingw: make[4]: Entering directory `/home/berrange/src/virt/libvirt/gnulib/lib' CC glthread/lock.lo CC openpty.lo openpty.c:51:46: warning: 'str

[PATCH] raise: fix mingw handling of SIGPIPE

2011-11-09 Thread Eric Blake
When compiling for mingw, I see: CC sigprocmask.lo sigprocmask.c: In function '_gl_raise_SIGPIPE': sigprocmask.c:349:1: warning: control reaches end of non-void function which means that raise(SIGPIPE) would be using an uninitialized value as its return. * lib/sigprocmask.c (_gl_raise_SIGP

Re: split off module fstatat from module openat

2011-11-09 Thread Bruno Haible
Jim Meyering wrote: > Did you find that by using some new tool to check > for unnecessary dependencies, or "just" by inspection? Just by inspection. The first approximation was done by 'grep'ing for the function calls, e.g. grep "fstat (". The second inspection was line by line. This particular