Syntax check prohibit_doubled_word: false positives on non-English text

I had an interesting failure from the prohibit_doubled_word syntax check: prohibit_doubled_word_RE_ ?= \ /\b(then?|[iao]n|i[fst]|but|f?or|at|and|[dt]o)\s+\1\b/gims prohibit_doubled_word_ =\ -e 'while ($(prohibit_doubled_word_RE_))'

Re: [PATCH] maint.mk: sc_unmarked_diagnostics: don't hard-code "error"

Jim Meyering wrote: > In diffutils I wanted to check for unmarked diagnostics > emitted by functions other than "error" (the name hard-coded > into the sc_unmarked_diagnostics rule). I've generalized that > rule so now diffutils can do this: > > _gl_translatable_diag_func_re = (error|(perror_)?f

[PATCH] maint.mk: sc_unmarked_diagnostics: don't hard-code "error"

In diffutils I wanted to check for unmarked diagnostics emitted by functions other than "error" (the name hard-coded into the sc_unmarked_diagnostics rule). I've generalized that rule so now diffutils can do this: _gl_translatable_diag_func_re = (error|(perror_)?fatal|pfatal_with_name) With th

Re: [PATCH] getopt: for ambiguous options, enumerate the possibilities.

> > One nit that emacs highlights (while reading this via Gnus) > > is that there is a line with trailing spaces above. > > > > Other than that, it looks fine. > > Pushed with that fixed. Another nit is that "gcc -Wall" gives a warning (seen on OpenBSD 4.9): getopt.c: In function '_getopt_int

Re: two small patches to accommodate -Wstrict-overflow

Jim Meyering wrote: > I've reported this one with a minimal test case: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49234 And I've reported the other one: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49283 Bruno -- In memoriam Mordechai Gebirtig

Re: two small patches to accommodate -Wstrict-overflow

Bruno Haible wrote: > Jim Meyering wrote: >> I've reported this one with a minimal test case: >> >> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49234 > > And I've reported the other one: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49283 Thanks!

Re: [PATCH] strerror: enforce POSIX ruling on strerror(0)

Eric Blake wrote on 2011-05-19: > http://austingroupbugs.net/view.php?id=382 requires that strerror(0) > succeed, but FreeBSD reports "Unknown error: 0" and fails with EINVAL. > > * m4/strerror.m4 (gl_FUNC_STRERROR_SEPARATE): Expose BSD bug. > * m4/strerror_r.m4 (gl_FUNC_STRERROR_R): Likewise. > *

Re: [PATCHv2] strerror: drop strerror_r dependency

Eric Blake wrote: > * lib/strerror-impl.h: Delete. The comments still refer to this file. Fixing it like this: 2011-06-04 Bruno Haible strerror_r: Fix comments. * lib/strerror_r.c (strerror_r): Update comments after 2011-06-01 commit. --- lib/strerror_r.c.orig

Re: [PATCH 1/2] perror: call strerror_r directly

Hi Eric, > > No need to make a wrapper that burns static storage when we can > > just use stack storage. > > > > * modules/perror (Files): Drop strerror-impl.h. > > * lib/perror.c (perror): Use our own stack buffer, rather than > > calling a wrapper that uses static storage. > > * doc/posix-funct

setlocale on Cygwin 1.5

On Cygwin 1.5.25, I'm seeing this test failure: setlocale did not fail for implicit ar_SA.ISO-8859-1 FAIL: test-setlocale2.sh This fixes it. 2011-06-04 Bruno Haible setlocale: Enable replacement on Cygwin 1.5. * m4/setlocale.m4 (gl_FUNC_SETLOCALE): Set REPLACE_SETLOCALE

Re: [PATCHv2] strerror: drop strerror_r dependency

> 2011-06-03 Bruno Haible > > strerror-override: Don't disable symbol renamings. > * lib/strerror-override.c: Include config.h. > (strerror_override): Don't undefine. This patch alone leads to a compilation error, because at the point of the definition of the function in stre

[PATCH] maint.mk: add three prohibit-header-without-use rules

This was prompted by Pádraig's coreutils patch: http://thread.gmane.org/gmane.comp.gnu.coreutils.general/1282 >From 1b20f727196f5f3361c2edf5ca28ac0032425706 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 3 Jun 2011 17:35:07 +0200 Subject: [PATCH] maint.mk: add three prohibit-header-with