> > One nit that emacs highlights (while reading this via Gnus) > > is that there is a line with trailing spaces above. > > > > Other than that, it looks fine. > > Pushed with that fixed.
Another nit is that "gcc -Wall" gives a warning (seen on OpenBSD 4.9): getopt.c: In function '_getopt_internal_r': getopt.c:491: warning: unused variable 'ambig' I'm fixing it like this: 2011-06-04 Bruno Haible <br...@clisp.org> getopt: Avoid gcc warning. * lib/getopt.c (_getopt_internal_r): Remove unused variable 'ambig'. --- lib/getopt.c.orig Sat Jun 4 15:31:22 2011 +++ lib/getopt.c Sat Jun 4 15:31:19 2011 @@ -488,7 +488,6 @@ struct option_list *next; } *ambig_list = NULL; int exact = 0; - int ambig = 0; int indfound = -1; int option_index; -- In memoriam Mordechai Gebirtig <http://en.wikipedia.org/wiki/Mordechai_Gebirtig>