regex-quote.c syntax support

2011-03-03 Thread Reuben Thomas
regex-quote seems only to support two syntaxes at the moment, and it does it in a rather odd way: by a single boolean flag. I wonder if there's scope to change this. The obvious representation of syntaxes from a GNU point of view would be a bitmask of type reg_syntax_t as passed to re_set_syntax.

Re: Remove xalloc.h dependency from parse-duration

2011-03-03 Thread Bruce Korb
On 03/03/11 14:35, Eric Blake wrote: >> - if (pT != NUL) >> + if (pz == NULL) >> +return BAD_TIME; > > Here, you want errno to be ENOMEM, but mingw doesn't guarantee that... Ick. > ACK with that fixed. ACK: Subject: [PATCH] parse-duration: remove xalloc.h dependency * lib/parse-duration

Re: Remove xalloc.h dependency from parse-duration

2011-03-03 Thread Eric Blake
On 03/03/2011 03:16 PM, Bruce Korb wrote: > xalloc.h drags in too much stuff: > > parse_period (cch_t * in_pz) > { > - char * pz = xstrdup (in_pz); > - char * pT = strchr (pz, 'T'); > + char * pz = strdup (in_pz); > + char * pT; >char * ps; >void * fptr = pz; >time_t res =

Remove xalloc.h dependency from parse-duration

2011-03-03 Thread Bruce Korb
xalloc.h drags in too much stuff: diff --git a/lib/parse-duration.c b/lib/parse-duration.c index 8c28133..7c8bdec 100644 --- a/lib/parse-duration.c +++ b/lib/parse-duration.c @@ -26,7 +26,6 @@ #include #include #include -#include "xalloc.h" #ifndef NUL #define NUL '\0' @@ -406,13 +405,17

Re: [PATCH 2/3] sendfd, recvf pass file descriptors along Unix domain sockets

2011-03-03 Thread Eric Blake
On 03/01/2011 07:04 AM, Bastien ROUCARIES wrote: > Recvfd and sendfd can be used to pass an open file descriptor over a Unix > domain socket from one process to another. Have you considered porting this to Windows yet? I like the idea of this module (especially since I want to use it in libvirt)

Re: [PATCH] bootstrap: honour m4_base when running ac_local

2011-03-03 Thread Jim Meyering
Matthew Booth wrote: > * build-aux/bootstrap: fix hardcoded use of m4 directory > --- > build-aux/bootstrap |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Thanks, Matt. Pushed like this: >From 329c5b59c9ebfed10f51859a5d16fbe080835a24 Mon Sep 17 00:00:00 2001 From: Matthew Booth

Re: [PATCH] bootstrap: honour m4_base when running ac_local

2011-03-03 Thread Jim Meyering
Matthew Booth wrote: > * build-aux/bootstrap: fix hardcoded use of m4 directory > --- > build-aux/bootstrap |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/build-aux/bootstrap b/build-aux/bootstrap > index 55147d7..c74bdcd 100755 > --- a/build-aux/bootstrap > +++

[PATCH] bootstrap: honour m4_base when running ac_local

2011-03-03 Thread Matthew Booth
* build-aux/bootstrap: fix hardcoded use of m4 directory --- build-aux/bootstrap |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/build-aux/bootstrap b/build-aux/bootstrap index 55147d7..c74bdcd 100755 --- a/build-aux/bootstrap +++ b/build-aux/bootstrap @@ -875,7 +875,7

[PATCH] bootstrap: fix paths written by gnulib-tool

2011-03-03 Thread Matthew Booth
When bootstrap invokes gnulib-tool, it sets aux-dir, doc-base, m4-base, source-base and tests-base to equivalent directories under a temporary directory, ._bootmp. It later moves these files back under the top level hierarchy. However, gnulib-tool also uses these paths to calculate relative paths w

Re: bug#8154: du: issue with `--files0-from=DIR'

2011-03-03 Thread Jim Meyering
Jim Meyering wrote: > Jim Meyering wrote: >> Paul Eggert wrote: >>> On 03/02/2011 07:09 AM, Jim Meyering wrote: - struct argv_iterator *ai = malloc (sizeof *ai); + struct argv_iterator *ai; + struct stat st; + + if (fstat (fileno (fp),&st) == 0&& S_ISDIR (st.st_mode))