On 03/03/2011 03:16 PM, Bruce Korb wrote:
> xalloc.h drags in too much stuff:
>
> parse_period (cch_t * in_pz)
> {
> - char * pz = xstrdup (in_pz);
> - char * pT = strchr (pz, 'T');
> + char * pz = strdup (in_pz);
> + char * pT;
> char * ps;
> void * fptr = pz;
> time_t res = 0;
>
> - if (pT != NUL)
> + if (pz == NULL)
> + return BAD_TIME;Here, you want errno to be ENOMEM, but mingw doesn't guarantee that... > Depends-on: > -xalloc ...so either add a dependency on strdup-posix here, or else modify the code to manually set errno on that failure path. ACK with that fixed. -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
