Re: Question about critical_factorization() in the Two-Way algorithm

2010-12-15 Thread Eric Blake
On 12/15/2010 04:48 PM, Eric Blake wrote: > On 12/15/2010 03:23 PM, Pádraig Brady wrote: I spoke too soon. We would also need to patch m4/memmem.m4 to actually perform the empty needle verification in the memmem-simple case. >>> >>> I also noticed the empty needle verification didn't >>>

Re: Question about critical_factorization() in the Two-Way algorithm

2010-12-15 Thread Eric Blake
On 12/15/2010 03:23 PM, Pádraig Brady wrote: >>> I spoke too soon. We would also need to patch m4/memmem.m4 to actually >>> perform the empty needle verification in the memmem-simple case. >> >> I also noticed the empty needle verification didn't >> check that the correct pointer was returned, >>

Re: Question about critical_factorization() in the Two-Way algorithm

2010-12-15 Thread Pádraig Brady
On 23/06/10 01:39, Pádraig Brady wrote: > On 22/06/10 15:42, Eric Blake wrote: >> On 06/22/2010 08:41 AM, Eric Blake wrote: >>> On 06/22/2010 08:34 AM, Pádraig Brady wrote: Cool, that's what I expected from the names. So do we just need to move a docs around a little like: >>> >>> Ye

Re: __GLIBC__ and uClibc

2010-12-15 Thread Bruno Haible
Hi Pádraig, > > * lib/freading.h: Treat uClibc like a non-glibc platform. > > ... > > * m4/memmem.m4 (gl_FUNC_MEMMEM_SIMPLE, gl_FUNC_MEMMEM): Likewise. > > * m4/printf.m4 (gl_PRINTF_DIRECTIVE_A): Likewise. > > * m4/strcasestr.m4 (gl_FUNC_STRCASESTR_SIMPLE, gl_FUNC_STRCASESTR):

Re: __GLIBC__ and uClibc

2010-12-15 Thread Eric Blake
On 12/15/2010 10:30 AM, Pádraig Brady wrote: > On 21/11/10 01:31, Bruno Haible wrote: > > I noticed a slight issue with this on code inspection. > When cross-compiling for uClibc, memmem, printf, strcasestr and strstr > would be replaced, which was a change from the original. > OK to apply the att

Re: __GLIBC__ and uClibc

2010-12-15 Thread Pádraig Brady
On 21/11/10 01:31, Bruno Haible wrote: >> 2010-11-20 Bruno Haible >> >> Port to uClibc. >> ... > > Oops, that patch and its ChangeLog entry were incomplete. > > Here is the corrected ChangeLog: > > 2010-11-20 Bruno Haible > > Port to uClibc. > * build-aux/link-warning.h (