On 12/15/2010 04:48 PM, Eric Blake wrote: > On 12/15/2010 03:23 PM, Pádraig Brady wrote: >>>> I spoke too soon. We would also need to patch m4/memmem.m4 to actually >>>> perform the empty needle verification in the memmem-simple case. >>> >>> I also noticed the empty needle verification didn't >>> check that the correct pointer was returned, >>> and only checked for !NULL. So I rolled that >>> fix into the attached reorg. >> >> I've rebased the attached memmem reorg patch >> which splits correctness checks from performance checks. > >> Subject: [PATCH] memmem: rearrange memmem and expand memmem-simple modules >> >> Move all functional checks to memmem-simple so that one has >> a fully functional memmem by using just this module. >> Restrict the memmem module to performance checks only. >> Document exactly how the memmem and memmem-simple modules >> relate to each other. > > Thanks for reviving this.
Oh, I meant to add: yes, this looks fine. -- Eric Blake ebl...@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
