Re: [PATCH v2 0/5] Speed up uNN_chr and uNN_strchr with Boyer-Moore algorithm

2010-07-23 Thread Pádraig Brady
On 23/07/10 07:53, bonz...@gnu.org wrote: > From: Paolo Bonzini > > v2 of the patch, now including strchr operations too and with the > changes suggested by Bruno. Padraig, can you test it on your > cases too? Cool. There was no measurable change for the 2 byte case, but there was another 6% im

mbspcasecmp comment bug

2010-07-23 Thread Eric Blake
I just noticed that the comments for mbspcasecmp are wrong: /* Compare the initial segment of the character string STRING consisting of at most mbslen (PREFIX) characters with the character string PREFIX, ignoring case, returning less than, equal to or greater than zero if this initial

Re: [PATCH v2 0/5] Speed up uNN_chr and uNN_strchr with Boyer-Moore algorithm

2010-07-23 Thread Paolo Bonzini
On 07/23/2010 09:21 AM, Bruno Haible wrote: Otherwise fine, please commit. I can add comments that prove the validity of the code later, after you committed it. v2 already had large comments that detail the algorithm used and do include all the info in the comments you suggested. Feel free to

Re: [PATCH v2 0/5] Speed up uNN_chr and uNN_strchr with Boyer-Moore algorithm

2010-07-23 Thread Bruno Haible
Hi Paolo, Thanks for the update. In [PATCH v2 3/5] unistr/u*-chr: test multibyte sequences more: > +n = U_UCTOMB(c, uc, 6); Still lacking a space before the opening parenthesis. In [PATCH v2 4/5] unistr/u*-strchr: add tests: > +n = U_UCTOMB(c, uc, 6); Likewise. > +/* Test of u