Hi Paolo, Thanks for the update.
In [PATCH v2 3/5] unistr/u*-chr: test multibyte sequences more: > + n = U_UCTOMB(c, uc, 6); Still lacking a space before the opening parenthesis. In [PATCH v2 4/5] unistr/u*-strchr: add tests: > + n = U_UCTOMB(c, uc, 6); Likewise. > +/* Test of uN_chr() functions. > +/* Test of u16_chr() function. > +/* Test of u32_chr() function. > +/* Test of u8_chr() function. The first line of each of these 4 files needs to be updated. s/chr/strchr/ In [PATCH v2 5/5] unistr/u8-chr, unistr/u8-strchr: use Boyer-Moore like algorithm: > + algorithm that searches for the last character using multi-byte > + Instead of the table, we compare the candidate last character s/character/byte/ In this context, a 'char' is a byte, and an 'ucs4_t' is a character. Otherwise fine, please commit. I can add comments that prove the validity of the code later, after you committed it. Bruno
