On Sun, Jul 11, 2010 at 5:06 AM, Bruno Haible wrote:
> Hi Paul,
>
> There is one API bug and two oddities in your patch:
> 2) You added documentation to memcoll0 that does not make references to other
> functions. Good. Can we have the same for xmemcoll0 as well?
>
> 3) There are two 'const char
On 11/07/10 15:20, Paolo Bonzini wrote:
> On 07/07/2010 03:44 PM, Pádraig Brady wrote:
>> Subject: [PATCH] unistr/u8-strchr: speed up searching for ASCII
>> characters
>>
>> * lib/unistr/u8-strchr.c (u8_strchr): Use strchr() for
>> the single byte case as it was measured to be 50% faster
>> than th
On 07/07/2010 03:44 PM, Pádraig Brady wrote:
Subject: [PATCH] unistr/u8-strchr: speed up searching for ASCII characters
* lib/unistr/u8-strchr.c (u8_strchr): Use strchr() for
the single byte case as it was measured to be 50% faster
than the existing code on x86 linux. Also add a comment
on why
Hi Pádraig,
> +2010-07-07 Pádraig Brady
> +
> + * lib/unistr/u8-strchr.c (u8_strchr): Use strchr() as it's faster
Thanks for the patch. I've applied it as below, with minor changes:
- Keep around the unoptimized code, for clarity.
- Add the rationale for the change to the comments, n
Hi Paul,
There is one API bug and two oddities in your patch:
1) You removed the 'abort' calls in memcoll0 that were intended to verify
that the caller passes meaningful arguments. The documentation that you
added:
/* Compare S1 (with length S1LEN) and S2 (with length S2LEN) according
Hi Gary,
> I get a compilation failure in coreutils with the priv-set module
> which correctly detects a getppriv() function, but then tries to use
> it by including a non-existant header.
>
> From priv-set.h:
>
> #if HAVE_GETPPRIV
>
> # include
This was already fixed by Paul Eggert on 2
"Bruno Haible" writes:
> Hi Simon,
>
>> In this case, GnuTLS uses the read-file module from gnulib, and it ends
>> up being exported in a static GnuTLS library. GNU Wget also has a
>> function called read_file, and things break when linking.
>> ...
>> I have some vague memory that this has been
