HOST_NAME_MAX

2009-03-31 Thread Simon Josefsson
POSIX requires this symbol, but MinGW doesn't appear to define it: ../../../../src/gss-0.1.1/lib/krb5/name.c:89: error: 'HOST_NAME_MAX' undeclared (first use in this function) According to MSDN gethostname documentation: http://msdn.microsoft.com/en-us/library/ms738527.aspx "So if a buffer of

Re: ld-output-def

2009-03-31 Thread Simon Josefsson
Here is an updated patch. Thoughts? /Simon >From cb86aabc84146a5205d5ea88b3f067d893810a1d Mon Sep 17 00:00:00 2001 From: Simon Josefsson Date: Wed, 1 Apr 2009 07:31:49 +0200 Subject: [PATCH] Add new module lib-msvc-compat. --- MODULES.html.sh |1 + doc/gnulib.texi |3 +

Re: ld-output-def

2009-03-31 Thread Simon Josefsson
Bruno Haible writes: > OK, now we know why your module is useful. Please please mention these > alternatives and why they suck in the documentation. Good idea -- I learned something from this, and it is useful to document why we use a particular solution. It may be that there are alternatives t

Re: ld-output-def

2009-03-31 Thread Simon Josefsson
Bruno Haible writes: > Hi Simon, > >> I kind of prefer the lib-* prefix because I think this is only ever >> relevant for libraries. That makes the name longer though. Do we need >> the -symbol- infix? > > Without the -symbol- infix, 'lib-versions' makes me think about the > library versions (a

Re: ld-output-def

2009-03-31 Thread Simon Josefsson
Ralf Wildenhues writes: > Hi Simon, > > a couple of nits: Many thanks! Updated script below, it will be part of an updated patch soon. /Simon # ld-msvc-compat.m4 serial 1 dnl Copyright (C) 2008, 2009 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation d

Re: ld-output-def

2009-03-31 Thread Simon Josefsson
Bruno Haible writes: > Hi Simon, Ralf, > > Your documented example looks like this: > >> +if HAVE_LD_OUTPUT_DEF >> +libfoo_la_LDFLAGS += -Wl,--output-def,libfoo-$(SOVERSION).def >> +defexecdir = $(bindir) >> +defexec_DATA = libfoo-$(SOVERSION).def >> +DISTCLEANFILES += $(defexec_DATA) >> +endif >

Re: string.h uses restrict

2009-03-31 Thread Simon Josefsson
Reuben Thomas writes: > On Fri, 20 Mar 2009, Simon Josefsson wrote: > >> Reuben Thomas writes: >> >>> On Fri, 20 Mar 2009, Eric Blake wrote: >>> Jim meant coreutil's maint.mk. It is not synced with gnulib's maint.mk, although several people have expressed interest in resyncing them. >

Re: string.h uses restrict

2009-03-31 Thread Reuben Thomas
On Fri, 20 Mar 2009, Simon Josefsson wrote: Reuben Thomas writes: On Fri, 20 Mar 2009, Eric Blake wrote: Jim meant coreutil's maint.mk. It is not synced with gnulib's maint.mk, although several people have expressed interest in resyncing them. Aha! This is surely the sort of rule that sh

Re: ld-output-def

2009-03-31 Thread Bruno Haible
Hi Simon, Ralf, Your documented example looks like this: > +if HAVE_LD_OUTPUT_DEF > +libfoo_la_LDFLAGS += -Wl,--output-def,libfoo-$(SOVERSION).def > +defexecdir = $(bindir) > +defexec_DATA = libfoo-$(SOVERSION).def > +DISTCLEANFILES += $(defexec_DATA) > +endif What is $(SOVERSION) ? As I underst

Re: ld-output-def

2009-03-31 Thread Bruno Haible
Hi Simon, > I kind of prefer the lib-* prefix because I think this is only ever > relevant for libraries. That makes the name longer though. Do we need > the -symbol- infix? Without the -symbol- infix, 'lib-versions' makes me think about the library versions (a.k.a. library soname) and libtool'

Re: ld-output-def

2009-03-31 Thread Ralf Wildenhues
Hi Simon, a couple of nits: * Simon Josefsson wrote on Tue, Mar 31, 2009 at 12:01:06PM CEST: > --- /dev/null > +++ b/m4/ld-output-def.m4 > +# gl_LD_OUTPUT_DEF() > +# - > +# Check if linker supports -Wl,--output-def and define automake > +# conditional HAVE_LD_OUTPUT_DEF if it is. > +

gethostname on Windows

2009-03-31 Thread Simon Josefsson
The current gethostname module will return an empty string on mingw: strcpy (name, "");/* Hardcode your system name if you want. */ This is sub-optimal since Windows has a gethostname function in -lws2_32. The following patch should make gethostname return proper values. Tested on

Re: Bug#489046: findutils: find -execdir + doesn't work anymore

2009-03-31 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Adam Borowski on 3/31/2009 1:40 AM: > http://savannah.gnu.org/bugs/?19593 > > Instead of tweaking the docs -- or perhaps in addition to -- let's think how > to fix the behaviour. What about doing a dup() on the directory, and > comparing

Re: move u64.h from sha512 to separate module?

2009-03-31 Thread Simon Josefsson
Simon Josefsson writes: > Jim Meyering writes: > >> I would have sworn I'd replied saying that was fine, >> but my outgoing-cc folder says otherwise. Sorry about that. >> >> Fine by me. > > Hi Jim! No problem. I have pushed it. It was lacking a self-test, so I added one. I hope this is unco

Re: move u64.h from sha512 to separate module?

2009-03-31 Thread Simon Josefsson
Jim Meyering writes: > I would have sworn I'd replied saying that was fine, > but my outgoing-cc folder says otherwise. Sorry about that. > > Fine by me. Hi Jim! No problem. I have pushed it. /Simon

Re: move u64.h from sha512 to separate module?

2009-03-31 Thread Jim Meyering
Simon Josefsson wrote: > Simon Josefsson writes: > >> Paul, Jim, >> >> The u64.h file, which is part of the sha512 module now, would be useful >> for me in gnutls where we currently have our own uint64_t replacement >> types and functions. How about making a separate module for it? > > Any object

Re: ld-output-def

2009-03-31 Thread Simon Josefsson
Bruno Haible writes: > Hi Simon, > >> How about this module? I use something similar in many of my projects. >> For an example of when a *.def file is useful, see "Using the GnuTLS DLL >> from your Visual Studio program" on . > > Again, I advocate for a module n

Re: ld-output-def

2009-03-31 Thread Bruno Haible
PS: > 1) Let the distributor of the DLL ship a .def file; this is what you > are advocating. > 2) Let the user create the .def file, using the Microsoft DUMPBIN > tool [1]. > 3) Let the user create the .def file, using the 'impdef' tool. [2] And 4) Let the user create the .def file

Re: ld-output-def

2009-03-31 Thread Bruno Haible
Hi Simon, > How about this module? I use something similar in many of my projects. > For an example of when a *.def file is useful, see "Using the GnuTLS DLL > from your Visual Studio program" on . Again, I advocate for a module name that makes people understand

Re: Failed test on Solaris 8 Sparc

2009-03-31 Thread Simon Josefsson
Dagobert Michelsen writes: > Hi, > > I am getting a test failure on Solaris 8 Sparc w/Sun Studio 11: Hi! Thanks for the report. The problem is actually in a self-test from gnulib. Your GNU SASL library build should still be fine, if this is the only problem. poll is only used by the 'gsasl' t

ld-output-def

2009-03-31 Thread Simon Josefsson
How about this module? I use something similar in many of my projects. For an example of when a *.def file is useful, see "Using the GnuTLS DLL from your Visual Studio program" on . /Simon >From 13d4ef1dbd6f3f172b403fb968a265fefe53edbf Mon Sep 17 00:00:00 2001