[PATCH] ignore-value: new module

2008-10-16 Thread Jim Meyering
I wanted to ignore some new warnings in coreutils, but a "(void)" cast no longer does the job with the latest gcc and libc headers. Here's the proposed module: >From 179c0e32f86c8b0013111d343f17d27730391e63 Mon Sep 17 00:00:00 2001 From: Jim Meyering <[EMAIL PROTECTED]> Date: Thu, 16 Oct 2008 23:

Re: gcc v4.3.2 problem with strtol.c

2008-10-16 Thread Monty Taylor
Monty Taylor wrote: > Hey all... Compiling with this: > > > gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. > -DDEFAULT_TEXT_DOMAIN=\"drizzle-gnulib\" -W -Wall -Wextra > -Wunused-macros -pedantic -Wundef -Wstrict-prototypes > -Wmissing-prototypes -Wmissing-declarations -Wredundant-decls > -Wno-strict-ali

gcc v4.3.2 problem with strtol.c

2008-10-16 Thread Monty Taylor
Hey all... Compiling with this: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -DDEFAULT_TEXT_DOMAIN=\"drizzle-gnulib\" -W -Wall -Wextra -Wunused-macros -pedantic -Wundef -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wredundant-decls -Wno-strict-aliasing -Werror -O3 -ggdb3 -DUNIV_LINU

memchr.c breaks with some warnings turned on

2008-10-16 Thread Monty Taylor
memchr.c doesn't compile if -Wunused-macros -Werror is turned on. Also, just looking at #if HAVE_BP_SYM_H also throws warnings which make -Werror builds die. === modified file 'gl/memchr.c' --- gl/memchr.c 2008-10-15 23:04:53 + +++ gl/memchr.c 2008-10-16 20:27:53 + @@ -39,10 +39,12 @@ #i

Re: Warnings to be fixed

2008-10-16 Thread Reuben Thomas
On Thu, 16 Oct 2008, Jim Meyering wrote: This one is perhaps a good reason to turn off or ignore that warning, Thanks to Paul Eggert for finding an acceptable solution. In general, I reiterate the principle I implied with my request that #include_next warnings be suppressed some time ago: gn

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-16 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > I just checked POSIX, and this is entirely true - the exec*() family is > allowed to inherit an ignored SIGCHLD, in deference to older systems like > SysV; and wait()/waitpid() are allowed to fail with ECHILD if SIGCHLD is > ignored. But most systems these

Re: Warnings to be fixed

2008-10-16 Thread Jim Meyering
Paul Eggert <[EMAIL PROTECTED]> wrote: > Jim Meyering <[EMAIL PROTECTED]> writes: > >> mode = (sizeof (mode_t) < sizeof (int) >>? va_arg (ap, int) >>: va_arg (ap, mode_t));<<< line 43 >> >> IMHO, adding casts here just to avoid that warning would be >>

Re: Warnings to be fixed

2008-10-16 Thread Paul Eggert
Jim Meyering <[EMAIL PROTECTED]> writes: > mode = (sizeof (mode_t) < sizeof (int) > ? va_arg (ap, int) > : va_arg (ap, mode_t));<<< line 43 > > IMHO, adding casts here just to avoid that warning would be > counterproductive. I agree. But would it tur

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-16 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: > According to Eric Blake on 10/10/2008 7:15 AM: >>> I've wanted to get rid of "signal" uses for ages. >>> Are you interested in doing it? >> >> Yes, I'll tackle this. > > Round 2 begins with a question. src/install.c has the following use of > signal, needed

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-16 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 10/10/2008 7:15 AM: >> I've wanted to get rid of "signal" uses for ages. >> Are you interested in doing it? > > Yes, I'll tackle this. Round 2 begins with a question. src/install.c has the following use of signal, needed o

Re: Warnings to be fixed

2008-10-16 Thread Jim Meyering
Reuben Thomas <[EMAIL PROTECTED]> wrote: > Compiling with the Debian gnulib snapshot of 20081001, I am delighted > that I no longer get warnings about #include_next. (Un?)fortunately, > this enables me more easily to spot "real" warnings: ... > open-safer.c: In function ‘open_safer’: > open-safer.c

Re: Warnings to be fixed

2008-10-16 Thread Jim Meyering
Reuben Thomas <[EMAIL PROTECTED]> wrote: ... > openat-die.c:31: warning: no previous prototype for ‘openat_save_fail’ > openat-die.c:44: warning: no previous prototype for ‘openat_restore_fail’ > open-safer.c: In function ‘open_safer’: > open-safer.c:43: warning: signed and unsigned type in conditi

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-16 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [adding bug-gnulib] According to Jim Meyering on 10/16/2008 1:30 AM: > Eric Blake <[EMAIL PROTECTED]> wrote: > ... >> Subject: [PATCH] csplit: prefer sigaction over signal >> >> * bootstrap.conf (gnulib_modules): Import sigaction. >> * src/csplit.c (s

Re: getaddrinfo, netdb, canon-host

2008-10-16 Thread Simon Josefsson
Paolo Bonzini <[EMAIL PROTECTED]> writes: >> /* Declarations for a platform that lacks . */ >> >> +#if @GNULIB_GETADDRINFO@ >> + >> +# ifndef HAVE_STRUCT_ADDRINFO >> + > > I think these definitions need to be moved after this line: > >> #endif /* HAVE_NETDB_H */ > > because they apply also to

Re: getaddrinfo, netdb, canon-host

2008-10-16 Thread Paolo Bonzini
> /* Declarations for a platform that lacks . */ > > +#if @GNULIB_GETADDRINFO@ > + > +# ifndef HAVE_STRUCT_ADDRINFO > + I think these definitions need to be moved after this line: > #endif /* HAVE_NETDB_H */ because they apply also to systems that *do* have netdb.h but lack getaddrinfo. Pa

Re: [PATCH]: update tls and lock tests, gl_cond_t WIN32 implementation

2008-10-16 Thread Bruno Haible
Hi Yoann, > The patch won't apply to the current GIT repository: > > patching file lib/glthread/cond.h > patching file lib/glthread/cond.c > Hunk #2 FAILED at 235. > Hunk #3 FAILED at 306. > Hunk #4 FAILED at 422. > Hunk #5 FAILED at 439. > 4 out of 6 hunks FAILED -- saving rejects to file > lib/

Warnings to be fixed

2008-10-16 Thread Reuben Thomas
Compiling with the Debian gnulib snapshot of 20081001, I am delighted that I no longer get warnings about #include_next. (Un?)fortunately, this enables me more easily to spot "real" warnings: gl_anylinked_list2.h: In function ‘gl_linked_node_value’: gl_anylinked_list2.h:124: warning: unused par

Re: getaddrinfo, netdb, canon-host

2008-10-16 Thread Simon Josefsson
Here is an updated patch that applies to the current master, after the recent netdb.h change. /Simon >From 83648f137b0f3ba980615d89eb8a45f0a10eb072 Mon Sep 17 00:00:00 2001 From: Simon Josefsson <[EMAIL PROTECTED]> Date: Thu, 16 Oct 2008 09:42:36 +0200 Subject: [PATCH] Make getaddrinfo and canon-

Re: netdb.h

2008-10-16 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Hi Simon, > > Good to see more include files covered! Hi! There are some left to do... ;) >> +#if @HAVE_NETDB_H@ >> + >> +/* Declarations for a platform that has . */ >> + >> +#else >> + >> +/* Declarations for a platform that has . */ > > The second

Re: winsock: needs access to SOCKET in application code

2008-10-16 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > Hi Simon, > >> > The return type should be SOCKET, which is either `unsigned int' or >> > 'unsigned long' (don't know about win64). >> >> How would that work on non-Mingw systems? The idea should be that gsasl >> calls the function unconditionally, in o

Re: [PATCH]: update tls and lock tests, gl_cond_t WIN32 implementation

2008-10-16 Thread Yoann Vandoorselaere
Hi Bruno, Le jeudi 16 octobre 2008 à 02:43 +0200, Bruno Haible a écrit : [...] > Find here an adaption of the "one event per thread" idea, and the use of > linked lists rather than array to keep the removal an O(1) operation. > It passes the tests, and should be scalable. OK to apply? > > I thin