Re: [bug-gnulib] New GNULIB glob module?

2005-05-23 Thread Paul Eggert
Derek Price <[EMAIL PROTECTED]> writes: > all the HAVE_.*64 stuff in glob.c shouldn't be necessary when !_LIBC. Yes, that's correct; it should just invoke stat, opendir, etc., without worrying about their 64-bit variants. I thought it already did that? If not, where does it not do it? > Also, t

[bug-gnulib] Re: getdate module description error?

2005-05-23 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Sergey Poznyakoff wrote: >Derek Price <[EMAIL PROTECTED]> wrote: > >>At least as of Automake 1.9.5, and I thought for some time earlier, >>automake will figure out of the above automatically since getdate.y is >>AC_LIBSOURCE'd. This recent change appe

[bug-gnulib] Re: getdate module description error?

2005-05-23 Thread Sergey Poznyakoff
Derek Price <[EMAIL PROTECTED]> wrote: > At least as of Automake 1.9.5, and I thought for some time earlier, > automake will figure out of the above automatically since getdate.y is > AC_LIBSOURCE'd. This recent change appears to be going in the wrong > direction: Yes, you are right. Automake 1.

Re: [bug-gnulib] getdate module description error?

2005-05-23 Thread Paul Eggert
Derek Price <[EMAIL PROTECTED]> writes: > At least as of Automake 1.9.5, and I thought for some time earlier, > automake will figure out of the above automatically since getdate.y is > AC_LIBSOURCE'd. This recent change appears to be going in the wrong > direction: > > 2005-05-12 Sergey Poznyako

[bug-gnulib] Re: same, utimecmp should depend on minmax

2005-05-23 Thread Bruno Haible
Paul Eggert wrote: > Won't this run into a problem when (for > example) private headers include system headers? E.g., > >// module being implemented >#include "my-interface.h" > >// system headers >#include > >// gnulib and private headers >#include "minmax.h" >#includ

[bug-gnulib] Re: same, utimecmp should depend on minmax

2005-05-23 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: > The following heuristics works very well in practice: > - First comes the #include "..." specifying the module being implemented. > - Then come all the #include <...> of system or system-replacement headers, > in arbitrary order. > - Then come a

[bug-gnulib] getdate module description error?

2005-05-23 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, Is this an error in the getdate module description: Makefile.am: BUILT_SOURCES += getdate.c MAINTAINERCLEANFILES += getdate.c EXTRA_DIST += getdate.c At least as of Automake 1.9.5, and I thought for some time earlier, automake will figure ou

[bug-gnulib] Re: stdint_.h update

2005-05-23 Thread Sam Steingold
> * Bruno Haible <[EMAIL PROTECTED]> [2005-05-23 16:50:25 +0200]: > > I try to support at least older versions up to ca. 3 years old, so that I > don't get too many failure reports from people who installed their system > 2 or 3 years ago. "3 years" is related to the average lifetime of a PC. this

[bug-gnulib] Re: stdint_.h update

2005-05-23 Thread Bruno Haible
Eric Blake wrote: > > NEED_SIGNED_INT_TYPES is only needed for Cygwin (so far). Let's correct > > this when we stumble acess a system that has the same problem and uses > > the MSVC compiler. > > Which cygwin bug is this? Let's get it fixed in cygwin, rather than > having to work around it. The N

[bug-gnulib] Re: gcc -Wall warning for minmax.h

2005-05-23 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Bruno Haible wrote: >I therefore commit this patch. Thanks, Bruno. Thank, Paul. Derek -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.0 (Cygwin) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCkeZjLD1OTBfyMaQRAgmpAKDl

Re: [bug-gnulib] stdint_.h update

2005-05-23 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Bruno Haible on 5/23/2005 3:17 AM: >>Shouldn't that typedef of int64_t be protected by "#ifdef >>NEED_SIGNED_INT_TYPES"? > > NEED_SIGNED_INT_TYPES is only needed for Cygwin (so far). Let's correct this > when we stumble acess a system tha

[bug-gnulib] Re: same, utimecmp should depend on minmax

2005-05-23 Thread Simon Josefsson
Bruno Haible <[EMAIL PROTECTED]> writes: > The following heuristics works very well in practice: > - First comes the #include "..." specifying the module being implemented. > - Then come all the #include <...> of system or system-replacement headers, > in arbitrary order. > - Then come a

Re: [bug-gnulib] stdint_.h update

2005-05-23 Thread Bruno Haible
Paul Eggert wrote: > Shouldn't that typedef of int64_t be protected by "#ifdef > NEED_SIGNED_INT_TYPES"? NEED_SIGNED_INT_TYPES is only needed for Cygwin (so far). Let's correct this when we stumble acess a system that has the same problem and uses the MSVC compiler. > (As an aside, NEED_SIGNED_IN

[bug-gnulib] Re: gcc -Wall warning for minmax.h

2005-05-23 Thread Bruno Haible
Paul Eggert wrote: > Second, suppose and have conflicting > definitions of MIN and MAX? To work around the latter potential > problem you can #undef MIN and MAX after including . In this case we'll still get warnings, either when the user does #include #include or when he does #in

[bug-gnulib] Re: gcc -Wall warning for minmax.h

2005-05-23 Thread Bruno Haible
Derek Price wrote: > >First, the $gl_* variables should be cached, with AC_CACHE_CHECK. > > Done. Thanks. > + AC_CACHE_CHECK([whether defines MIN & MAX], > + gl_limits_h_has_minmax, Cache variables need to have _cv_ in their name. So one needs to change this to gl_cv_limits_h_ha

[bug-gnulib] Re: same, utimecmp should depend on minmax

2005-05-23 Thread Bruno Haible
Paul Eggert wrote: > More and more this is starting to sound like a loser situation. > Perhaps we should give up on these predecessor #includes entirely, and > warn users that they must include minmax.h after they include any file > that might possibly include a system file. I don't wish to go bac

[bug-gnulib] Re: [Patch] mode_* when compiling findutils with fresh gnulib

2005-05-23 Thread Paul Eggert
[EMAIL PROTECTED] (James Youngman) writes: > Gnulib guys, what's the significance of the changes made to > modechange.c? How should callers who previously used MODE_MASK_PLUS > modify their code to get the same behaviour? We couldn't find any programs that set some of the MODE_MASK bits but not

[bug-gnulib] [Patch] mode_* when compiling findutils with fresh gnulib (was: Re: merge from coreutils to gnulib (fd-safer, modechange, readutmp, ...))

2005-05-23 Thread Bas van Gompel
[This patch is for findutils. bug-gnulib Cc'd. Maybe they can answer my questions...] Op Mon, 02 May 2005 00:05:07 -0700 schreef Paul Eggert in <[EMAIL PROTECTED]>: : I installed this patch to merge coreutils changes into gnulib. [...] : There are also changes to the APIs for modechange and for