Re: [incomplete patch] Get objdump to report exception tables for ARM/SH4 correctly

2008-07-18 Thread Nick Clifton
Hi Danny, > 2008-03-29 Danny Backx <[EMAIL PROTECTED]> > >* pe-arm-wince.c (pe_print_compressed_pdata): Define new function to >print compressed pdata structure as described on MSDN. This only >applies to a limited set of architectures (ARM, SH4). >* pe-arm-wince.c (slurp_symtab

Re: [incomplete patch] Get objdump to report exception tables for ARM/SH4 correctly

2008-07-16 Thread Danny Backx
On Mon, 2008-07-14 at 10:26 +0100, Nick Clifton wrote: > Hi Danny, > > > I was waiting for a more informative reply but that didn't happen, > > Sorry - I had meant to say that I now agreed with your version of the > patch and that I was not expecting any more changes. > > > > Which source file

Re: [incomplete patch] Get objdump to report exception tables for ARM/SH4 correctly

2008-07-14 Thread Nick Clifton
Hi Danny, I was waiting for a more informative reply but that didn't happen, Sorry - I had meant to say that I now agreed with your version of the patch and that I was not expecting any more changes. Which source file should I put my stuff into ? An existing one, a new one ? An existing

Re: [incomplete patch] Get objdump to report exception tables for ARM/SH4 correctly

2008-07-12 Thread Danny Backx
I was waiting for a more informative reply but that didn't happen, and I lost track of this whole thing until someone reminded me recently. Which source file should I put my stuff into ? An existing one, a new one ? I'd like to get this thing over with ... Danny On Mon, 2008-04-14 at 15

Re: [incomplete patch] Get objdump to report exception tables for ARM/SH4 correctly

2008-04-14 Thread Nick Clifton
Hi Danny, (Sorry about the delay in replying, I am a bit snowed under at the moment). One of the earlier suggestions was for the default print_pdata to be used when the new field is NULL. This is how I implemented it. Doh, yes I should have realized that. I don't think I understand. If

Re: [incomplete patch] Get objdump to report exception tables for ARM/SH4 correctly

2008-04-05 Thread Danny Backx
On Fri, 2008-04-04 at 08:10 +0100, Nick Clifton wrote: > > Didn't know about that. I've used it, and added one or more lines to 30 > > other .c files. In most cases this is just > > > > #define bfd_pe_print_pdata NULL > > Shouldn't that be: > >#define bfd_pe_print_pdata pe_print_data > > ie

Re: [incomplete patch] Get objdump to report exception tables for ARM/SH4 correctly

2008-04-04 Thread Nick Clifton
Hi Danny, _IMAGE_CE_RUNTIME_FUNCTION_ENTRY formatted data right ? One day someone might want to write a MIPS version of this function, so we will need a Looks like you got interrupted while writing this sentence. Not sure what you mean. Oops! I meant that in the future there might be other

Re: [incomplete patch] Get objdump to report exception tables for ARM/SH4 correctly

2008-04-03 Thread Danny Backx
On Wed, 2008-04-02 at 16:47 +0100, Nick Clifton wrote: > > I've tried to tackle the conditional compilation part, and would like > > your renewed input on it, I may have missed some points. Naming for > > instance. > > > Naming was mostly OK. There were two problems. > pe_print_compressed_pdata

Re: [incomplete patch] Get objdump to report exception tables for ARM/SH4 correctly

2008-04-02 Thread Nick Clifton
Hi Danny, I've tried to tackle the conditional compilation part, and would like your renewed input on it, I may have missed some points. Naming for instance. Naming was mostly OK. There were two problems. pe_print_compressed_pdata() should really be called pe_print_ce_compressed_pdata() si

Re: [incomplete patch] Get objdump to report exception tables for ARM/SH4 correctly

2008-03-29 Thread Danny Backx
This has been on my todo-list for far too long, apologies. I've tried to tackle the conditional compilation part, and would like your renewed input on it, I may have missed some points. Naming for instance. Diffs in the attachment are relative to the cegcc svn, I've checked and they patch cleanly

Re: [incomplete patch] Get objdump to report exception tables for ARM/SH4 correctly

2007-08-06 Thread Nick Clifton
Hi Danny, 2. Cleanup in my_symbol_for_address. There's none now. Should there be? Yes. :-) Also it looks like my_symbol_for_address is going to quite slow for large symbol tables. You might want to consider ensuring that the symbol time is sorted by address and then performing some kind o

[incomplete patch] Get objdump to report exception tables for ARM/SH4 correctly

2007-08-06 Thread Danny Backx
[Retry to send this message without the attachment that probably blocked the earlier attempt.] I've attached a patch that'll get objdump to report exception tables correctly for ARM and SH4 which, according to MSDN, have a different format for storing the pdata segment. Here's part of the output