Hello,
Attached patch cleans up compiler warnings about unused variables, functions
etc. while compiling with '-Wall' option in gcc.
--
--
Siteshwar Vashisht
From 83394f684ab0b5451c351e37411e8cab3c4ed42a Mon Sep 17 00:00:00 2001
From: Siteshwar Vashisht
Date: Sun, 30 Jul 2017 16:0
On 4/17/15 2:03 PM, Eduardo A. Bustamante López wrote:
> 0001-Fix-spacing-issues-in-tests-to-make-it-easier-to-tra.patch
> 0002-Fix-unclosed-double-quote.patch
> 0004-Fix-declare-regression.patch
> 0003-Remove-compiler-warnings.-Does-that-really-need-to-b.patch
> 0005-Make-the
On Fri, Apr 17, 2015 at 04:26:08PM -0400, Mike Frysinger wrote:
> please post patches inline and as a series rather than attaching a binary
> tarball. it makes review much harder when you do this.
>
> in fact, `git send-email` takes care of all of this for you.
> -mike
Makes sense, thanks! I'll
please post patches inline and as a series rather than attaching a binary
tarball. it makes review much harder when you do this.
in fact, `git send-email` takes care of all of this for you.
-mike
signature.asc
Description: Digital signature
ote.patch
This is a simple mistake of leaving an unclosed "
0004-Fix-declare-regression.patch
This one I already reported.
0003-Remove-compiler-warnings.-Does-that-really-need-to-b.patch
0005-Make-the-compiler-happy-remove-volatile.patch
0006-Remove-unused-variables-and-functions-make-CFLAG
Noticed this while fixing compiler warnings for readline on cygwin:
diff --git i/lib/readline/readline.c w/lib/readline/readline.c
index abb29a0..9bb552f 100644
--- i/lib/readline/readline.c
+++ w/lib/readline/readline.c
@@ -1,7 +1,7 @@
/* readline.c -- a general facility for reading lines of
Hi,
On Tue, 08 Mar 2005 16:31:15 +0100, Chet Ramey wrote:
...
> > for (passc = 0; c = string[i]; i++)
> >
> > This could more readably be written:
> >
> > for (passc = 0; (c = string[i]) != '\0'; i++)
...
> No, the former is my preferred style. The latter is less readable and
> reduces clar
> When compiling bash with GCC there are a number of alarming-looking
> warnings, and several of them could be avoided by minor changes to the
> code. For example:
>
> bashline.c:2976: warning: suggest parentheses around assignment used
> as truth value
>
> for (passc = 0; c = string[i]; i++)
When compiling bash with GCC there are a number of alarming-looking
warnings, and several of them could be avoided by minor changes to the
code. For example:
bashline.c:2976: warning: suggest parentheses around assignment used
as truth value
for (passc = 0; c = string[i]; i++)
This could more
