> When compiling bash with GCC there are a number of alarming-looking
> warnings, and several of them could be avoided by minor changes to the
> code. For example:
>
> bashline.c:2976: warning: suggest parentheses around assignment used
> as truth value
>
> for (passc = 0; c = string[i]; i++)
>
> This could more readably be written:
>
> for (passc = 0; (c = string[i]) != '\0'; i++)
>
> Would you be willing to accept patches to make changes such as this?
No, the former is my preferred style. The latter is less readable and
reduces clarity.
Chet
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
( ``Discere est Dolere'' -- chet )
Live...Laugh...Love
Chet Ramey, ITS, CWRU [EMAIL PROTECTED] http://tiswww.tis.cwru.edu/~chet/
_______________________________________________
Bug-bash mailing list
Bug-bash@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-bash
