On 2017-12-04 at 16:38 +0530, Thiruvadi Rajaraman wrote:
> Hi Chester,
>
> Based on your review comments and suggestions about the earlier fixes,
> reworked on the fix with pselect()
> to block the signal.
> Blocked the SIGCHLD signal using sigprocmask().
>
> Attached the reworked fix patch for y
On Mon, Dec 4, 2017 at 5:08 AM, Thiruvadi Rajaraman
wrote:
> Hi Chester,
>
> Based on your review comments and suggestions about the earlier fixes,
> reworked on the fix with pselect()
> to block the signal.
FYI,
Chet pushed a few changes related to this in commits
564452a3ec9b73a53949325cc4acb9
Hi Chester,
Based on your review comments and suggestions about the earlier fixes,
reworked on the fix with pselect()
to block the signal.
Blocked the SIGCHLD signal using sigprocmask().
Attached the reworked fix patch for your kind reference.
Please kindly review the patch and suggest your comm
On 12/1/17 7:49 AM, Thiruvadi Rajaraman wrote:
> Hi Chester,
>
> Thanks a lot for your review comments.
>
> I reworked on the fix to solve bash sleep issue and here attached the patch.
I don't think you got my point. Why would you override bash's installed
signal handler -- disabling job and pr
Hi Chester,
Thanks a lot for your review comments.
I reworked on the fix to solve bash sleep issue and here attached the patch.
>From include/bits/signum.h,
#define SIG_DFL ((__sighandler_t) 0)/* Default action. */
In the attached patch fix, signal(SIGCHLD, SIG_DFL), SIG_DFL perfo
On 11/28/17 9:41 AM, Chet Ramey wrote:
> On 11/27/17 2:47 PM, Ángel wrote:
>
>> Also there's the issue that select() _may_ modify the object pointed to
>> by the timeout argument [POSIX]. But it may not, in which case this
>> would end up oversleeping.
>>
>> On such system, doing eg.
>> sleep 9 &
On 11/27/17 2:47 PM, Ángel wrote:
> Also there's the issue that select() _may_ modify the object pointed to
> by the timeout argument [POSIX]. But it may not, in which case this
> would end up oversleeping.
>
> On such system, doing eg.
> sleep 9 & time sleep 10
>
> would end up sleeping 19 sec
On 11/28/17 12:17 AM, Thiruvadi Rajaraman wrote:
> Hi,
>
> Thanks a lot for your review comments.
>
> I have reworked on the bash sleep fix based on your suggestion about signal
> and trap handling in fsleep( ).
>
> I have attached the fix patch for your kind reference.
Your patch unconditional
Hi,
Thanks a lot for your review comments.
I have reworked on the bash sleep fix based on your suggestion about signal
and trap handling in fsleep( ).
I have attached the fix patch for your kind reference.
Test logs with fix patch:
==
root@x86-generic-64:~/bash-4.2# ./bash
root
On 2017-11-27 at 17:47 +0530, Thiruvadi Rajaraman wrote:
> Reproducible test case and Console logs:
>
Simpler test case:
bash-4.4-rc1# cd examples/loadables/
bash-4.4-rc1/examples/loadables# enable -f ./sleep sleep
bash-4.4-rc1/examples/loadables# sleep 1 &
On 11/27/17 4:17 AM, Thiruvadi Rajaraman wrote:
> Hi,
>
> Found a 'sleep' execution issue with bash loadable builtins and has
> performed
> the below sleep test on bash-4.4-rc1.
That's an interesting one. It looks like the SIGCHLD interrupts the select
loop, even though bash supplies SA_RESTART w
Hi,
Found a 'sleep' execution issue with bash loadable builtins and has
performed
the below sleep test on bash-4.4-rc1.
Bash version: 4.4-rc1
Web link: https://ftp.gnu.org/gnu/bash/bash-4.4-rc1.tar.gz
Reproducible test case and Console logs:
bash-4.4-rc1
12 matches
Mail list logo
