On 12/1/17 7:49 AM, Thiruvadi Rajaraman wrote:
> Hi Chester,
>
> Thanks a lot for your review comments.
>
> I reworked on the fix to solve bash sleep issue and here attached the patch.
I don't think you got my point. Why would you override bash's installed
signal handler -- disabling job and process handling -- without restoring
it before the function returns? Even if changing the signal handler were
the right thing to do, which it isn't, it's just a terrible idea to change
it unconditionally. The right fix is to block SIGCHLD during the sleep,
which you can do easily using pselect.
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU c...@case.edu http://cnswww.cns.cwru.edu/~chet/
