Re: skip_ vs. skip_all_

2012-01-04 Thread Peter Rosin
Stefano Lattarini skrev 2012-01-04 19:53: > On 01/04/2012 07:48 PM, Peter Rosin wrote: >> test defs: skip all tests when the lib requirement isn't fulfilled >> >> * tests/defs (lib): Use skip_all_ instead of skip_, in order to support >> TAP-based test scripts. >> > Sounds good. Thanks! Pushed to

Re: skip_ vs. skip_all_

2012-01-04 Thread Stefano Lattarini
On 01/04/2012 07:48 PM, Peter Rosin wrote: > Thanks for the feedback, I can push it, do you have any issues with the > below commit message? > > Cheers, > Peter > > test defs: skip all tests when the lib requirement isn't fulfilled > > * tests/defs (lib): Use skip_all_ instead of skip_, in order

Re: skip_ vs. skip_all_

2012-01-04 Thread Peter Rosin
Stefano Lattarini skrev 2012-01-04 18:34: > On 01/04/2012 03:57 PM, Peter Rosin wrote: >> diff --git a/tests/defs b/tests/defs >> index dbf0ff9..835788d 100644 >> --- a/tests/defs >> +++ b/tests/defs >> @@ -774,7 +774,8 @@ do >># Attempting to create an empty archive will actually not >>

Re: skip_ vs. skip_all_

2012-01-04 Thread Stefano Lattarini
On 01/04/2012 03:57 PM, Peter Rosin wrote: > Hi! > > All other "required" tests on master bails out with skip_all_, > shouldn't 'lib' do that too? Is this the result of a bad merge > or something? > Yes (or more precisely, of a missed edit after a merge). It hasn't caused any error until now bec

Re: skip_ vs. skip_all_

2012-01-04 Thread Peter Rosin
Peter Rosin skrev 2012-01-04 15:41: > Hi! > > All other "required" tests on master bails out with skip_all_, > shouldn't 'lib' do that too? Is this the result of a bad merge > or something? Oh crap, that patch was destroyed (by 'less' I think). Here's a better one. diff --git a/tests/defs b/tes

skip_ vs. skip_all_

2012-01-04 Thread Peter Rosin
Hi! All other "required" tests on master bails out with skip_all_, shouldn't 'lib' do that too? Is this the result of a bad merge or something? Cheers, Peter diff --git a/m4/amversion.m4 b/m4/amversion.m4 old mode 100644 new mode 100755 diff --git a/tests/defs b/tests/defs index dbf0ff9..1d4e8c