On 01/04/2012 03:57 PM, Peter Rosin wrote: > Hi! > > All other "required" tests on master bails out with skip_all_, > shouldn't 'lib' do that too? Is this the result of a bad merge > or something? > Yes (or more precisely, of a missed edit after a merge). It hasn't caused any error until now because, for "classical" test scripts (i.e., not using TAP) `skip_' and `skip_all_' are aliases, and for the moment there is no TAP-based test script with lib in required:
$ grep 'required=.*lib\>' tests/*.tap || echo NO MATCH NO MATCH > > diff --git a/tests/defs b/tests/defs > index dbf0ff9..835788d 100644 > --- a/tests/defs > +++ b/tests/defs > @@ -774,7 +774,8 @@ do > # Attempting to create an empty archive will actually not > # create the archive, but lib will output its version. > echo "$me: running $AR -out:defstest.lib" > - $AR -out:defstest.lib || skip_ "Microsoft \`lib' utility not available" > + $AR -out:defstest.lib \ > + || skip_all_ "Microsoft \`lib' utility not available" > ;; > makedepend) > echo "$me: running makedepend -f-" > This is the right fix. Should I apply it, or will you do so (with a proper git commit message, of course)? Thanks, Stefano
