On Oct 2, 2007, at 1:20 AM, Paul Eggert wrote:
Ralf Wildenhues <[EMAIL PROTECTED]> writes:
+ xsystem ("rm -rf '$cache'")
This won't work well if $cache contains an apostrophe.
I realize this sort of problem is not new to the patch, but while
we're making changes in this area, why not f
Ralf Wildenhues <[EMAIL PROTECTED]> writes:
>> + xsystem ("rm -rf '$cache'")
This won't work well if $cache contains an apostrophe.
I realize this sort of problem is not new to the patch, but while
we're making changes in this area, why not fix it? Either check for
and reject cache names c
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Ralf Wildenhues on 9/30/2007 10:21 AM:
>
>> +{
>> + unlink $f or error "error: Cannot remove `$f': $!"
>> +unless not -f $f;
>
> FWIW, this kind of code leaves me wondering about perl operator
> precedence. Is `unless'
Hello Benoit,
Ooops. It seems my memory was messed up, thinking it was your turn
of work with this patch and not mine ... apologies for the long delay,
and thanks for the revised patch.
* Benoit Sigoure wrote on Mon, Jun 25, 2007 at 12:05:31AM CEST:
>
> Alright so here is the new (hopefully fina
Quoting Ralf Wildenhues <[EMAIL PROTECTED]>:
Hello Benoit,
Thanks for your continuing work on this!
Thank *you* for your thorough and relevant reviews. It's thanks to
people like you that Free software is and remains high-quality
software. So thank you for investing your precious time i
Hello Benoit,
Thanks for your continuing work on this!
* Benoit Sigoure wrote on Tue, Jun 19, 2007 at 12:22:05AM CEST:
>
> 2007-06-17 Benoit Sigoure <[EMAIL PROTECTED]>
>
> * automake.in, aclocal.in: New option `--clean'.
> ($clean, @files_installed): New.
> * automake.in (&re
Quoting Ralf Wildenhues <[EMAIL PROTECTED]>:
Hello Benoit,
* Benoit Sigoure wrote on Sun, Jun 17, 2007 at 01:16:35AM CEST:
I've reviewed the patches I proposed back in March, completed them with
tests, ChangeLog and NEWS entries. If they are accepted, I'll write the
documentation.
Please w
