On 02/28/2012 08:52 PM, Dave Goodell wrote:
> Your patch does not work for me.
>
Yep, that's because of this embarassing mistake: I used
'*CC '*)
where I should have (obviously) used:
*'CC '*)
> Attached is a fixed version of your patch that matches the offending $CXX
> value correctly, handle
Your patch does not work for me. Attached is a fixed version of your patch
that matches the offending $CXX value correctly, handles spaces in compiler
wrapper arguments, and fixes a typo.
If you have a better alternative to the conservative "case" statement that I
used, please use it. Between
Hi Dave, thanks for the patch.
It turns out we have already in place a workaround for a situation
similar to the one you're facing (that situation being the Sun C++
compiler being named 'CC'). So the best fix IMO is to extend this
workaround to deal also with you case. The attached patch should
Otherwise non-silent output such as "pgCC" or "sunCC" could
unintentionally match.
---
tests/silent-many-generic.test |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/tests/silent-many-generic.test b/tests/silent-many-generic.test
index a7a0487..4d254ee 100755
--- a/tests