Hi Dave, thanks for the patch.
It turns out we have already in place a workaround for a situation
similar to the one you're facing (that situation being the Sun C++
compiler being named 'CC'). So the best fix IMO is to extend this
workaround to deal also with you case. The attached patch should do
so. Can you confirm it fixes your issue?
Thanks,
Stefano
>From 3c3b02e59d5af94865206a8b6f18d690b05096da Mon Sep 17 00:00:00 2001
Message-Id: <3c3b02e59d5af94865206a8b6f18d690b05096da.1330445909.git.stefano.lattar...@gmail.com>
From: Stefano Lattarini <stefano.lattar...@gmail.com>
Date: Tue, 28 Feb 2012 17:12:39 +0100
Subject: [PATCH] tests: fix spurious failure with Portland Compilers
>From a report by Dave Goodell.
* tests/silent-many-generic.test (configure.ac): Be more careful
in the workaround to avoid spurious failures with C++ compilers
containing the string "CC" in their names; this avoids spurious
failures with at least the Sun Studio C++ compiler (when named
"sunCC") and the Portland Group C+ Compiler ("pgCC").
* THANKS: Update.
---
THANKS | 1 +
tests/silent-many-generic.test | 13 +++++++------
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/THANKS b/THANKS
index 1bc3a80..9d3c32c 100644
--- a/THANKS
+++ b/THANKS
@@ -71,6 +71,7 @@ Daniel Kahn Gillmor d...@fifthhorseman.net
Daniel Richard G. sk...@iskunk.org
Debarshi Ray ri...@gnu.org
Dave Brolley brol...@redhat.com
+Dave Goodell good...@mcs.anl.gov
Dave Hart daveh...@gmail.com
Dave Korn dave.korn.cyg...@googlemail.com
Dave Morrison d...@bnl.gov
diff --git a/tests/silent-many-generic.test b/tests/silent-many-generic.test
index a7a0487..7d82f99 100755
--- a/tests/silent-many-generic.test
+++ b/tests/silent-many-generic.test
@@ -110,13 +110,14 @@ test -n "`echo $CXX`" || AC_MSG_ERROR([C++ compiler not found], [77])
test -n "`echo $FC`" || AC_MSG_ERROR([Fortran compiler not found], [77])
test -n "`echo $F77`" || AC_MSG_ERROR([Fortran 77 compiler not found], [77])
-# The SunStudio C++ compiler is unfortunately named 'CC' (yuck!),
-# and this can cause problems with our grepping checks on the
-# output from make. Avoid these problems by invoking a wrapper
-# script, as filtering the make output proved too fragile.
+# The SunStudio C++ compiler is unfortunately named 'sunCC' (or even just
+# 'CC', yuck!); similarly and the Portaland group C++ compiler is named
+# 'pgCC'. This can cause problems with our grepping checks on the output
+# from make. Avoid these problems by invoking a wrapper script, as
+# filtering the make output proved too fragile.
case " $CXX " in
- *' CC '*|*'/CC '*)
- AC_MSG_WARN([the C++ compiler '$CXX' seems to be named 'CC'])
+ '*CC '*)
+ AC_MSG_WARN([the C++ compiler '$CXX' name ends with 'CC'])
AC_MSG_WARN([it will be wrapped with the custom script 'am--cxx'])
echo '#!/bin/sh' > bin/am--cxx
echo 'PATH=$saved_PATH; export PATH' >> bin/am--cxx
--
1.7.9
