Re: [PATCH] hacking: document format for git commit messages

2012-02-27 Thread Stefano Lattarini
On 02/27/2012 04:48 PM, Eric Blake wrote: > On 02/26/2012 02:02 AM, Stefano Lattarini wrote: >>> Do you really want to start requiring a Signed-off-by line, now? > > I don't care either way, but it's slightly less work without. > > I don't care whether you require it, require it to be omitted, or

Re: [PATCH] hacking: document format for git commit messages

2012-02-27 Thread Eric Blake
On 02/26/2012 02:02 AM, Stefano Lattarini wrote: >> Do you really want to start requiring a Signed-off-by line, now? I don't care either way, but it's slightly less work without. >> I explicitly avoid such lines as redundant when they merely repeat >> what's on the Author: line. >> > I'm not trul

Re: [PATCH] hacking: document format for git commit messages

2012-02-26 Thread Jim Meyering
Stefano Lattarini wrote: > On 02/26/2012 10:02 AM, Stefano Lattarini wrote: >> >> - many other projects (linux, git itself) seems to use them, and I >> believe there's a reason for this (even if I've failed to find it >> so far); >> > Here it is -- point 12 at: > https://github.com/torval

Re: [PATCH] hacking: document format for git commit messages

2012-02-26 Thread Stefano Lattarini
On 02/26/2012 10:02 AM, Stefano Lattarini wrote: > > - many other projects (linux, git itself) seems to use them, and I > believe there's a reason for this (even if I've failed to find it > so far); > Here it is -- point 12 at: https://github.com/torvalds/linux/blob/7ada1dd6/Documentation

Re: [PATCH] hacking: document format for git commit messages

2012-02-26 Thread Stefano Lattarini
On 02/26/2012 08:53 AM, Jim Meyering wrote: > Stefano Lattarini wrote: > >> On 02/25/2012 08:38 PM, Stefano Lattarini wrote: >>> >>> But I should definitely improve HACKING and have it document the >>> standards and best practice for commit logs (since the GCS are sadly >>> weak and out-of-date in

Re: [PATCH] hacking: document format for git commit messages

2012-02-25 Thread Jim Meyering
Stefano Lattarini wrote: > On 02/25/2012 08:38 PM, Stefano Lattarini wrote: >> >> But I should definitely improve HACKING and have it document the >> standards and best practice for commit logs (since the GCS are sadly >> weak and out-of-date in this regard). >> > And here is my attempt. WDYT? I

[PATCH] hacking: document format for git commit messages (was: Re: [PATCH] tests: avoid spurious failure when gcj is not installed)

2012-02-25 Thread Stefano Lattarini
17 +0100 Subject: [PATCH] hacking: document format for git commit messages * HACKING (Writing a good commit message): New section. (Working with git): A related minor adjustment. Signed-off-by: Stefano Lattarini --- HACKING | 65 +- 1 file

[PATCH] hacking: document format for git commit messages (was: Re: [PATCH] tests: avoid spurious failure when gcj is not installed)

2012-02-25 Thread Stefano Lattarini
On 02/25/2012 08:38 PM, Stefano Lattarini wrote: > > But I should definitely improve HACKING and have it document the > standards and best practice for commit logs (since the GCS are sadly > weak and out-of-date in this regard). > And here is my attempt. WDYT? I will push in a couple of days if