bug#61671: Remove parentheses around test argument lists

2023-03-29 Thread Paul Eggert
Thanks, I installed that patch into Automake.

bug#61670: [PATCH] Improve test for blocked signals

2023-03-29 Thread Paul Eggert
Thanks, I installed that patch into Automake.

[bug#61240] [PATCH 2/2] Gracefully degrade if Time::HiRes is not available

2023-03-29 Thread Paul Eggert
Thanks for the explanation. I installed those two patches into Automake.

[bug#61240] [PATCH 2/2] Gracefully degrade if Time::HiRes is not available

2023-03-28 Thread Paul Eggert
On 2023-03-28 08:21, Warren Young wrote: Surely Solaris 10 (shipped in 2005) is relegated to the role of porting target, getting nothing but a “dist” tarball? Good point. I'll cc this to Dagobert Michelsen, who maintains the Autoconf port for Solaris 10. Dagobert, are people still running Au

[bug#61240] improve high-res file timestamp in Automake

2023-02-05 Thread Paul Eggert
On 2023-02-05 21:43, Jacob Bachmeyer wrote: Should the patch be relative to commit 6d6fc91c472fd84bd71a1b012fa9ab77bd94efea (before the version requirement bump) or should it include reverting commit 4e3744a15c4d8bdb46c11ead2fb56c5f591b714b (the version requirement bump)? Might as well do i

[bug#61240] improve high-res file timestamp in Automake

2023-02-05 Thread Paul Eggert
On 2023-02-05 17:14, Jacob Bachmeyer wrote: How often is Perl built to use long doubles these days?  (That was an option beginning with Perl 5.6.) I doubt it's used much. It's not used in Ubuntu or Fedora, for what it's worth. And on some platforms (e.g., macOS on current Apple silicon) -Dus

[bug#61240] improve high-res file timestamp in Automake

2023-02-04 Thread Paul Eggert
On 2023-02-04 16:02, Jacob Bachmeyer wrote: In any case, you will still need to account for the possibility that Time::HiRes::stat() might not actually have higher resolution, depending on the filesystem. That's fine. All we want is the exact file timestamp. If the file system timestamp resol

[bug#61240] improve high-res file timestamp in Automake

2023-02-03 Thread Paul Eggert
On 2023-02-03 18:27, Jacob Bachmeyer wrote: Where are you actually using a 5.10 feature? Where lib/Automake/FileUtils.pm says "use Time::HiRes qw(stat);". This does not work with Perl 5.6. For why we bumped the version to 5.10, please see: https://git.savannah.gnu.org/cgit/autoconf.git/comm

[bug#61240] improve high-res file timestamp in Automake

2023-02-02 Thread Paul Eggert
don't think that's a problem nowadays.From 4e3744a15c4d8bdb46c11ead2fb56c5f591b714b Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 2 Feb 2023 14:13:24 -0800 Subject: [PATCH 1/2] maint: require perl 5.010 or later This is needed for better treatment of high-res timestamps.

Re: [RFC PATCH 0/6] Work around autoconf/automake warnings skew

2020-09-22 Thread Paul Eggert
On 9/22/20 1:04 PM, Zack Weinberg wrote: The main thing I want to discuss before merging these patches is the location of the new Perl function merge_WARNINGS. I put it in ChannelDefs.pm because that is where all the other code relating to WARNINGS is, but it’s only used in autoreconf, so there

Re: [RFC PATCH 0/3] Work around autoconf/automake warnings skew (automake side)

2020-09-22 Thread Paul Eggert
On 9/22/20 3:47 PM, Karl Berry wrote: Zack, the Automake changes look fine to me. Please commit/push at your convenience, as far as I'm concerned. Thanks!! They look good to me, too.

Re: [PATCH] up_to_date_p: treat equal mtime as outdated.

2020-04-13 Thread Paul Eggert
On 4/13/20 4:21 PM, Harald van Dijk wrote: For better or worse, FAT is the most universally accepted file system, and for that reason it is widely used. It does not even support second precision timestamps. Let's not worry much about that. In practice, little development of Automake-using sof

[INSTALLED 2/3] install-sh: do not assume / = //

2017-09-23 Thread Paul Eggert
* lib/install-sh: Do not append / to destination directory if it already ends in /. This supports a destination directory of // on hosts where / and // are distinct directories, as POSIX allows. --- lib/install-sh | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff -

[INSTALLED 1/3] maint: fix two more http: URLs

2017-09-23 Thread Paul Eggert
* m4/init.m4: Change http: to https: in comments. --- m4/init.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/m4/init.m4 b/m4/init.m4 index f788134a1..9024b3aaa 100644 --- a/m4/init.m4 +++ b/m4/init.m4 @@ -87,8 +87,8 @@ AC_REQUIRE([AM_PROG_INSTALL_STRIP])dnl AC_REQUIRE(

[INSTALLED 3/3] maint: update .gitignore

2017-09-23 Thread Paul Eggert
* .gitignore: Add pre-inst-env, and sort. --- .gitignore | 75 +++--- 1 file changed, 38 insertions(+), 37 deletions(-) diff --git a/.gitignore b/.gitignore index 56bdce2c6..89e71ec97 100644 --- a/.gitignore +++ b/.gitignore @@ -1,68 +1,69 @

Re: bug#20314: [PATCH] Make output of mdate-sh deterministic

2017-09-22 Thread Paul Eggert
On 09/22/2017 02:57 AM, Bruno Haible wrote: Gnulib also supports MSVC, which interprets the TZ environment variable in its own way [1][2]. From this doc and from POSIX [3], it looks to me that UTC0 GMT0 GMT+0 GMT-0 would all be equivalent and portable. Can you confirm this? All of t

Re: bug#20314: [PATCH] Make output of mdate-sh deterministic

2017-09-21 Thread Paul Eggert
se TZ='UTC0' instead of TZ='UTC'. Thanks. For reference, here's the POSIX spec for TZ: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03 and look for "TZ". From 5b240b3b36766045a47a6ad89ae5f4550e81d534 Mon Sep 17 00:00:00 2001 From

Re: FTP,HTTP → HTTPS in Automake doc and code

2017-09-16 Thread Paul Eggert
Mathieu Lirzin wrote: IMO it is important that reflects that change too. AIUI this page serves as a model for GPL license notices. Yes, that would be good. Unfortunately I don't know who's in charge of that URL.

FTP,HTTP → HTTPS in Automake doc and code

2017-09-16 Thread Paul Eggert
I installed into Automake 'master' a patch to prefer https: URLs to ftp: and http: URLs. It's a long patch so I won't bore the mailing list with it. Details and justification are here: https://git.savannah.gnu.org/cgit/automake.git/commit/?id=199e7a445040270fa5ef67623c56cde40d765199

Re: [PATCH v3] new option: object-shortname

2016-12-22 Thread Paul Eggert
On 12/22/2016 06:38 AM, Thomas Martitz wrote: this is one more attempt to get my patch reviewed. Can I assist in any way? Well, what we really need is an Automake maintainer, to do this sort of review work. Is that something you'd be willing to do (and be qualified for)? It's not a job to be

Re: [PATCH v3] new option: object-shortname

2016-09-09 Thread Paul Eggert
Thomas Martitz wrote: I thought you'd review and merge. It might be me at some point. Just not today, I'm afraid.

Re: [PATCH v3] new option: object-shortname

2016-09-09 Thread Paul Eggert
Thomas Martitz wrote: Please tell me if there's anything left for me to do? Not that I know of; someone needs to free up enough cycles to review it, that's all.

Re: bug#22702: [bug-grep] grep-2.23 build feedback

2016-09-08 Thread Paul Eggert
Jim Meyering wrote: I actually wrote a patch to fix the automake bug that led to this, but did not find the time to write a stand-alone test case. Today, I wrote the commit log entry and am attaching the incomplete diff (no NEWS and no test) here, in case someone wants to help move this along bef

Re: [PATCH v2] new option: object-shortname

2016-08-29 Thread Paul Eggert
Some minor comments: + - This option affects the file name automake uses for object files. + +Enabling the option shortens the file name such that the prefix +derived (after canonicalization) from the path is not included. For +instance, it is always foo-foo.o regardless of the path

Re: [PATCH] new option: object-shortname

2016-08-28 Thread Paul Eggert
Have you looked at the similar change that is planned for Automake 1.16? To build that, you can do this: git clone -b minor git://git.savannah.gnu.org/automake.git cd automake ./bootstrap.sh ./configure --prefix=/your/favorite/directory make Assuming your needs aren't satisfied already by 1.16'

[PATCH] maint: port time-stamp-time-zone to strict POSIX

2016-01-12 Thread Paul Eggert
Set time-stamp-time-zone to "UTC0", not to "UTC", as POSIX defines TZ="UTC0" not TZ="UTC". --- contrib/tap-driver.pl | 2 +- lib/compile | 4 ++-- lib/depcomp | 4 ++-- lib/install-sh| 4 ++-- lib/mdate-sh | 4 ++-- lib/missing | 4 ++-- lib/mkinstall

Re: bug#16337: [PATCH] doc: fix encoding error with UTF-8 characters

2014-01-04 Thread Paul Eggert
Stefano Lattarini wrote: please push (to the 'micro' branch) and close this bug report once you're done Thanks, done.

Re: bug#13378: Cleaning up AC_PROG_CC_C_O semantics

2013-01-16 Thread Paul Eggert
On 01/16/13 04:46, Stefano Lattarini wrote: > Makes sense. Should I try to implement something along these lines (might > take a few days), or are you planning to do that yourself (in which case > I'll avoid the duplicated efforts)? I wasn't planning on doing that, so please go ahead.

Re: Cleaning up AC_PROG_CC_C_O semantics

2013-01-14 Thread Paul Eggert
On 01/14/2013 11:56 AM, Stefano Lattarini wrote: > 1. It checks that *both* 'cc' and '$CC' (which might easily be 'gcc' > or 'clang') supports "-c -o" together. Why? If the user has a > broken base vendor compiler, but has installed a better one (say > GCC), why should he still b

Re: Cleaning up AC_PROG_CC_C_O semantics

2013-01-14 Thread Paul Eggert
On 01/14/13 02:24, Stefano Lattarini wrote: > Autoconfers, WDYT? I think I'm lost. http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13378 is a long thread.

Re: [FYI] {master} maint: assume 'test -x' is portable

2012-02-23 Thread Paul Eggert
It's been Quite Some Time since I've had to deal with 4.3BSD, or any host with a "test -x" problem, so I suggest the following patch to the Autoconf manual: diff --git a/doc/autoconf.texi b/doc/autoconf.texi index 607d8dc..443ec07 100644 --- a/doc/autoconf.texi +++ b/doc/autoconf.texi @@ -18125,9

Re: bug#10427: bug#10436: New testsuite driver and extra trailing backslash in recipes

2012-01-05 Thread Paul Eggert
I pushed the following doc fix into Autoconf, so that these two portability issues are documented there. It turns out that the second issue is actually due to an old Bash bug -- it's not Solaris-specific. >From b1f0e147aa7aa259dea2c34c5a0ac7965d6efd7e Mon Sep 17 00:00:00 2001 From: Pau

Re: [PATCH] drop "Win32" term

2012-01-04 Thread Paul Eggert
On 01/04/12 05:37, Stefano Lattarini wrote: > Care to fix those too? Here's a revised version of Bruno's patch that attempts to address all the issues that you raised. >From ef5461d37207a965217e1b09c8ef257622f9d43c Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Wed, 4 Jan 201

Re: AM_SILENT_RULES does not work with NonStop make

2011-12-28 Thread Paul Eggert
On 12/26/11 13:35, Stefano Lattarini wrote: > testing on non-Linux systems (*BSD and Solaris at least, hopefully also > Cygwin or MinGW). I tested it on Solaris 8 and that test worked fine. I used Autoconf 2.63, GNU m4 1.4.13, and the system-supplied 'make'. Some of the other tests failed, e.g.,

Re: bug#10237: bug#9928: bug#10237: AM_SILENT_RULES does not work with NonStop make

2011-12-26 Thread Paul Eggert
On 12/26/11 09:42, Stefano Lattarini wrote: > And here is the follow-up tweaking for the test cases I had > promised. I will push in a couple of days if there is no objection. Thanks, that looks good to me; please push it as soon as you like.

Re: bug#9928: bug#10237: AM_SILENT_RULES does not work with NonStop make

2011-12-25 Thread Paul Eggert
On 12/23/11 00:50, Stefano Lattarini wrote: > could you apply the patch *not to maint nor to master*, but to a *new* > branch (say `silent-fixes' or `silent-portability') based off of maint, > and push that new branch to the public automake repo? OK, done, as 'silent-fixes', with your recent nit-f

Re: AC_PROG_INSTALL: require installation of multiple files.

2008-01-22 Thread Paul Eggert
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > +that creates @file{install} from it if there is no makefile. Starting with > +Autoconf 2.62, this macro requires @command{install} to be able to install > +multiple files into a target directory. A minor point: as a general rule, it's better not to

Re: Patch proposal: Add --clean options to unbootstrap a project.

2007-10-01 Thread Paul Eggert
Ralf Wildenhues <[EMAIL PROTECTED]> writes: >> + xsystem ("rm -rf '$cache'") This won't work well if $cache contains an apostrophe. I realize this sort of problem is not new to the patch, but while we're making changes in this area, why not fix it? Either check for and reject cache names c

Re: CVS Automake fails to make check with CVS Autoconf

2007-06-22 Thread Paul Eggert
How about this (untested) patch to Automake? 2007-06-22 Paul Eggert <[EMAIL PROTECTED]> * tests/subst.test: Port to CVS autoconf. Problem reported by Benoit Sigoure in: http://lists.gnu.org/archive/html/automake-patches/2007-06/msg3.html --- automake

Re: automatic update Makefile.am -> Makefile.in -> Makefile no longer working

2007-06-21 Thread Paul Eggert
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > I think this should be applied to HEAD and branch-1-10. > Would you like me to do it? Yes, please. And thanks for your review; your points all look right to me. > So this is yet another reason to keep Autoconf version incompatibilities > as few as p

Re: automatic update Makefile.am -> Makefile.in -> Makefile no longer working

2007-06-20 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: > Are we now supposed to edit Makefile.in by hand each time we modify > Makefile.am? I hope not. How about the following (untested) Automake patch? 2007-06-20 Paul Eggert <[EMAIL PROTECTED]> * aclocal.in (write_aclocal): W

Re: ``install -C'' / unnecessarily updating time stamps

2007-01-09 Thread Paul Eggert
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > * tests/defs.in (is_newest): Cope with multiple newer files. > * NEWS: mention `install-sh -C'. Thanks, please apply.

Re: ``install -C'' / unnecessarily updating time stamps

2006-12-25 Thread Paul Eggert
Benoit Sigoure <[EMAIL PROTECTED]> writes: > http://lists.gnu.org/archive/html/automake-patches/2006-10/msg00070.html I installed the following to Automake install-sh to implement "install-sh -C", which is the second part of that patch. 2006-12-25 Paul Eggert

Re: ``install -C'' / unnecessarily updating time stamps

2006-12-24 Thread Paul Eggert
anup part. It shouldn't change any behavior. I installed this. I'll look into the -C part shortly. 2006-12-24 Paul Eggert <[EMAIL PROTECTED]> * lib/install-sh: Fix typo in previous patch for handling --. Use more-consistent style for ';;'. Pref

Re: calling autoreconf and minimizing rebuilds

2006-12-06 Thread Paul Eggert
Stepan Kasal <[EMAIL PROTECTED]> writes: > * tests/tools.at (autom4te preselections): Use `find -newer'; > remove one of the sleeps. Thanks; please install.

Re: calling autoreconf and minimizing rebuilds

2006-12-05 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > Even Linux > supports FAT, although I doubt anyone is foolhardy enough to develop on > FAT when there are so many better filesystems to choose from. But you > need at least 'sleep 2' to guarantee distinct timestamps on FAT. I don't think this is really a

Re: calling autoreconf and minimizing rebuilds

2006-12-04 Thread Paul Eggert
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > 2006-12-04 Ralf Wildenhues <[EMAIL PROTECTED]> > > * tests/tools.at (autom4te preselections): New test, to flag > entries missing from autom4te.cfg. > Report by David Byron <[EMAIL PROTECTED]>. This looks reasonable, but... > +: $

Re: install-sh misbehaves badly on buggy FreeBSD systems

2006-10-10 Thread Paul Eggert
;s a bit more consistent to test dir_arg rather than mkdir_mode (that's what the rest of the script does). So here's a revised patch. 2006-10-10 Paul Eggert <[EMAIL PROTECTED]> * lib/install-sh (posix_mkdir): Reject FreeBSD 6.1 mkdir -p -m, which incorrectly sets the m

install-sh misbehaves badly on buggy FreeBSD systems

2006-10-09 Thread Paul Eggert
Here's a proposed patch to Automake to work around the FreeBSD mkdir bug described in <http://lists.gnu.org/archive/html/bug-autoconf/2006-10/msg00012.html> 2006-10-09 Paul Eggert <[EMAIL PROTECTED]> * lib/install-sh (posix_mkdir): Reject FreeBSD 6.1 mkdir -p

Re: support for automake's support of gettext 0.15.1

2006-10-02 Thread Paul Eggert
Bruno Haible <[EMAIL PROTECTED]> writes: > * lib/autom4te.in (Automake-preselections): Add > AM_GNU_GETTEXT_INTL_SUBDIR, for automake 1.10. Thanks, I installed that into Autoconf.

Re: calling autoreconf and minimizing rebuilds

2006-09-07 Thread Paul Eggert
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > Definitely there should be a test for the bug. How about the one below? Looks good to me; please install. Thanks.

Re: automake/501: abbreviating the .Po-related output somewhat

2006-08-30 Thread Paul Eggert
Alexandre Duret-Lutz <[EMAIL PROTECTED]> writes: > Could you install this patch without removing the space after > -MF and -MT? OK, thanks; done. I guess we can worry about the unnecessary spaces later, as this isn't the only place where they're a problem.

Re: automake/500: unnecessary -I options in DEFAULT_INCLUDES (make clutter)

2006-08-30 Thread Paul Eggert
Alexandre Duret-Lutz <[EMAIL PROTECTED]> writes: > So how about something like this instead: use [EMAIL PROTECTED]@' and expand > it to `-I.' or `-I. -I$(srcdir)' as needed? Yes, thanks, that looks nice. For CVS coreutils/lib in-place builds with 'configure CFLAGS=' the patch changes this: g

Re: gettext: prepare Makefile.in.in for next Automake version

2006-08-24 Thread Paul Eggert
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > This is neither documented nor is it a desirable situation: > http://lists.gnu.org/archive/html/autoconf-patches/2006-05/msg00052.html > but it ended up being part of Autoconf for simplicity of the code (or > maybe just by chance?): > http://lists.gnu.

Re: make install using "-j"

2006-07-09 Thread Paul Eggert
Nobody's commented on the last proposed change to install-sh so I assume it looks OK and installed it in the trunk. I also installed the following commentary fix from Jim Meyering: 2006-07-09 Jim Meyering <[EMAIL PROTECTED]>

Re: make install using "-j"

2006-06-30 Thread Paul Eggert
t;> + posix_mkdir=: > > still falsely thinks the HP-UX mkdir is Posix conforming. Thanks for catching that. I suppose we'll have to make a test directory in /tmp after all, to catch these bugs. Here's a revised proposed patch which addresses this issue, along with o

Re: make install using "-j"

2006-06-22 Thread Paul Eggert
== RCS file: /cvs/automake/automake/ChangeLog,v retrieving revision 1.2901 diff -p -u -r1.2901 ChangeLog --- ChangeLog 7 Jun 2006 06:01:22 - 1.2901 +++ ChangeLog 22 Jun 2006 21:08:06 - @@ -1,3 +1,20 @@ +2006-06-22 Paul Eggert <[EMAIL PROTEC

Re: Automake 1.10 requirements for Autoconf

2006-06-12 Thread Paul Eggert
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > * lib/autom4te.in (Automake-preselections): Add AM_PROG_CXX_C_O, > AM_PROG_F77_C_O, AM_PROG_FC_C_O, AC_FC_SRCEXT, AC_FC_FREEFORM. Looks good to me; thanks.

Re: AC_PROG_CXX_C_O

2006-05-19 Thread Paul Eggert
That looks good to me, except let's not remove this comment: > -# The usefulness of this macro is questionable, as I can't really see > -# why anyone would use it. The only reason I include it is for > -# completeness, since a similar test exists for the C compiler. > I actually don't know whe

Re: autoreconf no longer works outside the current directory

2006-05-16 Thread Paul Eggert
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > * lib/Autom4te/Configure_ac.pm (find_configure_ac): Use > `$configure_in' instead of `configure.in', to preserve > directory component. > * lib/Automake/Configure_ac.pm: Add note that Automake owns > this file. > * l

Re: pending Autoconf + Automake patches

2006-05-11 Thread Paul Eggert
t I installed the following change into Automake, to sync install-sh with Autoconf. This implements the above-mentioned change in a nicer way on pre-Posix hosts, and also fixes a minor violation of the GNU coding standards. 2006-05-11 Paul Eggert <[EMAIL PROTECTED]> * lib/in

Re: pending Autoconf + Automake patches

2006-05-09 Thread Paul Eggert
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > Paul's install-sh race condition fix: > http://lists.gnu.org/archive/html/automake/2006-04/msg00136.html > > Noah's autom4te locking fix: > http://lists.gnu.org/archive/html/automake-patches/2006-04/msg00058.html > > Stepan's fix to have find_file rec

Re: AC_PROG_CC_STDC and ac_cv_prog_cc_stdc

2006-05-06 Thread Paul Eggert
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > Some Automake testsuite tests currently use > ./configure ac_cv_prog_cc_stdc=no > > to force use of ansi2knr. I know the topic is becoming more and more > obsolete, It's not "more and more obsolete". It's obsolete, period. Nobody uses K&R compile

Re: OpenBSD shell, errexit, and && in if clause

2006-05-01 Thread Paul Eggert
Ralf Wildenhues <[EMAIL PROTECTED]> writes: > This example isn't right, in that it does not expose the problem, as > the first command in the AND list should fail. Did you mean "test -z" > instead of "test -n" (four instances), or "foo=''", and is there a > reason to prefer it over the simpler "f

Re: OpenBSD shell, errexit, and && in if clause

2006-05-01 Thread Paul Eggert
e can assume the bug is present in more than one OpenBSD release, and the wording should be suitably vague. This reminds me of a longstanding related problem in BSD sh and make. I installed this patch into Autoconf, which combines the two ideas. 2006-05-01 Paul Eggert <[EMAIL PROTECTED]>

Re: FreeBSD, autom4te and locking on NFS

2006-04-27 Thread Paul Eggert
Noah Misch <[EMAIL PROTECTED]> writes: > I believe I lack an Automake copyright assignment; is an Autoconf > assignment sufficient, given that this file is present in both > projects? Yes. > Is this suitable? It looks fine to me (though I'm not a Perl whiz). Thanks. I hope Alexandre can commen

Re: mkdir -p -- minor cleanup

2006-04-24 Thread Paul Eggert
ondition on POSIX conforming hosts. On older hosts there's no hope that I can see in general, but it's not worth worrying about these ancient hosts at this point. I hope this addresses Ralf's concerns. 2006-04-24 Paul Eggert <[EMAIL PROTECTED]> * lib/install-sh: C

Re: mkdir -p -- minor cleanup

2006-04-19 Thread Paul Eggert
Stepan Kasal <[EMAIL PROTECTED]> writes: > I think it is more practical to have $(mkdir_p) set to 'mkdir -p --'. Yes, that is a possibility. > And you can often write > $(mkdir_p) $(directory_list) > without knowing exactly the names of the directories. It's natural to > forget that the d

mkdir -p -- minor cleanup

2006-04-19 Thread Paul Eggert
business a while ago, it was being used in a different context; but now that $(mkdir_p) is intended to mean 'mkdir -p' I think it's more consistent for the expansion to not include the '--'. Here's a proposed Automake patch to implement this. I noticed that install-sh

Re: Broken makefile given Autoconf version mismatch

2006-04-14 Thread Paul Eggert
Stepan Kasal <[EMAIL PROTECTED]> writes: > --- lib/Automake/FileUtils.pm 2006-04-14 09:25:00.0 +0200 > +++ lib/Automake/FileUtils.pm 2006-04-14 09:45:44.0 +0200 > @@ -73,6 +73,9 @@ >$optional = 1 > if $file_name =~ s/\?$//; > > + return "-" > +if $file_name eq "-";

Portable use of "{", ";", etc. within sed scripts (in Automake)

2006-01-05 Thread Paul Eggert
I looked for instances of the problem in Automake and found these. Most likely I missed some. Also, I haven't tested this, alas. 2006-01-05 Paul Eggert <[EMAIL PROTECTED]> * lib/install-sh (dstdir): Don't use semicolons inside { } in sed scripts, as Pos

Portable use of "{", ";", etc. within sed scripts

2006-01-05 Thread Paul Eggert
tion for this in the Autoconf manual, as described below. I also swept Autoconf for instances of this problem and fixed all the ones that I found. Here's the patch I installed. 2006-01-05 Paul Eggert <[EMAIL PROTECTED]> Fix Posix-conformance bugs re use of { command

Re: Bug in latest install-sh

2005-11-08 Thread Paul Eggert
Stepan Kasal <[EMAIL PROTECTED]> writes: >> Both do, but trap '' 0 seems to be the most portable. > > And it is also the clener one. > Proposed patch attached. Thanks. I installed that (replacing "trap - 0" with "trap '' 0" in install-sh) into Automake's main line. Perhaps it should be put into

Re: improved Automake test for file names with funny characters

2005-09-13 Thread Paul Eggert
Alexandre Duret-Lutz <[EMAIL PROTECTED]> writes: > PE> What changes in mkinstalldirs need to be merged into install-sh? > PE> (Presumably these can be folded in after the changes below are > installed.) > > I'll have to check. I think I noticed that mkinstalldirs was > trying `mkdir -p' before

Re: improved Automake test for file names with funny characters

2005-09-06 Thread Paul Eggert
back on the slow mkdir method if mkdir -p fails. This patch also fixes a typo in the doc patch I submitted last time ("length file names" -> "lengthy file names"). 2005-09-06 Paul Eggert <[EMAIL PROTECTED]> * doc/automake.texi (limitations on file names):

Re: improved Automake test for file names with funny characters

2005-07-20 Thread Paul Eggert
eason for that? There are some security issues involved here, I'm afraid, which would make it better to use GNU install if available. 2005-07-20 Paul Eggert <[EMAIL PROTECTED]> * doc/automake.texi (limitations on file names): New section. * lib/install-sh: Rewrite to su

Re: improved Automake test for file names with funny characters

2005-07-04 Thread Paul Eggert
vestigating it. I installed the following patch into Autoconf to fix that problem. This doesn't solve the problem of arbitrary chars in those strings, but at least '&' doesn't make 'configure' loop now. 2005-07-03 Paul Eggert <[EMAIL PROTECTED]>

Re: improved Automake test for file names with funny characters

2005-07-04 Thread Paul Eggert
why. If you think it important I could, I guess.) > Below is the new version. Thanks. After the recent Autoconf patch to allow | in file names, and some minor cleanups, here is a revised patch (I took your last version and ran with it): 2005-07-03 Paul Eggert <[EMAIL PROTECTED]>

improved Automake test for file names with funny characters

2005-07-01 Thread Paul Eggert
Look for 'infinite loop' in the patch below. Watch out: there are unusual control characters in this patch. I'll attach a copy of the patched file too, just in case. 2005-07-01 Paul Eggert <[EMAIL PROTECTED]> * tests/instspc.test: Major rewrite to test for

Re: [PATCH] Support AC_CONFIG_LIBOBJ_DIR (fixes PR/401)

2005-04-20 Thread Paul Eggert
"Gary V. Vaughan" <[EMAIL PROTECTED]> writes: > 2004-04-20 Gary V. Vaughan <[EMAIL PROTECTED]> > > * lib/autoconf/general.m4 (_AC_LIBOBJS_NORMALIZE): Prepend each object > named in LIBOBJS and LTLIBOBJS with the $(LIBOBJDIR), as set by latest > automake. That patch looks good

Re: [PATCH] Support AC_CONFIG_LIBOBJ_DIR

2005-04-18 Thread Paul Eggert
I like the patch from the Autoconf point of view, assuming the Automake folks take their bit. One small point: "Gary V. Vaughan" <[EMAIL PROTECTED]> writes: > +ac_libobj_dir= > +test "X${ac_config_libobj_dir-.}" != X. && > + ac_libobj_dir=`echo "$ac_config_libobj_dir/" | sed 's,/*$,/,'` That w