artifact of the archives, and not a problem with
your original submission. Anyone that is subscribed to the list got the
real contents, not the list-archived-munged contents.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Desc
004-2013 Free Software Foundation,
> +Copyright (C) 1994-1996, 1999-2002, 2004-2014 Free Software Foundation,
Hmm, is it worth getting autoconf up to 2015, and propagate that into
gnulib, before you commit this?
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualizati
> +then "make all" will create 'foo.o' and 's/bar.o' $(builddir) rather
s|'s/bar.o'|'s/bar.o' in|
> +than in $(srcdir), and 'baz.o' in $(top_builddir) rather than in
> +$(top_srcdir).
> +
> + This was the second pa
(PATH_SEPARATOR) does; but it would also be sufficient to use:
{ PATH='$(abs_builddir)/t/wrap$(PATH_SEPARATOR)'$$PATH && export PATH; }
if we're trying to go for the shortest line.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
ATH; }
Why are you changing this? I see no difference in the resulting shell
syntax, except that backslashes in $(abs_builddir) are now handled
differently. You need a lot more justification for WHY this patch is
necessary.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
dropping autoconf
On 07/17/2014 10:24 AM, Eric Blake wrote:
> [adding automake]
>
> On 07/17/2014 10:00 AM, Dimitrios Apostolou wrote:
>
>> --- cond.m4 2014-07-17 17:46:37.741723897 +0200
>> +++ cond.2.m42014-07-17 17:50:43.456076469 +0200
>> @@ -13,17
On 07/17/2014 12:44 PM, Dimitrios Apostolou wrote:
> Hi Erik, thank you for forwarding to the appropriate list!
>
> On Thu, 17 Jul 2014, Eric Blake wrote:
>>
>> I don't know if automake should work around your bad syntax, or if you
>> should just fix your confi
> AC_SUBST([$1_FALSE])dnl
> _AM_SUBST_NOTMAKE([$1_TRUE])dnl
> _AM_SUBST_NOTMAKE([$1_FALSE])dnl
> m4_define([_AM_COND_VALUE_$1], [$2])dnl
> -if $2; then
> +if $2
> +then
>$1_TRUE=
>$1_FALSE='#'
> else
>$1_TRUE='#'
>$1_FALSE=
> fi
> AC_CONFIG_COMMANDS_PRE(
> [if test -z "${$1_TRUE}" && test -z "${$1_FALSE}"; then
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
of relaying all the options passed to the
> original ./configure invocation through to the configure invocations
> in "make distcheck". This was causing problems, because it also passed
> through the original --srcdir and --prefix options.
>
--
Eric Blake eb
nce. Note that this bug
O(N) perhaps?
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
is name in the commit message
> - and in the test case you write. Put him into THANKS.
> + that fixes or exposes the bug, an put him into THANKS.
s/an/and/
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
a range of automake versions. Completely
undocumenting it will cause more problems than it solves.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
rg
> Enrico Scholz enrico.sch...@informatik.tu-chemnitz.de
> Erez Zadok e...@cs.columbia.edu
> -Eric Blake e...@byu.net
> +Eric Blake ebl...@redhat.com
> Eric Dorlande...@debian.org
>
; @@ -95,6 +95,16 @@ New in 1.14:
> <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13378#35>
> <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13378#44>
>
> + - The next major Automake version (2.0) will unconditionally turn on
> + the 'subdir-objects' optio
now that I
have any better ideas for what syntax to prefer.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
omake, and rebootstraps a package using the
same version of the tool it was originally created with, rather than
rebootstrapping with the latest version of the tool and forcing the
distro maintainers to heavily patch old packages. In other words, this
is not necessarily a good argument.
--
Eric B
ed efforts)?
>
> I wasn't planning on doing that, so please go ahead.
Didn't you already add _AM_PROG_CC_C_O_HELPME; is that a sufficient
witness macro for whether to use the proposed cleanups?
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http:
le' script and rewrite $CC)"; when you really
intend "always distribute 'compile' script, and (if losing compiler,
rewrite $CC)". Try this wording:
Instead, just touch up AC_PROG_CC to rewrite $CC when a losing compiler
is detected, and to always distribute the 'compi
_P), a user still
> wanting to use use the obsolete macro can simply define it in, say,
> acinclude.m4.
Yes, documenting _how_ to remain backwards compatible is helpful, but by
forcing the user to do work in their acinclude.m4 in order to remain
backwards-compatible is not as nice as jus
d is too harsh; made a no-op and/or made into a warning
(one which can be silenced for people knowingly being portable to older
automake) is nicer.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
p catchregression that would
s/catchregression/catch regressions/
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
> <http://lists.gnu.org/archive/html/autoconf-patches/2013-01/msg7.html>
Looks reasonable. I still need to spend another weekend on progressing
towards a release of 2.70.
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
From: Karl Berry
* automake.texi (Basics of Distribution): mention dist-hook
as working around the problems of whole directories in EXTRA_DIST.
---
I didn't mind taking 3 minutes to convert this into a git commit.
doc/automake.texi | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff
ffort of
researching something in a codebase you are more familiar with :O)
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
> make the autoconf update in a single batch.
Is _AM_EXTRA_RECURSIVE_TARGETS ever traced in any released version of
automake? If so, you can't remove it from the pre-selections, even if
newer automake no longer traces it. Basically, the preselections must
be the union of anything that an
; @command{aclocal} will then take care of automatically adding @file{m4/}
> @@ -3731,7 +3731,7 @@ MyPackage uses an @file{m4/} directory to store local
> macros as
> explained in @ref{Local Macros}, and has
>
> @example
> -AC_CONFIG_MACRO_DIR([m4])
> +AC_CONFIG_MACRO_DIRS([m4])
> @end example
It _might_ be worth mentioning that you must use one or both of automake
1.13 or autoconf 2.70 to have this work, and that back-compat to
automake 1.12 and autoconf 2.69 requires manual effort in configure.ac.
Meanwhile, I ought to do the same in the autoconf manual.
ACK once you fix the comment.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
AC_CONFIG_MACRO_DIRS([b])
and only traces 'a'. Here's how I would fix it (using the style I use
in autoconf):
m4_ifndef([AC_CONFIG_MACRO_DIRS],
[m4_defun([_AM_CONFIG_MACRO_DIRS])]dnl
[m4_defun([AC_CONFIG_MACRO_DIRS], [_AM_CONFIG_MACRO_DIRS($@)])])
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 11/09/2012 03:53 PM, Eric Blake wrote:
> Too many legacy tools exist for us to unilaterally quit supporting
> AC_CONFIG_MACRO_DIR - it is feasible for someone to want their
> package to bootstrap with both automake 1.13 and libtool 2.4.2,
> where the newer automake will only trace t
elision at the end; and
duplicate elision might make sense anyways). Also, since
AC_CONFIG_MACRO_DIR_TRACE is called once per directory (no matter how
many directories were crammed in one AC_CONFIG_MACRO_DIRS call), you
don't need to do any of the split(/\s+/) magic.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
t; duplicate efforts, especially considering that a patch from you will
> certainly be better then mine ;-)
Sounds like enough is waiting on me that I need to carve out a full day
for autoconf work. You've convinced me - I'll have a patches posted to
autoconf, including the best parts of w
, rather than via a new -W command-line argument.
Allowing file inclusion as the witness of whether to warn would work
even for older autoconf (where including the file has no effect), rather
than the current situation of warning about an unknown option.
--
Eric Blake ebl...@redhat.com+1-
nsure leading whitespace in its argument are handled correctly.
> * t/aclocal-macrodirs.tap ("AC_CONFIG_MACRO_DIRS: extra whitespace"):
> No longer declare it as an xfailing test.
You may not need this, if we go with my autoconf approach of tracing
_AC_CONFIG_MACRO_DIR which already s
k, then you
use 'a'; if the 'h' is silent, as in hour, then use 'an')
ACK with that fix; and assuming I ever get around to reviewing the other
two patches that add AC_CONFIG_MACRO_DIRS in the first place (looking at
them now...)
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
quired macros); but the Autoconf, Autotest, Automate,
M4sh, and M4sugar languages DO use the dedicated file and therefore get
the warning.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
> -# Make it harder to experience false postives when grepping error messages.
s/postives/positives/
> +# Weird name, to make it harder to experience false positives when
> +# grepping error messages.
> inst=__inst-dir__
>
> ./configure --prefix="$(pwd)/$inst"
>
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 07/21/2012 09:51 AM, Eric Blake wrote:
> On 07/13/2012 04:40 PM, Eric Blake wrote:
>
>>>>> My plan for autoconf is to implement AC_CONFIG_MACRO_DIRS, which can be
>>>>> invoked multiple times and also takes a whitespace-separated list in a
>>>>&
On 07/13/2012 04:40 PM, Eric Blake wrote:
>>>> My plan for autoconf is to implement AC_CONFIG_MACRO_DIRS, which can be
>>>> invoked multiple times and also takes a whitespace-separated list in a
>>>> single call, but which will basically then call AC_CONFIG_
e.
>>
>> I'll keep my automake patches on hold until you have gone ahead with your
>> plan, to avoid introducing inconsistencies and messing up the already
>> suboptimal automake history even more.
>>
>> Thanks for your continuous and outstanding w
On 07/12/2012 12:42 PM, Stefano Lattarini wrote:
>
> In the light of our discussion, attached is the patch I'd finally like
> to push. WDYT?
Looks fine to me (although I have not actually tested it).
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualizatio
On 07/12/2012 11:06 AM, Eric Blake wrote:
Minor correction:
>
> That said, /bin/RMDIR is probably completely portable, but seems like it
^ not
> would be reliable in practice.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtu
o I suspect many users intentionally create /bin/RMDIR (or even better,
/bIn/rMdIr), so using it as a hueristic seems okay for a first cut at
the problem at hand. Or, maybe you should just create a file in /tmp
under one spelling and check existence of the file by another spelling.
--
Eric Blake ebl.
would work; or maybe
if you pre-filter with 'test . -ef .' to ensure that -ef is understood,
before then trying -ef to check for case insensitivity.
Other than that, the only supported method in existing POSIX for
checking for equal files is by parsing 'ls -i' output; but I don&
er unique entry (that is, AC_CONFIG_MACRO_DIRS will be smart enough to
filter out duplicates). Tracing code should then trace _just_
AC_CONFIG_MACRO_DIR, which will be called once per directory, and where
the first call is the preferred dumping ground for new macros. There
shouldn't be a need to trace AC
On 07/04/2012 05:03 AM, Eric Blake wrote:
> Would it also make sense to allow multiple calls to AC_CONFIG_MACRO_DIR
> to stack, as in:
>
> AC_CONFIG_MACRO_DIR([dir1])
> AC_CONFIG_MACRO_DIR([dir2])
>
> And should we mention that the first directory listed has special
&g
whitespace-separated list, to minimize
confusion when using older libtool that doesn't understand this
documented newer semantic of autoconf. (Obviously, if libtool uses
grep, we should fix that as well...)
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
smarter about autotest
>> suites built by autoconf, as the current method for running an autotest
>> suite is rather verbose in Makefile.am.
>>
> Absolutely. Patches welcome ;-)
Slowly but surely starting the process of sending patches :)
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 06/27/2012 03:55 PM, Eric Blake wrote:
> Addresses automake bug#11793.
>
> This macro has been present for a long time, and coreutils has been
> relying on it despite no documentation, which argues that it is stable
> enough to be worth documenting.
>
> Furthermore, s
Addresses automake bug#11793.
This macro has been present for a long time, and coreutils has been
relying on it despite no documentation, which argues that it is stable
enough to be worth documenting.
Furthermore, since we are hoping to change our preferred invocation
from 'missing --run program'
to-date. In other words, @command{automake} will tell you when
>> @command{aclocal} needs to be rerun, but it will never diagnose a
>> missing @option{--force-missing}.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[adding bug-autoconf, for an autoconf documentation issue]
On 06/26/2012 11:46 AM, Eric Blake wrote:
> [adding bug-automake, to turn into a formal bug]
>
> On 06/26/2012 11:39 AM, Eric Blake wrote:
>
>> And while looking into how M4 differs from coreutils, I noticed that
>
On 06/26/2012 11:26 AM, Stefano Lattarini wrote:
> On 06/26/2012 06:40 PM, Eric Blake wrote:
>> Commit a22717dffe3 removed the --run argument, since our new preferred
>> calling conventions now imply it; but if a newer 'missing' is mixed
>> with an already built proj
ormal automake patch that tries to restore the
measure of back-compat.
>
> If we need a genuinely generic and stable script that offers some of
> the features of 'missing', it should be implemented in gnulib -- then,
> if possible, it will be automake which will start syncing
[adding bug-automake, to turn into a formal bug]
On 06/26/2012 11:39 AM, Eric Blake wrote:
> And while looking into how M4 differs from coreutils, I noticed that
> coreutils uses this via a .m4 file included into its configure.ac:
>
> AM_MISSING_PROG(HELP2MAN, help2man)
>
>
On 06/26/2012 12:04 PM, Bruno Haible wrote:
> Eric Blake wrote:
>>> Any idea for a simple solution to this problem?
>>
>> Aren't there timestamps in the auxiliary scripts for a reason? If a
>> script is updated as part of a new automake release, can't auto
Commit a22717dffe3 removed the --run argument, since our new preferred
calling conventions now imply it; but if a newer 'missing' is mixed
with an already built project that used an older Automake version, then
the 'Makefile' in that project will fail due to passing the --run
option when trying to
herwise it suggests rerunning 'automake --install'),
wouldn't it just be a matter of changing that check to instead be
whether 'missing --is-lightweight' succeeds? That is, your new feature
of a changed calling convention also came with an easily probed witness
option.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
o (test, doc etc.), but at least I'd like some feedback.
> Then I'll proceed to Yacc/Bison.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
ful (we should not be breaking features used by older
automake, and newer automake should be doing sanity checks that the
newer features are present before relying on the newer features). I'm
not sure whether 'missing' is independently useful outside of automake;
maybe it is bet
On 06/25/2012 09:46 PM, Eric Blake wrote:
>
>> case $1 in
>> ---run)
>> - # Try to run requested program, and just exit if it succeeds.
>> - run=
>> - shift
>> - "$@" && exit 0
>> - # Exit code 63 means version mismatch.
uite-new Fedora 17
where the installed automake is still 1.11.3), but coupled with the
latest build-aux script versions. Can we restore at least a measure of
back-compatibility so that the new missing coupled with old automake
doesn't fail miserably?
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
lly invokes a test as, say,
>
> $ .\\t\\foo.sh
In which case, they deserve their longer error message.
> Of course, I'm ready to revisit this position if there will be real reports
> from real users/developers; until then, I'd keep the simpler idiom above. OK?
Simpler is fine
amp; test -n "$me" \
> -|| { echo "$argv0: failed to define \$me" >&2; exit 99; }
> + # Strip all directory components.
> + me=${argv0##*/}
Should this strip to the last [\\/] instead of /?
> + # Strip test suffix.
> + case $me in
> +
an unconfigured tree
> + # is an error, env when the user is running GNU make.
did you mean 'even' instead of 'env'?
Other than that, I didn't review closely, but assume it is decent.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
@@ -31,7 +31,6 @@ END
> $ACLOCAL
> $AUTOMAKE
>
> -num=`grep depcomp Makefile.in | wc -l`
> -test $num -gt 1
> +test $($FGREP -c depcomp Makefile.in) -gt 1
Are you sure this idiom is safe on shells that don't handle Ctrl-C very
well? As documented in autoconf, even some
_RUNNER_SHELL -c "$init; fi" "$dummy_test_script"
> +$AM_TEST_RUNNER_SHELL -c "$init; true ( true )" "$dummy_test_script"
ACK. Does the autoconf testsuite suffer from any of the same
assumptions about being able to trigger a syntax error?
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-
> 1 file changed, 56 insertions(+), 57 deletions(-)
Always nice to reviewers to separate indentation cleanups from logic
changes.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
|3 +--
> defs-static.in |3 ---
> t/self-check-cleanup.tap |4
> t/self-check-exit.tap | 13 +
> t/self-check-explicit-skips.sh |2 --
> 6 files changed, 2 insertions(+), 26 deletions(-)
quot;; then
> +# Let the user override it.
> +ac_cv_AM_TEST_RUNNER_SHELL=$AM_TEST_RUNNER_SHELL
> + else
> +ac_cv_AM_TEST_RUNNER_SHELL=no
> +am_candidate_shells=${CONFIG_SHELL-}
> +# For the benefit of Solaris.
> +am_PATH=$PATH$PATH_SEPARATOR/usr/xpg4/bin
mp;& echo okok >foo" t/dummy.sh \
> + env keep_testdirs=yes \
> + $AM_TEST_RUNNER_SHELL -c ". ./defs && echo okok >foo" t/dummy.sh \
Why did you add an env wrapper? I guess it doesn't hurt, but it is one
more layer of execution.
This patch lo
On 05/01/2012 04:27 PM, Stefano Lattarini wrote:
> HI Eric, thanks for the super-quick review.
>
> On 05/02/2012 12:18 AM, Eric Blake wrote:
>> On 05/01/2012 04:14 PM, Stefano Lattarini wrote:
>>> Starting from commit v1.11-662-g52246cc of XXX, "XXX", aclocal has
+* Bugs introduced by 1.11.3:
> +
> + - When given non-option arguments, aclocal rejects them, instead of
> +silently ignoring them.
perhaps to 1.11.3?
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
cit-skips.sh | 17 ++--
> t/self-check-me.tap|8 +-
> t/self-check-reexec.tap| 18 ++--
> t/self-check-sanity.sh |8 +-
> t/self-check-tap.sh | 16 ++--
> 14 files changed, 320 insertions(+), 151 deletions(-)
>
--
Eri
hen \
> + : config.status should return a string properly quited for eval; \
s/quited/quoted/
> + old_configure_flags=`$(srcdir)/config.status --config`; \
> + else \
> + old_configure_flags=""; \
> + fi; \
> + eval am__bootstrap_configure "$$old_configure_flags"
> + $(AM_V_REMAKE)$(MAKE) clean && $(MAKE) check TESTS=t/get-sysconf
The idea looks reasonable to me, although I just skimmed the patch
rather than closely reviewing how it all works.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
permanent solution,
by borrowing the same trick used by Autoconf. Make this @RELEASE_YEAR@,
which is set by an AC_SUBST'd string that auto-updates itself at
configure time, instead of manually changing it each time a year rolls
around.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
er you think will be easiest to
maintain over long-term merges; if our new branching policy makes it
possible to enforce good NEWS entries across both branches, then simpler
is reasonable.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
cies/dependencies/; s/such a/such/
> +## completeness would cause more issues than it would solve. See
> +## automake bug#11347.
> +$(generated_TESTS): $(srcdir)/gen-testsuite-part
> +$(srcdir)/t/testsuite-part.am: $(srcdir)/gen-testsuite-part Makefile.am
>
> # Stati
On 04/26/2012 05:12 AM, Stefano Lattarini wrote:
> Hi Eric, sorry for the delay.
>
> On 04/25/2012 01:25 AM, Eric Blake wrote:
>>
>> Actually, this appears to make _all_ the XFile uses work; all that
>> remains broken is places such as bin/autoupdate.in calling raw ope
orrect
building-block in the first place. Seems like an interesting solution.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 04/24/2012 05:17 PM, Stefano Lattarini wrote:
> Hi Eric, Russ.
>
> On 04/25/2012 01:08 AM, Eric Blake wrote:
>> On 04/24/2012 04:50 PM, Russ Allbery wrote:
>>> Eric Blake writes:
>>>
>>>> Help! I can't release autoconf 2.69 until I fig
On 04/24/2012 04:50 PM, Russ Allbery wrote:
> Eric Blake writes:
>
>> Help! I can't release autoconf 2.69 until I figure out how to work
>> around this patch. After updating to the latest shared files, as well
>> as applying this patch, I'm now stuck with
. I suspect that the
conversion to the 2-arg form is mishandling our idiom of '-' as standard
in/out.
From 6ee479858ab4a4c4054d6ee334adae4e38295e52 Mon Sep 17 00:00:00 2001
From: Eric Blake
Date: Tue, 24 Apr 2012 16:06:03 -0600
Subject: [PATCH] bin: replace older perl open_quote workaround with
On 03/05/2012 12:20 PM, Stefano Lattarini wrote:
> On 03/05/2012 02:18 PM, Eric Blake wrote:
>> On 03/04/2012 08:14 AM, Stefano Lattarini wrote:
>>> Now that we require Perl 5.6.2, we can drop the 'Automake::Struct'
>>> module, which was basically just a back
--
> 3 files changed, 3 insertions(+), 630 deletions(-)
> delete mode 100644 lib/Automake/Struct.pm
You are missing the corresponding tweak to cfg.mk to quit importing
Struct.pm from automake (that is, 'make fetch' must not revive the
file). ACK series with tha
the FSF sent me?
Questions like this are best handled through ass...@gnu.org; the legal
team at that alias is better equipped than the development team on this
list to deal with the ramifications. At this point, it's probably
better to drop automake-patches from cc when tracking the progress o
hing*, rather than to
> to the single empty string, as one would expect. This was causing
> a spurious failure in our testsuite when a shell suffering of this
> bug was used to run the test cases.
Yuck - this sounds like it should be documented in the autoconf manual.
Is it only shell fu
t
> eats away space that could be used by those command lines? Oh joy ...
Yes. Unlike on *ix systems, where argv and environ are independent
entities, Windows makes you deal with both limits at the same time, so
increasing the size of environ reduces the size permitted in argv.
--
Eric Blake e
hat if the script
_gets_ executed,...
> $ test -x foo.sh; echo $?
> 0
...and 'test -x' says it could be executed, in spite of the missing 'x'
bits, then the test will pass in spite of the brokenness of the 'x'
semantics on that file system.
> $ chmod a+x fo
road), nor does it require a Signed-off-by line on commits; but
at the same time, no one deletes a line from any commit pushed, even if
the line is "redundant" with the author.
>
> - Ralf Wildenhues used the "Signed-off-by" as well (bit I never
> asked him why);
by way of a
new standardized configure option for specifying the alternate package
name of the second installation, and then adding automake and/or
autoconf support for providing configure support for an alternate
package name, seems like it would be worthwhile for more than just grub.
--
Eric
ow those behaviors, I think I can ensure that my proposed test
to require a "working" 'test -x' as a pre-req of finding a sane shell
should still work for MSYS.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
e distcheck' intentionally checks that 'make dist'
from a read-only source tarball will accurately create a tarball. This
is a _feature_ of automake's 'make distcheck'. If you want to guarantee
that the generated tarball has certain permissions, then you, as the
pack
should today be portable to any non-museum system. Since we are at
> it, improve diagnostic in case of failure.
The autoconf manual still recommends:
Do not use @samp{test -x}, because 4.3BSD does not
have it.
Is this still an issue? Or should we be updating the autoconf manual?
--
Eric
On 02/21/2012 06:05 AM, Stefano Lattarini wrote:
> On 02/21/2012 01:39 PM, Eric Blake wrote:
>> On 02/21/2012 05:34 AM, Stefano Lattarini wrote:
>>> * NEWS: Get rid of form-feed characters (^L) throughout the file.
>>> Use separator lines instead (composed by 76
e).
Why?
I _like_ ^L as a separator - it is an easy character to search for.
Whereas lines of cause spurious hits when searching for '===' when
solving a merge conflict.
I'm not opposed to the change if you have a good reason, but I don't yet
see that good reason.
--
Er
), 19 deletions(-)
>
> -Automake also has three mailing lists:
> +Automake has also three mailing lists:
Drop this hunk; the original "also has" sounds better to a native speaker.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
in 48 hours or so if there is no objection by then.
Is there _any_ chance that there might be a distro out there that is
basing backported patches on top of branch-1-10? I'm a bit hesitant to
remove this particular branch, but I won't complain if I get outvoted.
--
Eric Blake ebl...
On 02/14/2012 05:10 AM, Stefano Lattarini wrote:
> Maybe we should aim for a cleaner and more general solution, and "resurrect"
> and extend the following patch by Eric Blake instead:
>
> <http://lists.gnu.org/archive/html/automake/2012-01/msg00011.html>
>
> B
nly be
easier to review, since by default, all NEWS merges should take all
entries from both branches.
Or maybe it's time to write a custom merge driver for NEWS, similar to
the custom merge file for ChangeLog?
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
back in the days when changelog was
version-controlled (rather than git _being_ the changelog).
I'm personally in favor of keeping the date, and keeping it updated to
the last action on the file, but also agree that it creates merge
conflicts any time development on the file diverges across branch
On 01/08/2012 02:19 AM, Stefano Lattarini wrote:
> The problem with 'dist-xz' was introduced in the merge commit
> `v1.11-1183-g72c8dcb', and the problem with 'dist-lzip' was
> introduced in the merge commit `xxx'
You may want to fix that xxx before p
1 - 100 of 196 matches
Mail list logo
