Hi!
Ok for maint, or should the example be as simple as it can possible get
even if portability is sacrificed?
Cheers,
Peter
>From 782f44dd4d3d42beb9d43ee0dd7cf46accc44731 Mon Sep 17 00:00:00 2001
From: Peter Rosin
Date: Thu, 5 Jan 2012 01:43:11 +0100
Subject: [PATCH] amhello: help compilers no
Stefano Lattarini skrev 2012-01-04 19:53:
> On 01/04/2012 07:48 PM, Peter Rosin wrote:
>> test defs: skip all tests when the lib requirement isn't fulfilled
>>
>> * tests/defs (lib): Use skip_all_ instead of skip_, in order to support
>> TAP-based test scripts.
>>
> Sounds good. Thanks!
Pushed to
On 01/04/2012 07:48 PM, Peter Rosin wrote:
> Thanks for the feedback, I can push it, do you have any issues with the
> below commit message?
>
> Cheers,
> Peter
>
> test defs: skip all tests when the lib requirement isn't fulfilled
>
> * tests/defs (lib): Use skip_all_ instead of skip_, in order
Stefano Lattarini skrev 2012-01-04 18:34:
> On 01/04/2012 03:57 PM, Peter Rosin wrote:
>> diff --git a/tests/defs b/tests/defs
>> index dbf0ff9..835788d 100644
>> --- a/tests/defs
>> +++ b/tests/defs
>> @@ -774,7 +774,8 @@ do
>># Attempting to create an empty archive will actually not
>>
On 01/04/2012 03:57 PM, Peter Rosin wrote:
> Hi!
>
> All other "required" tests on master bails out with skip_all_,
> shouldn't 'lib' do that too? Is this the result of a bad merge
> or something?
>
Yes (or more precisely, of a missed edit after a merge). It hasn't caused
any error until now bec
Hi Paul, thanks for the patch.
I've completed the git commit log as follows (mostly to abide to the
GCS):
* doc/automake.texi: Mention "Windows", not "Win32".
* lib/Automake/XFile.pm: Likewise.
* lib/ar-lib: Likewise.
* lib/compile: Likewise.
* tests/compile2.test: Likewise.
I've then
Hi Peter.
On 01/04/2012 04:06 PM, Peter Rosin wrote:
>> --- lib/compile.orig Wed Jan 4 13:46:01 2012
>> +++ lib/compile Wed Jan 4 13:14:43 2012
>> @@ -40,7 +40,7 @@
>>
>> # func_file_conv build_file lazy
>> # Convert a $build file to $host form and store it in $file
>> -# Currently only
Peter Rosin wrote:
> These two func_file_conv functions support Cygwin, so that should probably
> be 'Windows hosts' (i.e. w/o native) given your above description?
Oops, yes, you're right. So here, s/Win32/Windows/ is appropriate.
Bruno
On 01/04/12 05:37, Stefano Lattarini wrote:
> Care to fix those too?
Here's a revised version of Bruno's patch that
attempts to address all the issues that you raised.
>From ef5461d37207a965217e1b09c8ef257622f9d43c Mon Sep 17 00:00:00 2001
From: Paul Eggert
Date: Wed, 4 Jan 2012 07:51:07 -0800
S
Bruno Haible skrev 2012-01-04 14:00:
> Hi,
>
> Microsoft has renamed the Win32 API to "Windows API".[1]
> Also, some people (Paul Eggert) see a word of praise in the
> term "Win32".
>
> After some discussion on bug-gnulib, when talking about hosts/platforms,
> we find it best to talk about "nativ
Peter Rosin skrev 2012-01-04 15:41:
> Hi!
>
> All other "required" tests on master bails out with skip_all_,
> shouldn't 'lib' do that too? Is this the result of a bad merge
> or something?
Oh crap, that patch was destroyed (by 'less' I think). Here's
a better one.
diff --git a/tests/defs b/tes
Hi Stefano,
> > Here's a proposed patch for automake.
> >
> Thanks. I have some minor nits and qualms with the patch, which I hope
> you can address in a re-roll.
Was this meant as an explanation to your fellow Automake maintainers,
or to me personally? If you meant me personally:
I am not a re
Hi!
All other "required" tests on master bails out with skip_all_,
shouldn't 'lib' do that too? Is this the result of a bad merge
or something?
Cheers,
Peter
diff --git a/m4/amversion.m4 b/m4/amversion.m4
old mode 100644
new mode 100755
diff --git a/tests/defs b/tests/defs
index dbf0ff9..1d4e8c
On 01/04/2012 02:00 PM, Bruno Haible wrote:
> Hi,
>
Hi Bruno.
> Also, some people (Paul Eggert) see a word of praise in the
> term "Win32".
>
Sorry, but I don't find this notion worth of consideration.
> Microsoft has renamed the Win32 API to "Windows API".[1]
>
This is a much better argument in
Hi,
Microsoft has renamed the Win32 API to "Windows API".[1]
Also, some people (Paul Eggert) see a word of praise in the
term "Win32".
After some discussion on bug-gnulib, when talking about hosts/platforms,
we find it best to talk about "native Windows hosts" instead.
("Windows hosts" would incl
I will push this in a couple of days if there is not objection.
Regards,
Stefano
-*-*-*-
To declare prerequisites common to all the tests, we now prefer to
use the special `check_DATA' and `check_SCRIPTS' variables rather
than "lazy" dependency declaration like "$(TEST_LOGS): DEPS ...";
this b
commit 509348ecc96e7984f7630cc5f1300e7b174bb133
Merge: 5b13742 a6ccc2a
Author: Stefano Lattarini
AuthorDate: Wed Jan 4 10:26:07 2012 +0100
Commit: Stefano Lattarini
CommitDate: Wed Jan 4 10:26:07 2012 +0100
Merge branch 'maint'
* maint:
sync: auxiliary files from upstream
* lib/texinfo.tex: Synced from upstream, by "make fetch".
* lib/gitlog-to-changelog: Likewise.
* lib/config.guess: Likewise.
* lib/config.sub: Likewise.
---
lib/config.guess| 22 +++---
lib/config.sub | 13 +---
lib/gitlog-to-changelog | 38 --
lib/texinfo.tex
* Makefile.am (FETCHFILES): Also list 'gitlog-to-changelog'.
---
Makefile.am |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index b2cba62..8fe9c0f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -729,6 +729,7 @@ INSTALL \
config-ml.in \
config.gu
* Makefile.am (sc_tests_plain_make): Ensure to only match full
`make' words. Avoid false positive in `silent-nested-vars.test'.
---
Makefile.am |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index ed01bbb..b2cba62 100644
--- a/Makefile.am
+++ b
20 matches
Mail list logo
