Re: [PATCH] ylwrap: fix unusual indentation whitespace

2011-08-25 Thread Stefano Lattarini
On Thursday 25 August 2011, Stefano Lattarini wrote: > On Thursday 25 August 2011, Eric Blake wrote: > > Would you mind completing the merging then, since you've been more > > active on the yacc-work branch? > > > Of course... once I'm done fixing another botch-up of mine in maint :-( > Done no

[FYI] {maint} tests: list "forgotten" test script in TESTS

2011-08-25 Thread Stefano Lattarini
* tests/Makefile.am (TESTS): Also list ... * tests/java-empty-classpath.test: ... this test. Since we are at it, remove trailing whitespace from a couple of lines. --- ChangeLog |7 +++ tests/Makefile.am |1 + tests/Makefile.in |1

Re: [PATCH] ylwrap: fix unusual indentation whitespace

2011-08-25 Thread Stefano Lattarini
On Thursday 25 August 2011, Eric Blake wrote: > On 08/25/2011 12:56 PM, Stefano Lattarini wrote: > > Hi Eric, thanks for the patch. > > > > On Thursday 25 August 2011, Eric Blake wrote: > >> On 08/25/2011 12:41 PM, Eric Blake wrote: > >>> * lib/ylwrap: Convert to spaces. > >>> Reported by Karl Berr

Re: [PATCH] ylwrap: fix unusual indentation whitespace

2011-08-25 Thread Eric Blake
On 08/25/2011 12:56 PM, Stefano Lattarini wrote: Hi Eric, thanks for the patch. On Thursday 25 August 2011, Eric Blake wrote: On 08/25/2011 12:41 PM, Eric Blake wrote: * lib/ylwrap: Convert to spaces. Reported by Karl Berry. Signed-off-by: Eric Blake --- I'm assuming that getting rid of spac

Re: [PATCH] ylwrap: fix unusual indentation whitespace

2011-08-25 Thread Stefano Lattarini
Hi Eric, thanks for the patch. On Thursday 25 August 2011, Eric Blake wrote: > On 08/25/2011 12:41 PM, Eric Blake wrote: > > * lib/ylwrap: Convert to spaces. > > Reported by Karl Berry. > > > > Signed-off-by: Eric Blake > > --- > > > > I'm assuming that getting rid of space-tab is trivial enough t

Re: [PATCH] ylwrap: fix unusual indentation whitespace

2011-08-25 Thread Eric Blake
On 08/25/2011 12:41 PM, Eric Blake wrote: * lib/ylwrap: Convert to spaces. Reported by Karl Berry. Signed-off-by: Eric Blake --- I'm assuming that getting rid of space-tab is trivial enough to just push, so I'll apply this to maint, then merge into branch-1.11 and master. But only after first

[PATCH] ylwrap: fix unusual indentation whitespace

2011-08-25 Thread Eric Blake
* lib/ylwrap: Convert to spaces. Reported by Karl Berry. Signed-off-by: Eric Blake --- I'm assuming that getting rid of space-tab is trivial enough to just push, so I'll apply this to maint, then merge into branch-1.11 and master. ChangeLog |5 + lib/ylwrap | 28 ++--

[FYI] {test-protocols} coverage: more about escaping of TAP directives

2011-08-25 Thread Stefano Lattarini
* tests/tap-escape-directive.test: Make grepping of testsuite progress output slightly stricter. * tests/tap-escape-directive-2.test: New test (failing with the awk implementation of the TAP driver). * tests/Makefile.am (tap_with_common_setup_tests): Update. --- ChangeLog |

[FYI] {test-protocols} tap/awk: allow escaping of TAP directives

2011-08-25 Thread Stefano Lattarini
* lib/tap-driver.sh (setup_result_obj): Handle escaping of TAP directives in a way tat is (mostly) compatible by what is done by the TAP::Parser module. With this change, the tests `tap-escape-directive.test' and `tap-escape-directive-2.test' now also pass with the shell/awk implementation of the T

[FYI] {test-protocols} tap/perl: don't redirect perl warnings/errors to log files

2011-08-25 Thread Stefano Lattarini
With this change, the test `tap-driver-stderr.test' also passes with the perl implementation of the TAP driver. * lib/tap-driver.pl (start): Save the original stderr into the `OLDERR' file handle, and call ... (trap_perl_warnings_and_errors): ... this new function, trapping the `__WARN__' and `__D

[FYI] {test-protocols} tap: improve syncing between awk+shell and perl implementations

2011-08-25 Thread Stefano Lattarini
* lib/tap-driver.pl (stringify_test_result): Renamed ... (stringify_result_obj): ... to this. Break up a clause in the long "if/elsif/.../else" construct to avoid unaesthetic line breaks and to be more synced with the sibling function in `tap-driver.sh'. Rename the `$result', `$PASS' and `$FAIL'

[FYI] {test-protocols} tap/awk: remove obsolete "FIXME" comment

2011-08-25 Thread Stefano Lattarini
* lib/tap-driver.sh: Remove obsolete "FIXME" comment about our driver losing the exit status of the tested program; this issue has been solved in precedent commit `v1.11-1052-gd630a0d'. Fix an unrelated typo in comments since we are at it. --- ChangeLog |8 lib/tap-driver.sh

[FYI] {test-protocols} tap/awk: don't redirect awk stderr to log files

2011-08-25 Thread Stefano Lattarini
* lib/tap-driver.sh: Handle the file descriptors redirections more smartly, to avoid sending error messages from awk (about e.g. syntax or I/O errors) to the log files instead that to the console. * tests/tap-driver-stderr.test: New test, verifying the improved driver behaviour. Notice that this t

[FYI] {test-protocols} tap/perl: add copyright notice, version string, and emacs stuff

2011-08-25 Thread Stefano Lattarini
* lib/tap-driver.pl: Add proper copyright notice and bug reporting address. Remove obsolete heading comments. Add trailing comments for emacs w.r.t. code-formatting rules and automatic updating of the date-based script version saved into the `$VERSION' variable. ($VERSION): Define to the current