* lib/tap-driver.sh: Remove obsolete "FIXME" comment about our
driver losing the exit status of the tested program; this issue
has been solved in precedent commit `v1.11-1052-gd630a0d'. Fix
an unrelated typo in comments since we are at it.
---
ChangeLog | 8 ++++++++
lib/tap-driver.sh | 9 ++-------
2 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 7a161ac..2e8088a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2011-08-24 Stefano Lattarini <stefano.lattar...@gmail.com>
+
+ tap/awk: remove obsolete "FIXME" comment
+ * lib/tap-driver.sh: Remove obsolete "FIXME" comment about our
+ driver losing the exit status of the tested program; this issue
+ has been solved in precedent commit `v1.11-1052-gd630a0d'. Fix
+ an unrelated typo in comments since we are at it.
+
2011-08-22 Stefano Lattarini <stefano.lattar...@gmail.com>
testsuite: avoid spurious failure on Solaris
diff --git a/lib/tap-driver.sh b/lib/tap-driver.sh
index 1255662..bec914f 100755
--- a/lib/tap-driver.sh
+++ b/lib/tap-driver.sh
@@ -23,7 +23,7 @@
# bugs to <bug-autom...@gnu.org> or send patches to
# <automake-patches@gnu.org>.
-scriptversion=2011-08-21.21; # UTC
+scriptversion=2011-08-24.08; # UTC
# Make unconditional expansion of undefined variables an error. This
# helps a lot in preventing typo-related bugs.
@@ -116,11 +116,6 @@ else
fi
{
- # FIXME: this usage loses the test program exit status. We should
- # probably rewrite the awk script to use the
- # expression | getline [var]
- # idiom, which should allow us to obtain the final exit status from
- # <expression> when closing it.
{ test $merge -eq 0 || exec 2>&1; "$@"; echo $?; } \
| LC_ALL=C ${AM_TAP_AWK-awk} \
-v me="$me" \
@@ -133,7 +128,7 @@ fi
-v comments="$comments" \
-v diag_string="$diag_string" \
'
-# FIXME: the usages of "cat >&3" below could be optimized whne using
+# FIXME: the usages of "cat >&3" below could be optimized when using
# FIXME: GNU awk, and/on on systems that supports /dev/fd/.
# Implementation note: in what follows, `result_obj` will be an
--
1.7.2.3
