Re: Automake patches for custom test drivers' support break coreutils testsuite

Stefano Lattarini wrote: > [Adding bug-coreutils] > > Reference: > > > On Friday 17 June 2011, Ralf Wildenhues wrote: >> I generally like the direction this is taking. The point of best >> separation between which code goe

Re: [PATCH] check: don't use multi-line coloring for the report

Hi Bert, and thanks again for your patch. I have some minor observations and objections below (please do not take them as a belittling of your work; they are either constructive criticism, or requests for cosmetic changes mandated by the GNU coding standards). I hope you have time and will to addr

Automake patches for custom test drivers' support break coreutils testsuite (was: Re: [PATCH v4 1/3] parallel-tests: add auxiliary script 'pt-driver', refactor)

[Adding bug-coreutils] Reference: On Friday 17 June 2011, Ralf Wildenhues wrote: > I generally like the direction this is taking. The point of best > separation between which code goes into Makefile.in and which into > t

[PATCH] check: don't use multi-line coloring for the report

less -R can't handle multi-line coloring as it is done for the check reports of the serial and parallel testsuite, because of performance reasons. Thus, color each line of the check report by its own. --- ChangeLog |9 + THANKS |1 + lib/am/check.am | 40 ++

Re: [PATCH] check: don't use multi-line coloring for the report

Hi, On Fri, Jun 17, 2011 at 17:12, Stefano Lattarini wrote: > Hi Bert, and thanks for persiting on this. only for today, I'm in vacation for the next two weeks ;-) But I try to post a patch today. > You could avoid the use of printf above by using the "automatic concatenation" > feature of awk:

Re: [PATCH v4 3/3] parallel-tests: allow each test to have multiple results

On Friday 17 June 2011, Stefano Lattarini wrote: > And attached is what I've squashed in. > > Regards, > Stefano > And this further squash-in is required to fix a spurious failure due to the rename pt-driver -> test-driver. Sorry for the noise, Stefano -*-*- diff --git a/ChangeLog b/Chan

Re: [PATCH v4 3/3] parallel-tests: allow each test to have multiple results

[Reporting my whole previous answer] On Friday 17 June 2011, Stefano Lattarini wrote: > On Friday 17 June 2011, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Thu, Jun 16, 2011 at 10:03:59AM CEST: > > > With this change, we improve the code creating the `test-suite.log' > > > global log a

Re: [PATCH] check: don't use multi-line coloring for the report

Hi Bert, and thanks for persiting on this. On Friday 17 June 2011, Bert Wesarg wrote: > On Thu, Jun 16, 2011 at 22:00, Ralf Wildenhues wrote: > > Hello, > > > > * Bert Wesarg wrote on Thu, Jun 16, 2011 at 08:19:23PM CEST: > >> the parallel part is a little trickier. Because the line printing is >

Re: [PATCH v4 3/3] parallel-tests: allow each test to have multiple results

On Friday 17 June 2011, Stefano Lattarini wrote: > On Friday 17 June 2011, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Thu, Jun 16, 2011 at 10:03:59AM CEST: > > > With this change, we improve the code creating the `test-suite.log' > > > global log and the console testsuite summary to ma

Re: [PATCH v4 1/3] parallel-tests: add auxiliary script 'pt-driver', refactor

Oops, I forgot an instance of "pt-driver" in the documentation. Consider the following squashed-in too: diff --git a/doc/automake.texi b/doc/automake.texi index 0e2fb9b..359e1d5 100644 --- a/doc/automake.texi +++ b/doc/automake.texi @@ -2931,7 +2931,7 @@ Automake will look for various helper

Re: [PATCH v4 2/3] parallel-tests: allow custom driver scripts

On Thursday 16 June 2011, Stefano Lattarini wrote: > * doc/automake.texi (Custom Test Drivers): New section and node. > (Overview of Custom Test Drivers Support): New subsection. > (Declaring Custom Test Drivers in @file{Makefile.am}): Likewise. > (APIs for Custom Test Drivers): New subsection, sti

Re: [PATCH v4 1/3] parallel-tests: add auxiliary script 'pt-driver', refactor

On Friday 17 June 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Thu, Jun 16, 2011 at 10:00:31AM CEST: > > This refactoring should cause no API of functionality change, > > and is meant only to simplify the future implementation of TAP > > and SubUnit testsuite drivers. More precisely

Re: [PATCH v4 3/3] parallel-tests: allow each test to have multiple results

On Friday 17 June 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Thu, Jun 16, 2011 at 10:03:59AM CEST: > > With this change, we improve the code creating the `test-suite.log' > > global log and the console testsuite summary to make it able to > > grasp multiple results per test scr

Re: [PATCH] check: don't use multi-line coloring for the report

On Thu, Jun 16, 2011 at 22:00, Ralf Wildenhues wrote: > Hello, > > * Bert Wesarg wrote on Thu, Jun 16, 2011 at 08:19:23PM CEST: >> the parallel part is a little trickier. Because the line printing is >> done by awk. I would like to know, whether it is portable to use the >> printf function of awk.