Re: local perl $_ variable is not portable

2011-01-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Jan 17, 2011 at 01:39:29AM CET: > On Sunday 16 January 2011, Ralf Wildenhues wrote: > >foreach my $h (@list) > > { > > - my $_ = $h->{'option'}; > > + $_ = $h->{'option'}; > > > What about using a "good ol' local" here? E.g.: > local $_ = $h-

Re: local perl $_ variable is not portable

2011-01-16 Thread Stefano Lattarini
On Sunday 16 January 2011, Ralf Wildenhues wrote: > On the AIX 5.1 I test on, perl 5.0.8 fails over a recent Options.pm > change: > > $ ./tests/automake-1.11a --help > Can't use global $_ in "my" at > /tmp/build-powerpc-ibm-aix5.2.0.0/../automake/lib/Automake/Options.pm line > 263, near "my $_ "

local perl $_ variable is not portable

2011-01-16 Thread Ralf Wildenhues
On the AIX 5.1 I test on, perl 5.0.8 fails over a recent Options.pm change: $ ./tests/automake-1.11a --help Can't use global $_ in "my" at /tmp/build-powerpc-ibm-aix5.2.0.0/../automake/lib/Automake/Options.pm line 263, near "my $_ " Compilation failed in require at /tmp/build-powerpc-ibm-aix5.2.

tests: allow double-colon spy.test to work with HP-UX make.

2011-01-16 Thread Ralf Wildenhues
Now that we know that what bothers HP-UX make is same-timestamp prereqs, we can fix the age-old spurious spy.test failures for good, and even add a test for a target out of date wrt. several rules. Yay! This means that, at least in theory, we could use double-colon rules for something eventually,

Re: [PATCH] {maint} tests: remove useless requirements from cond36.test

2011-01-16 Thread Stefano Lattarini
On Sunday 16 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Sun, Jan 16, 2011 at 07:27:40PM CET: > > OK for maint? I'll push by tomorrow if there are no objections. > > OK. > > Thanks, > Ralf > > > tests: remove useless requirements from cond36.test > > > > * tests/cond36.

Re: [PATCH] {maint} tests: remove useless requirements from cond36.test

2011-01-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Jan 16, 2011 at 07:27:40PM CET: > OK for maint? I'll push by tomorrow if there are no objections. OK. Thanks, Ralf > tests: remove useless requirements from cond36.test > > * tests/cond36.test ($required): Remove, as the test never tries > to run lex, yacc, or

[PATCH] {maint} tests: remove useless requirements from cond36.test

2011-01-16 Thread Stefano Lattarini
OK for maint? I'll push by tomorrow if there are no objections. Regards, Stefano -*-*- tests: remove useless requirements from cond36.test * tests/cond36.test ($required): Remove, as the test never tries to run lex, yacc, or the C compiler. Since we are at it, add a trailing `:' command. --

Re: parallel-tests: work around Tru64/OSF 5.1 sh read bugs.

2011-01-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Jan 16, 2011 at 06:31:21PM CET: > > Thanks for writing the test case, and good job, it exposes the first > > read issue. > > > Oh, I thought it exposed also the second one. After all, if the > shell bails out on a failed read, I'd expect the `$(TEST_SUITE_LOG)' >

Re: parallel-tests: work around Tru64/OSF 5.1 sh read bugs.

2011-01-16 Thread Stefano Lattarini
On Sunday 16 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Sun, Jan 16, 2011 at 02:37:55PM CET: > > On Sunday 16 January 2011, Ralf Wildenhues wrote: > > > http://autobuild.josefsson.org/automake/log-20110115074814053.txt > > > > This is due to this portability issue: > >

Re: Avoid VPATH-related distcheck failures with non-GNU make

2011-01-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Jan 16, 2011 at 04:39:50PM CET: > On Sunday 16 January 2011, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Sat, Jan 15, 2011 at 04:50:31PM CET: > > > Hmm... To me, this sounds an awful lot like sweeping the dirt under > > > the rug. > > > > OK, so here's

Re: parallel-tests: work around Tru64/OSF 5.1 sh read bugs.

2011-01-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Jan 16, 2011 at 02:37:55PM CET: > On Sunday 16 January 2011, Ralf Wildenhues wrote: > > http://autobuild.josefsson.org/automake/log-20110115074814053.txt > > This is due to this portability issue: > > http://thread.gmane.org/gmane.comp.sysutils.autoconf.patche

Re: [PATCH] {maint} cosmetics: cater for vim syntax highlight in distdir.am

2011-01-16 Thread Stefano Lattarini
On Sunday 16 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Sun, Jan 16, 2011 at 04:55:43PM CET: > > I'm not sure if it is acceptable to submit a patch aimed at working > > around limits and warts of an editor's syntax highlighting, but I > > guess I'll find out very soon :-) >

Re: [PATCH] {maint} cosmetics: cater for vim syntax highlight in distdir.am

2011-01-16 Thread Stefano Lattarini
On Sunday 16 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Sun, Jan 16, 2011 at 04:55:43PM CET: > > I'm not sure if it is acceptable to submit a patch aimed at working > > around limits and warts of an editor's syntax highlighting, but I > > guess I'll find out very soon :-) >

Re: [PATCH] {maint} cosmetics: cater for vim syntax highlight in distdir.am

2011-01-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Jan 16, 2011 at 04:55:43PM CET: > I'm not sure if it is acceptable to submit a patch aimed at working > around limits and warts of an editor's syntax highlighting, but I > guess I'll find out very soon :-) It would be ok if it were a single instance or a ouple, an

Re: Avoid VPATH-related distcheck failures with non-GNU make

2011-01-16 Thread Bob Friesenhahn
On Sun, 16 Jan 2011, Ralf Wildenhues wrote: I reject the notion of disallowing VPATH builds with GNU make only. The reason is simple: I make good use of this feature every time I test the Automake package with some non-GNU make (I build several platforms off of one tree shared via NFS). It woul

[PATCH] {maint} cosmetics: cater for vim syntax highlight in distdir.am

2011-01-16 Thread Stefano Lattarini
Hello automakers. I'm not sure if it is acceptable to submit a patch aimed at working around limits and warts of an editor's syntax highlighting, but I guess I'll find out very soon :-) So, OK for maint, or only for /dev/null? Thanks, Stefano -*-*- cosmetics: cater for vim syntax highlight i

Re: tests-init branch

2011-01-16 Thread Stefano Lattarini
On Sunday 16 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Sun, Jan 16, 2011 at 04:11:04PM CET: > > I've just merged the tests-init branch into master, and > > pushed. > > Thanks. > > > At this point, that branch has IMHO pretty much exhausted > > its usefulness, and could b

Re: Avoid VPATH-related distcheck failures with non-GNU make

2011-01-16 Thread Stefano Lattarini
On Sunday 16 January 2011, Ralf Wildenhues wrote: > Hello Stefano, > > * Stefano Lattarini wrote on Sat, Jan 15, 2011 at 04:50:31PM CET: > > On Saturday 15 January 2011, Ralf Wildenhues wrote: > > > ensure_distcheck_ () > > > { > > > if $MAKE --version -v | grep GNU; then > > > $MAKE distche

Re: tests-init branch

2011-01-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Jan 16, 2011 at 04:11:04PM CET: > I've just merged the tests-init branch into master, and > pushed. Thanks. > At this point, that branch has IMHO pretty much exhausted > its usefulness, and could be removed. Future non-obvious > testsuite work could be done in m

tests-init branch

2011-01-16 Thread Stefano Lattarini
Hello automakers. I've just merged the tests-init branch into master, and pushed. At this point, that branch has IMHO pretty much exhausted its usefulness, and could be removed. Future non-obvious testsuite work could be done in more short lived, purpose oriented branches. WDYT? Regards, Ste

[PATCH] {maint} tests: new subroutines for test skipping/failing

2011-01-16 Thread Stefano Lattarini
Hello automakers. This patch stemmed from this discussion: I'd like to have the patch applied to maint, to make eventual integration of new tests easier. But the follow-up patches converting the testsuite to the use of s

Re: bug#7833: automake uses two different values for DejaGNU srcdir

2011-01-16 Thread Stefano Lattarini
Hello Ralf, and sorry for the late reply. On Friday 14 January 2011, Ralf Wildenhues wrote: > * Ian Lance Taylor wrote on Thu, Jan 13, 2011 at 06:29:39PM CET: > > Ralf Wildenhues writes: > > > > > Am I correct in assuming that it is hopeless to assume GCC will work > > > when either values are re

Re: parallel-tests: work around Tru64/OSF 5.1 sh read bugs.

2011-01-16 Thread Stefano Lattarini
On Sunday 16 January 2011, Ralf Wildenhues wrote: > Quoting: > http://autobuild.josefsson.org/automake/log-20110115074814053.txt > > | FAIL: parallel-tests9.test (exit: 1) > | > | > | > /tmp/am/build-alphaev67-dec-osf5.1/tests:/tmp/local/alphaev67-dec-osf

tests: avoid failing command substitution in errexit mode.

2011-01-16 Thread Ralf Wildenhues
Quoting http://autobuild.josefsson.org/automake/log-20110115074814053.txt | FAIL: vartypos.test (exit: 1) | = | | /tmp/am/build-alphaev67-dec-osf5.1/tests:/tmp/local/alphaev67-dec-osf5.1/bin:/tmp/bin:/bin:/usr/bin:/sbin:/usr/sbin:/usr/opt/svr4/bin:/etc:/usr/etc:/u

parallel-tests: work around Tru64/OSF 5.1 sh read bugs.

2011-01-16 Thread Ralf Wildenhues
Quoting: http://autobuild.josefsson.org/automake/log-20110115074814053.txt | FAIL: parallel-tests9.test (exit: 1) | | | /tmp/am/build-alphaev67-dec-osf5.1/tests:/tmp/local/alphaev67-dec-osf5.1/bin:/tmp/bin:/bin:/usr/bin:/sbin:/usr/sbin:/usr/opt/svr4/bin:/

Fix parallel-tests.test failure with HP-UX make

2011-01-16 Thread Ralf Wildenhues
Now that we know HP-UX make updates files with the same time stamp as their prerequisites, it is obvious how to fix the long-standing parallel-tests.test failure. Pushing to maint as below. Cheers, Ralf Fix parallel-tests.test failure with HP-UX make. * tests/parallel-tests.test: Sl

Re: tests: avoid new failures due to nonexistent makeinfo.

2011-01-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Jan 16, 2011 at 12:05:33PM CET: > I have serious doubts about this patch ... > > On Sunday 16 January 2011, Ralf Wildenhues wrote: > > http://hydra.nixos.org/build/858836/log/raw and other logs show new > > testsuite failures of txinfo.test and txinfo8.test: > >

Re: tests: avoid new failures due to nonexistent makeinfo.

2011-01-16 Thread Stefano Lattarini
Hello Ralf. I have serious doubts about this patch ... On Sunday 16 January 2011, Ralf Wildenhues wrote: > http://hydra.nixos.org/build/858836/log/raw and other logs show new > testsuite failures of txinfo.test and txinfo8.test: > > | if /bin/sh > /tmp/nix-build-nc6n3czfw0njkp2962fmqhcyj4p20fmp

tests: avoid new failures due to nonexistent makeinfo.

2011-01-16 Thread Ralf Wildenhues
http://hydra.nixos.org/build/858836/log/raw and other logs show new testsuite failures of txinfo.test and txinfo8.test: | if /bin/sh /tmp/nix-build-nc6n3czfw0njkp2962fmqhcyj4p20fmp-automake-1.11a.drv-0/automake-1.11a/tests/txinfo.dir/missing --run makeinfo -I . \ | -o textutils.info textutils

Re: Avoid VPATH-related distcheck failures with non-GNU make

2011-01-16 Thread Ralf Wildenhues
Hello Stefano, * Stefano Lattarini wrote on Sat, Jan 15, 2011 at 04:50:31PM CET: > On Saturday 15 January 2011, Ralf Wildenhues wrote: > > ensure_distcheck_ () > > { > > if $MAKE --version -v | grep GNU; then > > $MAKE distcheck > > else > > : > > fi > > } > Hmm... To me, this sound