* Stefano Lattarini wrote on Sun, Jan 16, 2011 at 04:55:43PM CET: > I'm not sure if it is acceptable to submit a patch aimed at working > around limits and warts of an editor's syntax highlighting, but I > guess I'll find out very soon :-)
It would be ok if it were a single instance or a ouple, and a hard-to-fix bug in automake.vim; however, git grep "##.*'" -- \*.am shows me 195 such instances, and vim lib/am/distdir.am :set ft shows me the file type is detected as elf, not automake, and :setf automake fixes highlighting. > So, OK for maint, or only for /dev/null? The patch is not ok as it is. Preferably this should be fixed in upstream $VIM/filetype.vim, and only if that is not possible, we can consider adding Vim-specific modelines to our *.am files (so Vi is not impacted). Are you familiar enough with vim scripting to suggest a patch? Otherwise I can look at filetype.vim some time later. Thanks, Ralf > cosmetics: cater for vim syntax highlight in distdir.am > > * lib/am/distdir.am (distdir): Avoid using single quotes in > automake comments embedded in a shell command substitution, > as that might confuse vim (7.2) syntax highlighting.
