This is proably the most important patch of the series, and
surely the most complex one. A review on this is definitely
advisable.
-*-*-*-
Tests defs: move static definitions in a new file `minidefs'.
The new file is designed to be idempotent w.r.t. mutiple inclusions,
and this will help us to
* tests/defs.in ($top_testsbuilddir): New variable, initialized
with the value AC_SUBST'ed from @abs_top_build...@. Mostly for
completeness and consistency with $testsrcdir and $top_testsrcdir.
---
ChangeLog |5 +
tests/defs.in |1 +
2 files changed, 6 insertions(+), 0 deletions(-
* tests/defs.in ($testsbuilddir): Initialize "statically"
with the value AC_SUBST'ed from @abs_builddir@, rather than
"dinamically" with the value returned by `pwd`.
Add sanity check on $testsbuilddir, similar to those on
$testsrcdir and $top_testsrcdir.
---
ChangeLog |7 +++
tests/def
* tests/defs.in: Printing the message "=== Running test $0" at
the beginning of each tests made sense when Automake used the old
test-driver, which sent all the output directly to stdout/stderr.
Now that the parallel test-driver is used, which saves output of
each test in its correspoding log file,
* tests/defs.in: Rename $curdir to $testbuildir, for clarity and
consistency with $testsrcdir and $top_testsrcdir.
---
ChangeLog |4
tests/defs.in | 14 +++---
2 files changed, 11 insertions(+), 7 deletions(-)
From ddc690b22264d5c6213ea89ef451c0c2bdec02c0 Mon Sep 17 00:00:00
* tests/defs.in: We already save the value of `pwd` in $curdir
early in the file, so there no need to recalculate it later, when
the current working directory is not changed.
---
ChangeLog |5 +
tests/defs.in |6 +++---
2 files changed, 8 insertions(+), 3 deletions(-)
From 6369166
This is basically just a reordering patch, which should organize the
code in `tests/defs.in' in a clearer and more rational way.
* tests/defs.in: Reordered various snippets of code in a clearer
way. Improved a couple of error messages, by reporting the test
name in them. Some comments added.
---
Hello automakers.
On Wednesday 08 September 2010, Stefano Lattarini wrote:
> Stefano Lattarini (5):
> Tests defs: various reorderings, some improvements.
> Tests defs: prefer "$curdir" over "`pwd`", where possible.
> Tests defs: rename $curdir -> $testbuilddir
> Tests defs: do not print me
On Sunday 07 November 2010, Ralf Wildenhues wrote:
> Hello Stefano, Andy,
>
> * Stefano Lattarini wrote on Sat, Nov 06, 2010 at 06:10:44PM CET:
> > On Friday 05 November 2010, Stefano Lattarini wrote:
> > > I can confirm the bug with latest automake (from git master), with
> > > a much-reduced mi
* Stefano Lattarini wrote on Fri, Nov 05, 2010 at 09:21:28PM CET:
> Nonetheless, there was still a potential bug (introduced by the merge)
> lurking in there, which didn't manifest itself because, by sheer luck,
> the Automake parallel test driver worked around it (by exporting
> "srcdir=$(srcdir)
Hello Stefano, Andy,
* Stefano Lattarini wrote on Sat, Nov 06, 2010 at 06:10:44PM CET:
> On Friday 05 November 2010, Stefano Lattarini wrote:
> > I can confirm the bug with latest automake (from git master), with
> > a much-reduced minimal testcase (see attachment).
> >
> > I still haven't looke
* Stefano Lattarini wrote on Sun, Nov 07, 2010 at 11:44:44AM CET:
> On Sunday 07 November 2010, Ralf Wildenhues wrote:
> > The test might not ever have made it to revision control,
> In this case I don't see any problem, no?
Unless it's in a personal git clone only
(not likely with existing histor
On Sunday 07 November 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sun, Nov 07, 2010 at 11:18:49AM CET:
> > On Sunday 07 November 2010, Ralf Wildenhues wrote:
> > > * Stefano Lattarini wrote on Mon, Sep 13, 2010 at 11:22:37AM CEST:
>
> > > > * tests/ctarget1.test: Renamed ...
> > >
* Stefano Lattarini wrote on Sun, Nov 07, 2010 at 11:18:49AM CET:
> On Sunday 07 November 2010, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Mon, Sep 13, 2010 at 11:22:37AM CEST:
> > > * tests/ctarget1.test: Renamed ...
> >
> > Please don't rename tests unless for a very good reason,
>
On Sunday 07 November 2010, Ralf Wildenhues wrote:
> Hi Stefano,
>
> * Stefano Lattarini wrote on Mon, Sep 13, 2010 at 11:22:37AM CEST:
> > I updated the patch slighty (see test `depdist.test') to follow the
> > emerging principle of preferring "semantic" tests to "grepping" tests
> > in the Auto
* Stefano Lattarini wrote on Sat, Nov 06, 2010 at 08:23:30PM CET:
> On Saturday 06 November 2010, Stefano Lattarini wrote:
> > On Saturday 06 November 2010, Ralf Wildenhues wrote:
> > > * Stefano Lattarini wrote on Sat, Nov 06, 2010 at 05:52:57PM CET:
> > > > Hi Ralf, I've just spotted a bug in the
Hi Stefano,
* Stefano Lattarini wrote on Mon, Sep 13, 2010 at 11:22:37AM CEST:
> I updated the patch slighty (see test `depdist.test') to follow the
> emerging principle of preferring "semantic" tests to "grepping" tests
> in the Automake testsuite.
OK with nits addressed.
and in another mail:
17 matches
Mail list logo
