On Sunday 07 November 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Sun, Nov 07, 2010 at 11:18:49AM CET: > > On Sunday 07 November 2010, Ralf Wildenhues wrote: > > > * Stefano Lattarini wrote on Mon, Sep 13, 2010 at 11:22:37AM CEST: > > > > > * tests/ctarget1.test: Renamed ... > > > > > > Please don't rename tests unless for a very good reason, > > The good reason is IMHO that the name `ctarget1.test' is misleading > > w.r.t. the testcase's content. > > Hmm, well, maybe. > > > > and please don't reuse names from tests that have been removed. > > I didn't (we had alredy agreed that this would be bad practice); to > > verify that I'm speaking truth, try: > > $ git lgl master -- tests/cond1.test > > There should be no output (works for me). > > The test might not ever have made it to revision control, In this case I don't see any problem, no? > or it might have been in a non-merged branch only > (so use --all to look). Ah, didn't think of that, sorry. Luckily, even with "git log --all", the only menstion of `tests/cond1.test' is in my temporary branch. > In case of doubt, at least use a name not likely to have been > used before. Anyway cond1 also hints me that this is a very > old test. And it is (ctarget1.test was created in February 2001) > > > So, ok to proceed with the rename? > > Please use a new name if you must. I used the new name `cond-basic.test' (again, "git log --all" tells me that it is safe).
Regards, Stefano
