At Sunday 08 August 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Wed, Jul 14, 2010 at 03:35:11PM CEST:
> > Modernize, improve and extend tests `pr*.test'.
>
> There is lots of noise in this patch. I'm close to saying no to it
> for that reason, but there is just enough improvement
* Ralf Wildenhues wrote on Sat, Aug 07, 2010 at 08:03:56AM CEST:
> Darn, we need another name: 'archive' is likely too common when automake
> is going to put all files with that name in the distribution of each
> package using Automake. No need to send another patch, but any other
> good suggestio
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 03:11:13PM CEST:
> At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > and I'm sorry there is such a high review delay.
> Well, I assume this is not done on purpose (right? ;-), so don't worry.
That depends on how you interpret it, I guess. Tests
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 07:09:46PM CEST:
> At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 06:22:00PM CEST:
> > > Exactly! So:
> > > foo() { foo_result=`sed ...`; }
> > > foo; bar=$foo_result;
> > >
> > > instead
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 07:42:39PM CEST:
> > The rest seems good for maint, thanks.
> BTW, the patch was against master, and while rebasing it I saw (well,
> a merge conflict made me see) that I could backport some extra checks
> in condinc2.test from master to maint. I
At Sunday 08 August 2010, Ralf Wildenhues wrote:
>
> > --- a/tests/condd.test
> > +++ b/tests/condd.test
> >
> > @@ -64,7 +64,9 @@ mkdir foo bar
> >
> > $ACLOCAL
> > $AUTOCONF
> >
> > -grep "meaningless;characters" configure && Exit 1
> > +$FGREP "meaningless;characters" configure && Exit 1
>
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 07:09:46PM CEST:
> > At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > > * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 06:22:00PM
CEST:
> > > > Exactly! So:
> > > > foo() { foo_result=`sed
Hallo Ralf,
On 7 Aug 2010, at 13:03, Ralf Wildenhues wrote:
> Darn, we need another name: 'archive' is likely too common when automake
> is going to put all files with that name in the distribution of each
> package using Automake. No need to send another patch, but any other
> good suggestions t
Den 2010-08-07 08:03 skrev Ralf Wildenhues:
Darn, we need another name: 'archive' is likely too common when automake
is going to put all files with that name in the distribution of each
package using Automake. No need to send another patch, but any other
good suggestions that fit in with the exi
[ the gnu list server seems down ATM; expect delays ]
Hi Stefano,
* Stefano Lattarini wrote on Wed, Jul 28, 2010 at 11:07:20AM CEST:
> At Wednesday 28 July 2010, Ralf Wildenhues wrote:
> > But even then, when developing Automake you will need to be extra
> > careful to never let autoconf be invok
* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 01:45:34PM CEST:
> * tests/ar.test: Add trailing `:' command.
> * tests/ar2.test: Likewise, and make grepping of generated
> Makefile.in stricter.
OK for maint, thanks!
Ralf
* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 03:35:11PM CEST:
> Modernize, improve and extend tests `pr*.test'.
>
> * tests/pr2.test: Add trailing `:' command.
> * tests/pr229.test: Likewise.
> * tests/pr401.test: Likewise.
> * tests/pr401b.test: Likewise.
> * tests/pr401c.test: Likewise.
> *
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 06:22:00PM CEST:
> Exactly! So:
> foo() { foo_result=`sed ...`; }
> foo; bar=$foo_result;
> instead of:
> foo() { sed ...; }
> bar=`foo`
> Where is the significant improvement?
Two forks vs. one: the latter still forks right before exec'ing
Hi Stefano,
* Stefano Lattarini wrote on Sun, Jun 27, 2010 at 06:14:41PM CEST:
> More testsuite tweakings. But this patch also contains some "real"
> improvements and useful extensions IMO.
OK with nits below addressed. If I'm appearing too grumpy, then I'm
sorry about that, so let me tell you
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> Except this would have been caught by "make check" already, so it
> doesn't count as an argument in favor of that patch, right? ;-)
But "make check" is slooow on my machine, so when I change just a
couple of test script I re-test them doing:
$
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:44:32PM CEST:
> > At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > > > -$FGREP 'generic/a.$(OBJEXT)' Makefile.in
> > > > +grep '^generic/a\.\$(OBJEXT):' Makefile.in
> > >
> > > Some day I'll
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 02:31:55PM CEST:
> At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Wed, Jul 14, 2010 at 01:36:57PM CEST:
> > > * tests/all.test: Run aclocal only once. Minor cosmetic changes.
> > > Move checks that several *-local
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:09:52PM CEST:
> > I squashed the following into the first patch:
> >
> > It's OK for you?
>
> Sure.
>
> > > > (BTW, if my understanding is correct, this would make a nice
> > > > addition to H
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 03:11:13PM CEST:
> > At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > > and I'm sorry there is such a high review delay.
> >
> > Well, I assume this is not done on purpose (right? ;-), so don't
And since we are at it, I'd like to ping this patch too.
It seems to me quite more useful that the "tweaking" patches we are
dealing with today.
Thanks,
Stefano
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:53:21PM CEST:
> At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > Fine with me. If you have all your patches in branches
> Yes, a branch for every patch (series).
> > or otherwise ordered, you can also just wait until I'm done
> > reviewing a
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 04:06:32PM CEST:
> > At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > > ok with it if you also add more meaningful descriptions to the
> > > tests, say, the PR descriptions.
> >
> > I'd love to
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 01:04:14PM CEST:
> At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Wed, Jul 14, 2010 at 01:16:28PM CEST:
> > > Remove a couple of obsoleted tests.
> > >
> > > * tests/fpinstall.test: Removed.
> > > * tests/fpinst2.
* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 02:19:20PM CEST:
> * tests/asm.test: Use configure.in stub generated by ./defs,
> and avoid obsoleted autoconf constructs. Make grepping of
> Automake stderr stricter. Do not create useless source file.
> Improve verbose messages. Minor cosmetic
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> Well, if it helps you, there is no need to maintain a linear
> history in the maint branch. You can also just merge your (fixed)
> patches from the branches where you have them, that is fine with
> me as well. No need to rebase or cherry-pick the
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 05:35:57PM CEST:
> I'm just saying that when we'll write the `extract_makefile_deps'
> function, it shouldn't bother with preserving tabs and backslashes;
Well, it should deal with them correctly, yes.
> on the other hand, it should actively norm
This topic is actually better discussed when the list server is up
again, and on the automake@ list, so others can chime in, too.
So just a couple of quick notes for now, and I hope to write more
about the general topic soonish:
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 03:59:34PM CEST:
>
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 05:48:58PM CEST:
> At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 05:35:57PM CEST:
> > > foo=`extract_makefile_deps tgt2 Makefile`; echo x"$foo"x
> > More or less, yes. I'd avoid the comman
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> This topic is actually better discussed when the list server is up
> again, and on the automake@ list, so others can chime in, too.
Agreed.
Just one thing...
> > 2. Automake, in its current incarnation, is mostly
> > feature-complete IMHO
>
> I
At Sunday 08 August 2010, Ralf Wildenhues wrote:
>
> This one needs fixes.
>
> > --- a/tests/depcomp2.test
> > +++ b/tests/depcomp2.test
> > @@ -43,11 +43,12 @@ END
> >
> > : > subdir/foo.c
> >
> > # Ignore user CFLAGS.
> >
> > -CFLAGS=
> > -export CFLAGS
> > +unset CFLAGS
>
> Unsetting a
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 06:06:04PM CEST:
> > At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > > No. You save a fork with
> > >
> > > foo ()
> > > {
> > >
> > > ...
> > > foo_result=bar
> > >
> > >
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Wed, Jul 14, 2010 at 01:36:57PM CEST:
> > * tests/all.test: Run aclocal only once. Minor cosmetic changes.
> > Move checks that several *-local's in a single rule work ...
>
> This sentence does not make sense to me.
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> Hi Stefano,
>
> * Stefano Lattarini wrote on Sun, Jun 27, 2010 at 06:14:41PM CEST:
> > More testsuite tweakings. But this patch also contains some
> > "real" improvements and useful extensions IMO.
>
> OK with nits below addressed. If I'm appea
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Wed, Jul 14, 2010 at 02:19:20PM CEST:
> > * tests/asm.test: Use configure.in stub generated by ./defs,
> > and avoid obsoleted autoconf constructs. Make grepping of
> > Automake stderr stricter. Do not create useless
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 04:06:32PM CEST:
> At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > ok with it if you also add more meaningful descriptions to the
> > tests, say, the PR descriptions.
> I'd love to do that (maybe as a separate patch to be applied *before*
> t
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Thu, Aug 05, 2010 at 01:54:20PM CEST:
> > Ping on this? It seems to me that most issues with this patch
> > had already been solved, so it's probably a pity to let it
> > bitrotting here...
>
> Well, I'd prefer the ex
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 04:38:08PM CEST:
> At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Thu, Aug 05, 2010 at 01:54:20PM CEST:
> > > Ping on this? It seems to me that most issues with this patch
> > > had already been solved, so it's pr
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > > Well, I'd prefer the extract_dependencies script approach
> >
> > I like the idea, too, but as I said I'd prefer to leave for a
> > later patch.
>
> That's fine of course. Just leave the corresponding code unchanged
> then.
I'll revert it, a
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 07:17:49PM CEST:
> I just want state explicitly that I'll wait until tomorrow
> (or even the day after) to merge and push the patches we have
> reviewed this afternoon, since the time for today is almost out,
> and I don't want to do a push without
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:44:32PM CEST:
> At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > > -$FGREP 'generic/a.$(OBJEXT)' Makefile.in
> > > +grep '^generic/a\.\$(OBJEXT):' Makefile.in
> >
> > Some day I'll add initial and trailing space to the target names of
> > al
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Wed, Jul 14, 2010 at 01:16:28PM CEST:
> > Remove a couple of obsoleted tests.
> >
> > * tests/fpinstall.test: Removed.
> > * tests/fpinst2.test: Likewise.
>
> OK for maint, but only if you also update tests/Makefile.{
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:53:21PM CEST:
> > At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > > Also, regenerating the tree with Autoconf 2.67 and committing
> > > that separately is preapproved for maint.
> >
> > Cou
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 01:13:07PM CEST:
> At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:53:21PM CEST:
> > > At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > > > Also, regenerating the tree with Autoconf 2.67
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 05:09:03PM CEST:
> At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > tgt1 tgt2 \
> > tgt3 : dep1 dep2 \
> > dep3 \
> > dep4
> >
> > Posix is perfectly clear about the list of targets
> Should be "tgt1 tgt2 tgt3 tgt4", r
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 05:09:03PM CEST:
> > At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > > tgt1 tgt2 \
> > >
> > > tgt3 : dep1 dep2 \
> > > dep3 \
> > >
> > > dep4
> > >
> > > P
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > > > foo=`extract_makefile_deps tgt2 Makefile`; echo x"$foo"x
> > >
> > > More or less, yes. I'd avoid the command substitution fork by
> > > letting extract_makefile_deps set some variable instead of
> > > printing.
> >
> > So the we'd have
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 05:35:57PM CEST:
> > I'm just saying that when we'll write the `extract_makefile_deps'
> > function, it shouldn't bother with preserving tabs and
> > backslashes;
>
> Well, it should deal with them
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 05:55:47PM CEST:
> At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > > 2. Automake, in its current incarnation, is mostly
> > > feature-complete IMHO
> >
> > I don't quite agree; esp. since several people want automake to do
> > several other
On Sat, Aug 7, 2010 at 09:03, Ralf Wildenhues wrote:
> Darn, we need another name: 'archive' is likely too common when automake
> is going to put all files with that name in the distribution of each
> package using Automake. No need to send another patch, but any other
> good suggestions that fit
Hello Ralf.
I just want state explicitly that I'll wait until tomorrow
(or even the day after) to merge and push the patches we have
reviewed this afternoon, since the time for today is almost out,
and I don't want to do a push without proper testing.
Regards,
Stefano
* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 01:16:28PM CEST:
> Remove a couple of obsoleted tests.
>
> * tests/fpinstall.test: Removed.
> * tests/fpinst2.test: Likewise.
OK for maint, but only if you also update tests/Makefile.{am,in}
to avoid subsequent testsuite failure. ;-)
Cheers,
* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 03:41:14PM CEST:
> * tests/subobjname.test: Add trailing `:' command.
> * tests/subobj.test: Make grepping of `Makefile.in' stricter.
> Escape literal dots in grep regexps.
> * tests/subobj2.test: Add trailing `:' command. Do not use the
> unport
* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 01:36:57PM CEST:
> * tests/all.test: Run aclocal only once. Minor cosmetic changes.
> Move checks that several *-local's in a single rule work ...
This sentence does not make sense to me. Maybe a missing word?
> * tests/manylocal.test: ... in th
I'm seeing a presumably new failure on Cygwin that I don't remember
seeing before. The gist is the following: transform2.test tries
something like
install bla.exe .../inst/bin/foo.exe
install script.sh .../inst/bin/foo
and the second one fails (to overwrite the foo.exe). Does anybody
happen
Den 2010-08-07 17:53 skrev Ralf Wildenhues:
* Ralf Wildenhues wrote on Sat, Aug 07, 2010 at 08:03:56AM CEST:
Darn, we need another name: 'archive' is likely too common when automake
is going to put all files with that name in the distribution of each
package using Automake. No need to send anot
* Stefano Lattarini wrote on Sun, Jun 27, 2010 at 04:48:03PM CEST:
> Another testsuite-tweaking patch. This time, the changes should be
> small and simple.
> Minor improvements for tests `acloca*.test'.
This is not ok. Let's just drop everything from it except for the
changes I've copied below
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sun, Aug 08, 2010 at 06:22:00PM CEST:
> > Exactly! So:
> > foo() { foo_result=`sed ...`; }
> > foo; bar=$foo_result;
> >
> > instead of:
> > foo() { sed ...; }
> > bar=`foo`
> >
> > Where is the significant im
* Stefano Lattarini wrote on Thu, Aug 05, 2010 at 01:54:20PM CEST:
> Ping on this? It seems to me that most issues with this patch had
> already been solved, so it's probably a pity to let it bitrotting
> here...
Well, I'd prefer the extract_dependencies script approach which
would be more corre
Hello Stefano,
* Stefano Lattarini wrote on Wed, Jul 14, 2010 at 03:26:04PM CEST:
> * tests/condd.test: Add trailing `:' command. Typofix in
> comment. Prefer fgrep over grep.
> * tests/condhook.test: Make sure target `install-data-hook' is
> not called by `make install', but that data files are
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> [ the gnu list server seems down ATM; expect delays ]
>
> Hi Stefano,
>
> * Stefano Lattarini wrote on Wed, Jul 28, 2010 at 11:07:20AM CEST:
> > At Wednesday 28 July 2010, Ralf Wildenhues wrote:
> > > But even then, when developing Automake you w
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:09:52PM CEST:
> I squashed the following into the first patch:
> It's OK for you?
Sure.
> > > (BTW, if my understanding is correct, this would make a nice
> > > addition to HACKING, too).
> >
> > Yep.
> Attached is a follow-up patch that does
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> OK for maint with nits below addressed, thanks!
> Ralf
>
> > --- a/tests/subobj2.test
> > +++ b/tests/subobj2.test
> > @@ -1,5 +1,5 @@
> >
> > #! /bin/sh
> >
> > -# Copyright (C) 1999, 2001, 2002 Free Software Foundation, Inc.
> > +# Copyright
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 12:53:21PM CEST:
> At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > Also, regenerating the tree with Autoconf 2.67 and committing that
> > separately is preapproved for maint.
> Couldn't this cause problems when later merging to master? If yes,
* Stefano Lattarini wrote on Tue, Jun 22, 2010 at 06:48:00PM CEST:
> Yet another testsuite-tweaking patch.
> * tests/depcomp.test: Do not create useless dummy source files.
> Add a trailing `:' command.
> * tests/depcomp2.test: Use `unset' on the CFLAG variable to ensure
> it's not in in the envir
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 01:29:19PM CEST:
> At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > Except this would have been caught by "make check" already, so it
> > doesn't count as an argument in favor of that patch, right? ;-)
> But "make check" is slooow on my machine
At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > Pardon my ignorance, but what do you mean by "a fake merge"?
>
> When you merge a branch A into B, then it can happen that git sees
> no conflicts, but in reality things break anyway. This can easily
> happen when, say, A renames a variable, B
* Stefano Lattarini wrote on Sun, Aug 08, 2010 at 06:06:04PM CEST:
> At Sunday 08 August 2010, Ralf Wildenhues wrote:
> > No. You save a fork with
> >
> > foo ()
> > {
> > ...
> > foo_result=bar
> > }
> >
> > foo ARG...
> > test "$foo_result" = ...
> >
> Yes, but how do you get
67 matches
Mail list logo
