Re: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.

2010-07-27 Thread Ralf Wildenhues
Hello Stefano, * Stefano Lattarini wrote on Tue, Jul 27, 2010 at 10:58:24PM CEST: > Subject: [PATCH 1/2] Bootstrap: let the user choose which autoconf to > use. Well, you should change > +AUTOCONF=${AUTOCONF-autoconf} to : ${AUTOCONF=autoconf} But even then, when developing Automake you wil

Re: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.

2010-07-27 Thread Eric Blake
On 07/27/2010 03:37 PM, Stefano Lattarini wrote: >>> I'm used to this variant, with less typing: >>> : ${AUTOCONF=autoconf} >>> >>> But your way works, too. > Can you confirm it's as portable as the ways suggested in the autoconf > manual? If yes, do you think it could be an useful addition to th

Re: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.

2010-07-27 Thread Stefano Lattarini
Hi Eric. At Tuesday 27 July 2010, Eric Blake wrote: > On 07/27/2010 03:08 PM, Eric Blake wrote: > > On 07/27/2010 02:58 PM, Stefano Lattarini wrote: > >> +# Let user choose which version of autoconf to use. > >> +AUTOCONF=${AUTOCONF-autoconf} > >> + > > > > I'm used to this variant, with less typ

Re: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.

2010-07-27 Thread Eric Blake
On 07/27/2010 03:08 PM, Eric Blake wrote: > On 07/27/2010 02:58 PM, Stefano Lattarini wrote: >> +# Let user choose which version of autoconf to use. >> +AUTOCONF=${AUTOCONF-autoconf} >> + > > I'm used to this variant, with less typing: > > : ${AUTOCONF=autoconf} > > But your way works, too. Huh

Re: [PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.

2010-07-27 Thread Eric Blake
On 07/27/2010 02:58 PM, Stefano Lattarini wrote: > +# Let user choose which version of autoconf to use. > +AUTOCONF=${AUTOCONF-autoconf} > + I'm used to this variant, with less typing: : ${AUTOCONF=autoconf} But your way works, too. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt

[PATCHES] Bootstrap: Allow user overriding of $AUTOCONF and $PERL.

2010-07-27 Thread Stefano Lattarini
Separated in two patches for easier cherry-picking. For maint. Regards, Stefano -*-*- Subject: [PATCH 1/2] Bootstrap: let the user choose which autoconf to use. * bootstrap ($AUTOCONF): New variable, from the environment. Use it instead of calling "autoconf" directly. --- ChangeLog |6

Re: Document current policy for development with git.

2010-07-27 Thread Eric Blake
On 07/27/2010 01:43 PM, Ralf Wildenhues wrote: > Hi Stefano, all, > > I've rewritten the HACKING section on development with git a bit to > better reflect what I currently think is a good way to go on. Patch > for maint. Comments appreciated. > > FYI, I am waiting for regenerating the in-tree f

Re: Document current policy for development with git.

2010-07-27 Thread Stefano Lattarini
At Tuesday 27 July 2010, Ralf Wildenhues wrote: > Hi Stefano, all, > > I've rewritten the HACKING section on development with git a bit to > better reflect what I currently think is a good way to go on. > Patch for maint. Comments appreciated. > > FYI, I am waiting for regenerating the in-tree

Re: Avoid syntax error if IF-TRUE part of AM_COND_IF is empty.

2010-07-27 Thread Eric Blake
On 07/27/2010 01:33 PM, Ralf Wildenhues wrote: > Adding this patch to maint to fix the glitch at least for the IF-TRUE > case. It's unfortunately not fixable as nicely in the IF-FALSE case > since we don't want to override $? there. > > @@ -27,8 +27,8 @@ AC_DEFUN([AM_COND_IF], > [m4_ifndef([_AM_

Re: trivial typo

2010-07-27 Thread Ralf Wildenhues
Hi Patrick, * Patrick Welche wrote on Sat, Jul 10, 2010 at 06:48:30PM CEST: > -Script are not distributed by default; as we have just seen, those > +Scripts are not distributed by default; as we have just seen, those Thanks! Committed to my maint branch, will be pushed out within the next couple

Document current policy for development with git.

2010-07-27 Thread Ralf Wildenhues
Hi Stefano, all, I've rewritten the HACKING section on development with git a bit to better reflect what I currently think is a good way to go on. Patch for maint. Comments appreciated. FYI, I am waiting for regenerating the in-tree files with Autoconf 2.67 until the official tarballs have come

Fix AM_COND_IF for gone-invalid condition shell expression.

2010-07-27 Thread Ralf Wildenhues
Fixing this kind of nasty (silent wrong-code) bug, for maint. Hope AM_COND_IF hasn't seen a lot of uses this way yet. Cheers, Ralf Fix AM_COND_IF for gone-invalid condition shell expression. * m4/cond-if.m4 (AM_COND_IF): test contents of $COND_TRUE variable, rather than re-evalua

Avoid syntax error if IF-TRUE part of AM_COND_IF is empty.

2010-07-27 Thread Ralf Wildenhues
Adding this patch to maint to fix the glitch at least for the IF-TRUE case. It's unfortunately not fixable as nicely in the IF-FALSE case since we don't want to override $? there. Cheers, Ralf Avoid syntax error if IF-TRUE part of AM_COND_IF expands empty. * m4/cond-if.m4 (AM_COND_I

Coverage: bogus option to AM_INIT_AUTOMAKE.

2010-07-27 Thread Ralf Wildenhues
I'm adding this trivial coverage addition to maint. Cheers, Ralf Coverage: bogus option to AM_INIT_AUTOMAKE. * tests/init2.test: New test. * tests/Makefile.am: Update. diff --git a/tests/Makefile.am b/tests/Makefile.am index 568be8a..4fc4d15 100644 --- a/tests/Makefile.am +++ b/