Hello Stefano,

* Stefano Lattarini wrote on Tue, Jul 27, 2010 at 10:58:24PM CEST:
> Subject: [PATCH 1/2] Bootstrap: let the user choose which autoconf to 
> use.

Well, you should change

> +AUTOCONF=${AUTOCONF-autoconf}

to
  : ${AUTOCONF=autoconf}

But even then, when developing Automake you will need to be extra
careful to never let autoconf be invoked from the rebuild rules; because
then, it will run plain "autoconf" and not the $AUTOCONF that you set.
So the safe thing to do is to ensure you have the right autoconf early
in $PATH.

The second patch is not ok.  The code prior to your patch already allows
the person running bootstrap to set PERL.  Changing that from an
absolute file name to a non-absolute one is a bad idea, it breaks
several test setups I have, and I've never had any complaints from
people who move their perl installation.

Cheers,
Ralf

Reply via email to