Re: [BIKESHEDDING PATCH] Generated tests are now just a thin layer around other tests.

2010-06-08 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Tue, Jun 08, 2010 at 01:31:00AM CEST: > At Monday 07 June 2010, Ralf Wildenhues wrote: BTW, is gmail configurable to not quote the email address in the tag line? Not that I realistically expect any spammer to not have mine, but it also causes the line to be overly lo

Re: [PATCH] Enable `errexit' shell flag in some test scripts.

2010-06-08 Thread Stefano Lattarini
At Tuesday 08 June 2010, Ralf Wildenhues wrote: > > -$ACLOCAL > output 2>&1 || { cat output; Exit 1; } > > -test -z "`cat output`" > > +$ACLOCAL >output 2>&1 || { cat output; Exit 1; } > > Do you do these changes with a script? No, since (as you pointed out many times), the use of `errexit' she

Re: [PATCH] Enable `errexit' shell flag in some test scripts.

2010-06-08 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Tue, Jun 08, 2010 at 04:20:39PM CEST: > Another patch to make the use of the `errexit' shell flag in the > testsuite more uniform. Thanks! For maint. > Enable `errexit' shell flag in some test scripts. > > * tests/subcond.test: Enabled `errexit' shell

Re: [PATCH] Improve declaration of dependencies in the testsuite.

2010-06-08 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Mon, Jun 07, 2010 at 11:23:23PM CEST: > Improve declaration of dependencies in the testsuite. > * tests/Makefile.am (check_SCRIPTS): Remove. Instead, let ... > ($(TEST_LOGS)): ... all test logs depend on the scripts. > * test/gen-parallel-tests: F

[PATCH] Fix botched changelog entry (2010-05-23, Stefano Lattarini)

2010-06-08 Thread Stefano Lattarini
A tiny patch re-adding an erroneously removed ChangeLog entry's summary. Regards, Stefano From 8d23cc7379f6e2423892e187d607168cbf9ae36b Mon Sep 17 00:00:00 2001 From: Stefano Lattarini Date: Tue, 8 Jun 2010 20:24:51 +0200 Subject: [PATCH] Fix botched changelog entry (2010-05-23, Stefano Lat

Re: [PATCH 2/2] Bugfix: $(AM_FLAGS)/$(FLAGS) precedence in Yacc/Lex.

2010-06-08 Thread Stefano Lattarini
This change probably deserves a NEWS entry. Since I was at it, I also rebased the patches against latest master. -*-*- * automake.in: Fix registration of languages "Lex", "Lex (C++)", "Yacc" and "Yacc (C++)", so that $(LFLAGS) has precedence over $(AM_LFLAGS) and $(YFLAGS) has precedence over $

Re: [PATCH 1/2] New tests, for bugs in Yacc/Lex AM_FLAGS and FLAGS precedence.

2010-06-08 Thread Stefano Lattarini
Rebased against master, for consistency with the second patch in this series. -*-*- * tests/lflags.test: New test, check that user $(LFLAGS) takes precedence over automake (AM_LFLAGS) and (foo_LFLAGS). Still xfailing. * tests/lflags2.test: Likewise. * tests/yflags.test: New test, check that use

[PATCH] Enable `errexit' shell flag in some test scripts.

2010-06-08 Thread Stefano Lattarini
Another patch to make the use of the `errexit' shell flag in the testsuite more uniform. This patch shouldn't introduce any portability problem, since the affected tests do not use shell functions, compound commands, nor command substitutions. Some of them do use the idiom: COMMAND >file || {