Hi Stefano,
* Stefano Lattarini wrote on Tue, Jun 08, 2010 at 04:20:39PM CEST:
> Another patch to make the use of the `errexit' shell flag in the
> testsuite more uniform.
Thanks! For maint.
> Enable `errexit' shell flag in some test scripts.
>
> * tests/subcond.test: Enabled `errexit' shell flag, and related
> minor changes.
> * tests/subst.test: Likewise.
> * tests/tags.test: Likewise.
> * tests/unused.test: Likewise.
> * tests/vars.test: Likewise.
> * tests/version4.test: Likewise.
> * tests/vpath.test: Likewise.
> * tests/vtexi2.test: Likewise.
> * tests/werror.test: Likewise.
> * tests/whoami.test: Likewise.
> * tests/acsilent.test: Likewise, and don't use a command
> substitution that can be easily avoided.
> * tests/version.test: Enabled `errexit' shell flag, and related
> minor changes. Also, avoid deprecated constructs in the generated
> `configure.in'.
> * tests/version2.test: Likewise.
> --- a/tests/acsilent.test
> +++ b/tests/acsilent.test
> -$ACLOCAL > output 2>&1 || { cat output; Exit 1; }
> -test -z "`cat output`"
> +$ACLOCAL >output 2>&1 || { cat output; Exit 1; }
Do you do these changes with a script? If not, then why such whitespace
changes? It's not like there is any consistency in spacing there in the
current code. (I'm asking because I actually had to look three times to
ensure I didn't overlook a non-whitespace change.)
> +cat output
> +test ! -s output
Cheers,
Ralf
